feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectConfiguration: Sprinkle override and explicit over the code

Browse Source 
Change-Id: I2aa3a32a0d30f1d122977d94d4109227dea6bbd7
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
Tobias Hunger
2015-11-13 11:06:27 +01:00
parent ca29cbfc8a
commit 0e278e9efe
52 changed files with 318 additions and 320 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/cmakeprojectmanager/cmakerunconfiguration.h
View File

@@ -57,32 +57,32 @@ class CMakeRunConfiguration : public ProjectExplorer::LocalApplicationRunConfigu
public:
CMakeRunConfiguration(ProjectExplorer::Target *parent, Core::Id id, const QString &target,
const QString &workingDirectory, const QString &title);
~CMakeRunConfiguration();
~CMakeRunConfiguration() override;
QString executable() const;
ProjectExplorer::ApplicationLauncher::Mode runMode() const;
QString workingDirectory() const;
QString commandLineArguments() const;
QWidget *createConfigurationWidget();
QString executable() const override;
ProjectExplorer::ApplicationLauncher::Mode runMode() const override;
QString workingDirectory() const override;
QString commandLineArguments() const override;
QWidget *createConfigurationWidget() override;
void setExecutable(const QString &executable);
void setBaseWorkingDirectory(const QString &workingDirectory);
QString title() const;
QVariantMap toMap() const;
QVariantMap toMap() const override;
void setEnabled(bool b);
bool isEnabled() const;
QString disabledReason() const;
bool isEnabled() const override;
QString disabledReason() const override;
signals:
void baseWorkingDirectoryChanged(const QString&);
protected:
CMakeRunConfiguration(ProjectExplorer::Target *parent, CMakeRunConfiguration *source);
virtual bool fromMap(const QVariantMap &map);
virtual bool fromMap(const QVariantMap &map) override;
QString defaultDisplayName() const;
private:

22
src/plugins/cmakeprojectmanager/makestep.h
View File

@@ -55,17 +55,17 @@ class MakeStep : public ProjectExplorer::AbstractProcessStep
friend class MakeStepFactory;
public:
MakeStep(ProjectExplorer::BuildStepList *bsl);
virtual ~MakeStep();
explicit MakeStep(ProjectExplorer::BuildStepList *bsl);
~MakeStep() override;
CMakeBuildConfiguration *cmakeBuildConfiguration() const;
virtual bool init();
bool init() override;
virtual void run(QFutureInterface<bool> &fi);
void run(QFutureInterface<bool> &fi) override;
virtual ProjectExplorer::BuildStepConfigWidget *createConfigWidget();
virtual bool immutable() const;
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;
bool immutable() const override;
QStringList buildTargets() const;
bool buildsBuildTarget(const QString &target) const;
@@ -80,7 +80,7 @@ public:
void setClean(bool clean);
QVariantMap toMap() const;
QVariantMap toMap() const override;
void setUserMakeCommand(const QString &make);
QString userMakeCommand() const;
@@ -93,16 +93,16 @@ signals:
void targetsToBuildChanged();
protected:
void processStarted();
void processFinished(int exitCode, QProcess::ExitStatus status);
void processStarted() override;
void processFinished(int exitCode, QProcess::ExitStatus status) override;
MakeStep(ProjectExplorer::BuildStepList *bsl, MakeStep *bs);
MakeStep(ProjectExplorer::BuildStepList *bsl, Core::Id id);
bool fromMap(const QVariantMap &map);
bool fromMap(const QVariantMap &map) override;
// For parsing [ 76%]
virtual void stdOutput(const QString &line);
virtual void stdOutput(const QString &line) override;
private:
void ctor();