feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Rename method to the more correct canCreateForBuildConfiguration

Browse Source
This commit is contained in:
dt
2009-11-25 20:00:28 +01:00
parent a7a7e4d002
commit 0e4e35f876
12 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cmakeprojectmanager/makestep.cpp
View File

@@ -284,7 +284,7 @@ BuildStep *MakeStepFactory::clone(BuildStep *bs, BuildConfiguration *bc) const
return new MakeStep(static_cast<MakeStep *>(bs), bc); return new MakeStep(static_cast<MakeStep *>(bs), bc);
} }
QStringList MakeStepFactory::canCreateForProject(BuildConfiguration * /* pro */) const QStringList MakeStepFactory::canCreateForBuildConfiguration(BuildConfiguration * /* pro */) const
{ {
return QStringList(); return QStringList();
} }

2
src/plugins/cmakeprojectmanager/makestep.h
View File

@@ -107,7 +107,7 @@ class MakeStepFactory : public ProjectExplorer::IBuildStepFactory
virtual bool canCreate(const QString &name) const; virtual bool canCreate(const QString &name) const;
virtual ProjectExplorer::BuildStep *create(ProjectExplorer::BuildConfiguration *bc, const QString &name) const; virtual ProjectExplorer::BuildStep *create(ProjectExplorer::BuildConfiguration *bc, const QString &name) const;
virtual ProjectExplorer::BuildStep *clone(ProjectExplorer::BuildStep *bs, ProjectExplorer::BuildConfiguration *bc) const; virtual ProjectExplorer::BuildStep *clone(ProjectExplorer::BuildStep *bs, ProjectExplorer::BuildConfiguration *bc) const;
virtual QStringList canCreateForProject(ProjectExplorer::BuildConfiguration *bc) const; virtual QStringList canCreateForBuildConfiguration(ProjectExplorer::BuildConfiguration *bc) const;
virtual QString displayNameForName(const QString &name) const; virtual QString displayNameForName(const QString &name) const;
}; };

2
src/plugins/genericprojectmanager/genericmakestep.cpp
View File

@@ -292,7 +292,7 @@ ProjectExplorer::BuildStep *GenericMakeStepFactory::clone(ProjectExplorer::Build
return new GenericMakeStep(static_cast<GenericMakeStep*>(bs), bc); return new GenericMakeStep(static_cast<GenericMakeStep*>(bs), bc);
} }
QStringList GenericMakeStepFactory::canCreateForProject(ProjectExplorer::BuildConfiguration * /* pro */) const QStringList GenericMakeStepFactory::canCreateForBuildConfiguration(ProjectExplorer::BuildConfiguration * /* pro */) const
{ {
return QStringList(); return QStringList();
} }

2
src/plugins/genericprojectmanager/genericmakestep.h
View File

@@ -107,7 +107,7 @@ class GenericMakeStepFactory : public ProjectExplorer::IBuildStepFactory
const QString &name) const; const QString &name) const;
virtual ProjectExplorer::BuildStep *clone(ProjectExplorer::BuildStep *bs, virtual ProjectExplorer::BuildStep *clone(ProjectExplorer::BuildStep *bs,
ProjectExplorer::BuildConfiguration *bc) const; ProjectExplorer::BuildConfiguration *bc) const;
virtual QStringList canCreateForProject(ProjectExplorer::BuildConfiguration *bc) const; virtual QStringList canCreateForBuildConfiguration(ProjectExplorer::BuildConfiguration *bc) const;
virtual QString displayNameForName(const QString &name) const; virtual QString displayNameForName(const QString &name) const;
}; };

2
src/plugins/projectexplorer/buildstep.h
View File

@@ -133,7 +133,7 @@ public:
virtual BuildStep *create(BuildConfiguration *bc, const QString &name) const = 0; virtual BuildStep *create(BuildConfiguration *bc, const QString &name) const = 0;
/// Called by the add BuildStep action to check which BuildSteps could be added /// Called by the add BuildStep action to check which BuildSteps could be added
/// to the project by this factory, should return a list of names /// to the project by this factory, should return a list of names
virtual QStringList canCreateForProject(BuildConfiguration *bc) const = 0; virtual QStringList canCreateForBuildConfiguration(BuildConfiguration *bc) const = 0;
/// Called to convert an internal name to a displayName /// Called to convert an internal name to a displayName
/// Called to clone a BuildStep /// Called to clone a BuildStep

2
src/plugins/projectexplorer/buildstepspage.cpp
View File

@@ -143,7 +143,7 @@ void BuildStepsPage::updateAddBuildStepMenu()
//Build up a list of possible steps and save map the display names to the (internal) name and factories. //Build up a list of possible steps and save map the display names to the (internal) name and factories.
QList<IBuildStepFactory *> factories = ExtensionSystem::PluginManager::instance()->getObjects<IBuildStepFactory>(); QList<IBuildStepFactory *> factories = ExtensionSystem::PluginManager::instance()->getObjects<IBuildStepFactory>();
foreach (IBuildStepFactory * factory, factories) { foreach (IBuildStepFactory * factory, factories) {
QStringList names = factory->canCreateForProject(m_configuration); QStringList names = factory->canCreateForBuildConfiguration(m_configuration);
foreach (const QString &name, names) { foreach (const QString &name, names) {
map.insert(factory->displayNameForName(name), QPair<QString, IBuildStepFactory *>(name, factory)); map.insert(factory->displayNameForName(name), QPair<QString, IBuildStepFactory *>(name, factory));
} }

2
src/plugins/projectexplorer/processstep.cpp
View File

@@ -212,7 +212,7 @@ BuildStep *ProcessStepFactory::clone(BuildStep *bs, BuildConfiguration *bc) cons
return new ProcessStep(static_cast<ProcessStep *>(bs), bc); return new ProcessStep(static_cast<ProcessStep *>(bs), bc);
} }
QStringList ProcessStepFactory::canCreateForProject(BuildConfiguration *bc) const QStringList ProcessStepFactory::canCreateForBuildConfiguration(BuildConfiguration *bc) const
{ {
Q_UNUSED(bc) Q_UNUSED(bc)
return QStringList()<<"projectexplorer.processstep"; return QStringList()<<"projectexplorer.processstep";

2
src/plugins/projectexplorer/processstep.h
View File

@@ -47,7 +47,7 @@ public:
virtual bool canCreate(const QString &name) const; virtual bool canCreate(const QString &name) const;
virtual BuildStep *create(BuildConfiguration *bc, const QString &name) const; virtual BuildStep *create(BuildConfiguration *bc, const QString &name) const;
virtual BuildStep *clone(BuildStep *bs, BuildConfiguration *bc) const; virtual BuildStep *clone(BuildStep *bs, BuildConfiguration *bc) const;
virtual QStringList canCreateForProject(BuildConfiguration *pro) const; virtual QStringList canCreateForBuildConfiguration(BuildConfiguration *pro) const;
virtual QString displayNameForName(const QString &name) const; virtual QString displayNameForName(const QString &name) const;
}; };

2
src/plugins/qt4projectmanager/makestep.cpp
View File

@@ -335,7 +335,7 @@ ProjectExplorer::BuildStep *MakeStepFactory::clone(ProjectExplorer::BuildStep *b
return new MakeStep(static_cast<MakeStep *>(bs), bc); return new MakeStep(static_cast<MakeStep *>(bs), bc);
} }
QStringList MakeStepFactory::canCreateForProject(ProjectExplorer::BuildConfiguration *pro) const QStringList MakeStepFactory::canCreateForBuildConfiguration(ProjectExplorer::BuildConfiguration *pro) const
{ {
if (qobject_cast<Qt4BuildConfiguration *>(pro)) if (qobject_cast<Qt4BuildConfiguration *>(pro))
return QStringList() << Constants::MAKESTEP; return QStringList() << Constants::MAKESTEP;

2
src/plugins/qt4projectmanager/makestep.h
View File

@@ -54,7 +54,7 @@ public:
bool canCreate(const QString & name) const; bool canCreate(const QString & name) const;
ProjectExplorer::BuildStep *create(ProjectExplorer::BuildConfiguration *bc, const QString & name) const; ProjectExplorer::BuildStep *create(ProjectExplorer::BuildConfiguration *bc, const QString & name) const;
ProjectExplorer::BuildStep *clone(ProjectExplorer::BuildStep *bs, ProjectExplorer::BuildConfiguration *bc) const; ProjectExplorer::BuildStep *clone(ProjectExplorer::BuildStep *bs, ProjectExplorer::BuildConfiguration *bc) const;
QStringList canCreateForProject(ProjectExplorer::BuildConfiguration *bc) const; QStringList canCreateForBuildConfiguration(ProjectExplorer::BuildConfiguration *bc) const;
QString displayNameForName(const QString &name) const; QString displayNameForName(const QString &name) const;
}; };
} }

2
src/plugins/qt4projectmanager/qmakestep.cpp
View File

@@ -377,7 +377,7 @@ ProjectExplorer::BuildStep *QMakeStepFactory::clone(ProjectExplorer::BuildStep *
return new QMakeStep(static_cast<QMakeStep *>(bs), bc); return new QMakeStep(static_cast<QMakeStep *>(bs), bc);
} }
QStringList QMakeStepFactory::canCreateForProject(ProjectExplorer::BuildConfiguration *bc) const QStringList QMakeStepFactory::canCreateForBuildConfiguration(ProjectExplorer::BuildConfiguration *bc) const
{ {
if (qobject_cast<Qt4BuildConfiguration *>(bc)) if (qobject_cast<Qt4BuildConfiguration *>(bc))
return QStringList() << Constants::QMAKESTEP; return QStringList() << Constants::QMAKESTEP;

2
src/plugins/qt4projectmanager/qmakestep.h
View File

@@ -54,7 +54,7 @@ public:
bool canCreate(const QString & name) const; bool canCreate(const QString & name) const;
ProjectExplorer::BuildStep *create(ProjectExplorer::BuildConfiguration *bc, const QString & name) const; ProjectExplorer::BuildStep *create(ProjectExplorer::BuildConfiguration *bc, const QString & name) const;
ProjectExplorer::BuildStep *clone(ProjectExplorer::BuildStep *bs, ProjectExplorer::BuildConfiguration *bc) const; ProjectExplorer::BuildStep *clone(ProjectExplorer::BuildStep *bs, ProjectExplorer::BuildConfiguration *bc) const;
QStringList canCreateForProject(ProjectExplorer::BuildConfiguration *bc) const; QStringList canCreateForBuildConfiguration(ProjectExplorer::BuildConfiguration *bc) const;
QString displayNameForName(const QString &name) const; QString displayNameForName(const QString &name) const;
}; };
} }