From 0e62487fb369d1d48432192da4c744d58c64d716 Mon Sep 17 00:00:00 2001 From: Erik Verbruggen Date: Wed, 17 Jul 2013 14:15:58 +0200 Subject: [PATCH] Git: fix compilation failure in Qt4 specific code. Caused by 762099487cde386b206953cc84dafae13ab1fcc2 where a memory pool was introduced to fix memory leakage. Change-Id: Ib2f7c53e9560ff473fcdfedd6dcfce50455095da Reviewed-by: Nikolai Kosjar Reviewed-by: Przemyslaw Gorszkowski Reviewed-by: Orgad Shaneh Reviewed-by: Friedemann Kleint --- src/plugins/git/gerrit/gerritmodel.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/plugins/git/gerrit/gerritmodel.cpp b/src/plugins/git/gerrit/gerritmodel.cpp index b7cb210b976..0623f9f65cc 100644 --- a/src/plugins/git/gerrit/gerritmodel.cpp +++ b/src/plugins/git/gerrit/gerritmodel.cpp @@ -664,11 +664,13 @@ static bool parseOutput(const QSharedPointer ¶meters, result.clear(); result.reserve(lines.size()); + Utils::JsonMemoryPool pool; + foreach (const QByteArray &line, lines) { if (line.isEmpty()) continue; - QScopedPointer objectValue(Utils::JsonValue::create(QString::fromUtf8(line))); - if (objectValue.isNull()) { + Utils::JsonValue *objectValue = Utils::JsonValue::create(QString::fromUtf8(line), &pool); + if (!objectValue) { QString errorMessage = GerritModel::tr("Parse error: '%1'") .arg(QString::fromLocal8Bit(line)); qWarning() << errorMessage;