feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Axivion: Fix version handling for markers

Browse Source 
Do not use the versioned marker, but the last available
version instead.
Do not refetch markers on changing the version end.

Fixes: QTCREATORBUG-32373
Change-Id: I963af916eb37f965131577eb8844aa0b3473a72c
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
Reviewed-by: Mohammad Mehdi Salem Naraghi <mehdi.salem@qt.io>
This commit is contained in:
Christian Stenger
2025-01-23 10:38:47 +01:00
parent fe2a3bda65
commit 0ee1df8235
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/axivion/axivionplugin.cpp
View File

@@ -952,10 +952,9 @@ Group lineMarkerRecipe(const FilePath &filePath, const LineMarkerHandler &handle
{ {
QTC_ASSERT(dd->m_currentProjectInfo, return {}); // TODO: Call handler with unexpected? QTC_ASSERT(dd->m_currentProjectInfo, return {}); // TODO: Call handler with unexpected?
QTC_ASSERT(!filePath.isEmpty(), return {}); // TODO: Call handler with unexpected? QTC_ASSERT(!filePath.isEmpty(), return {}); // TODO: Call handler with unexpected?
QTC_ASSERT(dd->m_analysisVersion, return {}); // TODO: Call handler with unexpected?
const QString fileName = QString::fromUtf8(QUrl::toPercentEncoding(filePath.path())); const QString fileName = QString::fromUtf8(QUrl::toPercentEncoding(filePath.path()));
const QUrlQuery query({{"filename", fileName}, {"version", *dd->m_analysisVersion}}); const QUrlQuery query({{"filename", fileName}});
const QUrl url = constructUrl(dd->m_currentProjectInfo->name, "files", query); const QUrl url = constructUrl(dd->m_currentProjectInfo->name, "files", query);
return fetchDataRecipe<Dto::FileViewDto>(url, handler); return fetchDataRecipe<Dto::FileViewDto>(url, handler);
} }
@@ -1257,9 +1256,6 @@ void setAnalysisVersion(const QString &version)
if (dd->m_analysisVersion.value_or("") == version) if (dd->m_analysisVersion.value_or("") == version)
return; return;
dd->m_analysisVersion = version; dd->m_analysisVersion = version;
// refetch issues for already opened docs
dd->clearAllMarks();
dd->handleOpenedDocs();
} }
void enableInlineIssues(bool enable) void enableInlineIssues(bool enable)