From 0fe56faaf9aeb9b541056903bb96c2b8a20529f3 Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Thu, 13 Mar 2025 06:43:37 +0100 Subject: [PATCH] ScreenRecorder: Move function into its needed scope Silences a warning for release build. Amends 200074c4ac59f223bdf72d7f6fe68146e7327dbe. Change-Id: Ie657621b0334efd73655e6c15f96335ab75116ec Reviewed-by: Alessandro Portale --- src/plugins/screenrecorder/ffmpegutils.cpp | 24 +++++++++++----------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/plugins/screenrecorder/ffmpegutils.cpp b/src/plugins/screenrecorder/ffmpegutils.cpp index 419e558ae28..1ebff41e45a 100644 --- a/src/plugins/screenrecorder/ffmpegutils.cpp +++ b/src/plugins/screenrecorder/ffmpegutils.cpp @@ -137,18 +137,6 @@ bool CropSizeWarningIcon::needsWarning() const namespace FFmpegUtils { -static QVersionNumber parseVersionNumber(const QByteArray &toolOutput) -{ - QVersionNumber result; - const QJsonObject jsonObject = QJsonDocument::fromJson(toolOutput).object(); - if (const QJsonObject program_version = jsonObject.value("program_version").toObject(); - !program_version.isEmpty()) { - if (const QJsonValue version = program_version.value("version"); !version.isUndefined()) - result = QVersionNumber::fromString(version.toString()); - } - return result; -} - static ClipInfo parseClipInfo(const QByteArray &toolOutput) { ClipInfo result; @@ -248,6 +236,18 @@ using namespace ScreenRecorder::FFmpegUtils; namespace ScreenRecorder::Internal { +static QVersionNumber parseVersionNumber(const QByteArray &toolOutput) +{ + QVersionNumber result; + const QJsonObject jsonObject = QJsonDocument::fromJson(toolOutput).object(); + if (const QJsonObject program_version = jsonObject.value("program_version").toObject(); + !program_version.isEmpty()) { + if (const QJsonValue version = program_version.value("version"); !version.isUndefined()) + result = QVersionNumber::fromString(version.toString()); + } + return result; +} + void FFmpegOutputParserTest::testVersionParser_data() { QTest::addColumn("ffprobeVersionOutput");