From 1005fa9b68f61f56829f117177c27791991deb38 Mon Sep 17 00:00:00 2001 From: Marco Bubke Date: Mon, 25 Sep 2017 19:20:39 +0200 Subject: [PATCH] Clang: Initialize HighlightingTypes to Invalid It is too easy to forget to initialize the type, so it can have a wrong value. Actually we should use exceptions elsewhere because this can be simply hiding bugs. Change-Id: I71c0b467c12409b489c173e3edc53cdaa406bf09 Reviewed-by: Ivan Donchevskii Reviewed-by: Orgad Shaneh --- src/libs/clangsupport/clangsupport_global.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/clangsupport/clangsupport_global.h b/src/libs/clangsupport/clangsupport_global.h index b2fc639291a..f69b11b7d2e 100644 --- a/src/libs/clangsupport/clangsupport_global.h +++ b/src/libs/clangsupport/clangsupport_global.h @@ -154,7 +154,7 @@ struct MessageTrait \ using MixinHighlightingTypes = Utils::SizedArray; struct HighlightingTypes { - HighlightingType mainHighlightingType; + HighlightingType mainHighlightingType = HighlightingType::Invalid; MixinHighlightingTypes mixinHighlightingTypes; };