Make some qHash and comparison operators overloads hidden friends

Restricts lookup scope more to necessary bits.

Change-Id: Ia42c95aaa70534843b7f6a90bfc56d2a1202c612
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2021-12-06 05:11:04 +01:00
parent 8cb5c3cfdd
commit 104ea4accc
75 changed files with 461 additions and 518 deletions

View File

@@ -36,46 +36,46 @@ QT_END_NAMESPACE
namespace QmlJSEditor {
class QmlJsEditingSettings {
public:
QmlJsEditingSettings();
class QmlJsEditingSettings
{
public:
QmlJsEditingSettings();
static QmlJsEditingSettings get();
void set();
static QmlJsEditingSettings get();
void set();
void fromSettings(QSettings *);
void toSettings(QSettings *) const;
void fromSettings(QSettings *);
void toSettings(QSettings *) const;
bool equals(const QmlJsEditingSettings &other) const;
bool equals(const QmlJsEditingSettings &other) const;
bool enableContextPane() const;
void setEnableContextPane(const bool enableContextPane);
bool enableContextPane() const;
void setEnableContextPane(const bool enableContextPane);
bool pinContextPane() const;
void setPinContextPane(const bool pinContextPane);
bool pinContextPane() const;
void setPinContextPane(const bool pinContextPane);
bool autoFormatOnSave() const;
void setAutoFormatOnSave(const bool autoFormatOnSave);
bool autoFormatOnSave() const;
void setAutoFormatOnSave(const bool autoFormatOnSave);
bool autoFormatOnlyCurrentProject() const;
void setAutoFormatOnlyCurrentProject(const bool autoFormatOnlyCurrentProject);
bool autoFormatOnlyCurrentProject() const;
void setAutoFormatOnlyCurrentProject(const bool autoFormatOnlyCurrentProject);
bool foldAuxData() const;
void setFoldAuxData(const bool foldAuxData);
bool foldAuxData() const;
void setFoldAuxData(const bool foldAuxData);
private:
bool m_enableContextPane;
bool m_pinContextPane;
bool m_autoFormatOnSave;
bool m_autoFormatOnlyCurrentProject;
bool m_foldAuxData;
};
inline bool operator==(const QmlJsEditingSettings &s1, const QmlJsEditingSettings &s2)
friend bool operator==(const QmlJsEditingSettings &s1, const QmlJsEditingSettings &s2)
{ return s1.equals(s2); }
inline bool operator!=(const QmlJsEditingSettings &s1, const QmlJsEditingSettings &s2)
friend bool operator!=(const QmlJsEditingSettings &s1, const QmlJsEditingSettings &s2)
{ return !s1.equals(s2); }
private:
bool m_enableContextPane;
bool m_pinContextPane;
bool m_autoFormatOnSave;
bool m_autoFormatOnlyCurrentProject;
bool m_foldAuxData;
};
namespace Internal {