feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't return negative numbers in sdktool

Browse Source 
Negative return values are interpreted as 'process crashed' on
Windows: QTBUG-28735 . This in turn means the installer framework
always shows an error dialog.

By using positive numbers even for error conditions the installer
can decide to ignore certain errors instead.

Change-Id: Ib5cdd461372ac13fe417feb6ff43a7424c159f68
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Kai Koehne
2013-07-08 08:35:18 +02:00
committed by Tobias Hunger
parent 486b5c4739
commit 108899ef8f
9 changed files with 19 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/tools/sdktool/addkitoperation.cpp
View File

@@ -219,9 +219,9 @@ int AddKitOperation::execute() const
m_deviceType.toUtf8(), m_sysRoot, m_tc, m_qt, m_mkspec, m_extra);
if (result.isEmpty() || map == result)
return -2;
return 2;
return save(result, QLatin1String("profiles")) ? 0 : -3;
return save(result, QLatin1String("profiles")) ? 0 : 3;
}
#ifdef WITH_TESTS