feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QbsProjectManager: Replace some uses of Node::projectNodes()

Browse Source 
No need to use two filters with a temporary list when the
task can be done in one go.

Change-Id: I96468099eb28c9698dbc637e432a38071d054e39
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
hjk
2017-02-15 14:22:42 +01:00
parent fd9877755f
commit 10b56f8930
1 changed files with 12 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/plugins/qbsprojectmanager/qbsnodes.cpp
View File

@@ -674,10 +674,10 @@ QList<ProjectExplorer::RunConfiguration *> QbsProductNode::runConfigurations() c
QbsGroupNode *QbsProductNode::findGroupNode(const QString &name) QbsGroupNode *QbsProductNode::findGroupNode(const QString &name)
{ {
foreach (ProjectExplorer::ProjectNode *n, projectNodes()) { for (ProjectExplorer::Node *n : nodes()) {
QbsGroupNode *qn = static_cast<QbsGroupNode *>(n); if (QbsGroupNode *qn = dynamic_cast<QbsGroupNode *>(n))
if (qn->qbsGroupData().name() == name) if (qn->qbsGroupData().name() == name)
return qn; return qn;
} }
return 0; return 0;
} }
@@ -743,20 +743,20 @@ void QbsProjectNode::ctor()
QbsProductNode *QbsProjectNode::findProductNode(const QString &uniqueName) QbsProductNode *QbsProjectNode::findProductNode(const QString &uniqueName)
{ {
foreach (ProjectExplorer::ProjectNode *n, projectNodes()) { for (ProjectExplorer::Node *n : nodes()) {
QbsProductNode *qn = dynamic_cast<QbsProductNode *>(n); if (QbsProductNode *qn = dynamic_cast<QbsProductNode *>(n))
if (qn && QbsProject::uniqueProductName(qn->qbsProductData()) == uniqueName) if (QbsProject::uniqueProductName(qn->qbsProductData()) == uniqueName)
return qn; return qn;
} }
return 0; return 0;
} }
QbsProjectNode *QbsProjectNode::findProjectNode(const QString &name) QbsProjectNode *QbsProjectNode::findProjectNode(const QString &name)
{ {
foreach (ProjectExplorer::ProjectNode *n, projectNodes()) { for (ProjectExplorer::Node *n : nodes()) {
QbsProjectNode *qn = dynamic_cast<QbsProjectNode *>(n); if (QbsProjectNode *qn = dynamic_cast<QbsProjectNode *>(n))
if (qn && qn->qbsProjectData().name() == name) if (qn->qbsProjectData().name() == name)
return qn; return qn;
} }
return 0; return 0;
} }