diff --git a/src/tools/buildoutputparser/buildoutputparser.pro b/src/tools/buildoutputparser/buildoutputparser.pro index 53cb6b44343..3a0bce085ff 100644 --- a/src/tools/buildoutputparser/buildoutputparser.pro +++ b/src/tools/buildoutputparser/buildoutputparser.pro @@ -6,8 +6,6 @@ include(../../qtcreatortool.pri) TARGET = buildoutputparser -win32|equals(TEST, 1):DEFINES += HAS_MSVC_PARSER - SOURCES = \ main.cpp \ outputprocessor.cpp diff --git a/src/tools/buildoutputparser/buildoutputparser.qbs b/src/tools/buildoutputparser/buildoutputparser.qbs index ad021e2a384..7c929545690 100644 --- a/src/tools/buildoutputparser/buildoutputparser.qbs +++ b/src/tools/buildoutputparser/buildoutputparser.qbs @@ -15,6 +15,4 @@ QtcTool { condition: qbs.targetOS.contains("unix") && !qbs.targetOS.contains("darwin") cpp.rpaths: base.concat(["$ORIGIN/../" + qtc.ide_plugin_path]) } - cpp.defines: base.concat(qbs.targetOS.contains("windows") || qtc.testsEnabled - ? ["HAS_MSVC_PARSER"] : []) } diff --git a/src/tools/buildoutputparser/main.cpp b/src/tools/buildoutputparser/main.cpp index 78556f9f298..6fe0255702c 100644 --- a/src/tools/buildoutputparser/main.cpp +++ b/src/tools/buildoutputparser/main.cpp @@ -52,13 +52,7 @@ static void printUsage() { fprintf(stderr, "Usage: %s [--type ] \n", qPrintable(QFileInfo(QCoreApplication::applicationFilePath()).fileName())); - fprintf(stderr, "Possible compiler types: gcc, clang%s. Default is gcc.\n", -#ifdef HAS_MSVC_PARSER - ", msvc" -#else - "" -#endif - ); + fprintf(stderr, "Possible compiler types: gcc, clang, msvc. Default is gcc.\n"); } int main(int argc, char *argv[]) @@ -83,10 +77,8 @@ int main(int argc, char *argv[]) compilerType = CompilerTypeGcc; } else if (typeString == QLatin1String("clang")) { compilerType = CompilerTypeClang; -#ifdef HAS_MSVC_PARSER } else if (typeString == QLatin1String("msvc")) { compilerType = CompilerTypeMsvc; -#endif } else { fprintf(stderr, "Invalid compiler type '%s'.\n", qPrintable(typeString)); printUsage(); diff --git a/src/tools/buildoutputparser/outputprocessor.cpp b/src/tools/buildoutputparser/outputprocessor.cpp index 103a2d6b1fc..3922d0fc0be 100644 --- a/src/tools/buildoutputparser/outputprocessor.cpp +++ b/src/tools/buildoutputparser/outputprocessor.cpp @@ -28,14 +28,12 @@ #include #include #include +#include #include #include #include #include -#ifdef HAS_MSVC_PARSER -#include -#endif #include #include @@ -67,11 +65,9 @@ void CompilerOutputProcessor::start() case CompilerTypeClang: parser.appendOutputParser(new ProjectExplorer::ClangParser); break; -#ifdef HAS_MSVC_PARSER case CompilerTypeMsvc: parser.appendOutputParser(new ProjectExplorer::MsvcParser); break; -#endif } connect(&parser, &ProjectExplorer::IOutputParser::addTask, diff --git a/src/tools/buildoutputparser/outputprocessor.h b/src/tools/buildoutputparser/outputprocessor.h index 3dc1c25df93..5595c39004b 100644 --- a/src/tools/buildoutputparser/outputprocessor.h +++ b/src/tools/buildoutputparser/outputprocessor.h @@ -34,10 +34,8 @@ namespace ProjectExplorer { class Task; } enum CompilerType { CompilerTypeGcc, - CompilerTypeClang -#ifdef HAS_MSVC_PARSER - , CompilerTypeMsvc -#endif + CompilerTypeClang, + CompilerTypeMsvc }; class CompilerOutputProcessor : public QObject