diff --git a/src/plugins/valgrind/valgrind/xmlprotocol/error.cpp b/src/plugins/valgrind/valgrind/xmlprotocol/error.cpp index 3742456142a..70c7f5427c9 100644 --- a/src/plugins/valgrind/valgrind/xmlprotocol/error.cpp +++ b/src/plugins/valgrind/valgrind/xmlprotocol/error.cpp @@ -248,7 +248,7 @@ QString Error::toXml() const if (!frame.file().isEmpty()) { stream << " " << frame.file() << "\n"; } - if (!frame.line() == -1) { + if (frame.line() != -1) { stream << " " << frame.line() << ""; } stream << " \n"; diff --git a/src/plugins/valgrind/valgrind/xmlprotocol/frame.cpp b/src/plugins/valgrind/valgrind/xmlprotocol/frame.cpp index 9b36a4a3680..876af1bf270 100644 --- a/src/plugins/valgrind/valgrind/xmlprotocol/frame.cpp +++ b/src/plugins/valgrind/valgrind/xmlprotocol/frame.cpp @@ -43,9 +43,7 @@ namespace XmlProtocol { class Frame::Private : public QSharedData { public: - explicit Private() : - ip(0), line( -1 ) - {} + Private() : ip(0), line(-1) {} bool operator==(const Private &other) const { @@ -74,7 +72,7 @@ Frame::~Frame() } Frame::Frame(const Frame &other) : - d( other.d ) + d(other.d) { }