From 10fb989cf6916c5cb60385d70a56c1ee8754be45 Mon Sep 17 00:00:00 2001
From: hjk <qtc-committer@nokia.com>
Date: Thu, 7 Jul 2011 14:45:27 +0200
Subject: [PATCH] valgrind backend: fix bug "!line == -1"
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change-Id: I2b467d3954fa603fa8ac59f4681716ea8d2a1d36
Reviewed-on: http://codereview.qt.nokia.com/1310
Reviewed-by: Robert Löhning <robert.loehning@nokia.com>
---
 src/plugins/valgrind/valgrind/xmlprotocol/error.cpp | 2 +-
 src/plugins/valgrind/valgrind/xmlprotocol/frame.cpp | 6 ++----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/plugins/valgrind/valgrind/xmlprotocol/error.cpp b/src/plugins/valgrind/valgrind/xmlprotocol/error.cpp
index 3742456142a..70c7f5427c9 100644
--- a/src/plugins/valgrind/valgrind/xmlprotocol/error.cpp
+++ b/src/plugins/valgrind/valgrind/xmlprotocol/error.cpp
@@ -248,7 +248,7 @@ QString Error::toXml() const
             if (!frame.file().isEmpty()) {
                 stream << "      <file>" << frame.file() << "</file>\n";
             }
-            if (!frame.line() == -1) {
+            if (frame.line() != -1) {
                 stream << "      <line>" << frame.line() << "</line>";
             }
             stream << "    </frame>\n";
diff --git a/src/plugins/valgrind/valgrind/xmlprotocol/frame.cpp b/src/plugins/valgrind/valgrind/xmlprotocol/frame.cpp
index 9b36a4a3680..876af1bf270 100644
--- a/src/plugins/valgrind/valgrind/xmlprotocol/frame.cpp
+++ b/src/plugins/valgrind/valgrind/xmlprotocol/frame.cpp
@@ -43,9 +43,7 @@ namespace XmlProtocol {
 class Frame::Private : public QSharedData
 {
 public:
-    explicit Private() :
-        ip(0), line( -1 )
-    {}
+    Private() : ip(0), line(-1) {}
 
     bool operator==(const Private &other) const
     {
@@ -74,7 +72,7 @@ Frame::~Frame()
 }
 
 Frame::Frame(const Frame &other) :
-    d( other.d )
+    d(other.d)
 {
 }