feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

valgrind backend: fix bug "!line == -1"

Browse Source 
Change-Id: I2b467d3954fa603fa8ac59f4681716ea8d2a1d36
Reviewed-on: http://codereview.qt.nokia.com/1310
Reviewed-by: Robert Löhning <robert.loehning@nokia.com>
This commit is contained in:
hjk
2011-07-07 14:45:27 +02:00
committed by Robert Löhning
parent 6400d8423a
commit 10fb989cf6
2 changed files with 3 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/valgrind/valgrind/xmlprotocol/error.cpp
View File

@@ -248,7 +248,7 @@ QString Error::toXml() const
if (!frame.file().isEmpty()) { if (!frame.file().isEmpty()) {
stream << " <file>" << frame.file() << "</file>\n"; stream << " <file>" << frame.file() << "</file>\n";
} }
if (!frame.line() == -1) { if (frame.line() != -1) {
stream << " <line>" << frame.line() << "</line>"; stream << " <line>" << frame.line() << "</line>";
} }
stream << " </frame>\n"; stream << " </frame>\n";

6
src/plugins/valgrind/valgrind/xmlprotocol/frame.cpp
View File

@@ -43,9 +43,7 @@ namespace XmlProtocol {
class Frame::Private : public QSharedData class Frame::Private : public QSharedData
{ {
public: public:
explicit Private() : Private() : ip(0), line(-1) {}
ip(0), line( -1 )
{}
bool operator==(const Private &other) const bool operator==(const Private &other) const
{ {
@@ -74,7 +72,7 @@ Frame::~Frame()
} }
Frame::Frame(const Frame &other) : Frame::Frame(const Frame &other) :
d( other.d ) d(other.d)
{ {
} }