feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QtSupport: Remove unused QtVersionManager functions

Browse Source 
Change-Id: Ic6bc4c56ebedc71ff4c136fd201b8a236384c3fd
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2019-08-15 11:46:37 +02:00
parent 217332a48f
commit 110f6dece9
2 changed files with 0 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/qtsupport/qtversionmanager.cpp
View File

@@ -503,12 +503,6 @@ QList<BaseQtVersion *> QtVersionManager::sortVersions(const QList<BaseQtVersion
return result; return result;
} }
bool QtVersionManager::isValidId(int id)
{
QTC_ASSERT(isLoaded(), return false);
return m_versions.contains(id);
}
BaseQtVersion *QtVersionManager::version(int id) BaseQtVersion *QtVersionManager::version(int id)
{ {
QTC_ASSERT(isLoaded(), return nullptr); QTC_ASSERT(isLoaded(), return nullptr);
@@ -591,9 +585,4 @@ void QtVersionManager::setNewQtVersions(QList<BaseQtVersion *> newVersions)
emit m_instance->qtVersionsChanged(addedVersions, removedVersions, changedVersions); emit m_instance->qtVersionsChanged(addedVersions, removedVersions, changedVersions);
} }
BaseQtVersion *QtVersionManager::qtVersionForQMakeBinary(const FilePath &qmakePath)
{
return version(Utils::equal(&BaseQtVersion::qmakeCommand, qmakePath));
}
} // namespace QtVersion } // namespace QtVersion

4
src/plugins/qtsupport/qtversionmanager.h
View File

@@ -59,13 +59,9 @@ public:
// Sorting is potentially expensive since it might require qmake --query to run for each version! // Sorting is potentially expensive since it might require qmake --query to run for each version!
static QList<BaseQtVersion *> sortVersions(const QList<BaseQtVersion *> &input); static QList<BaseQtVersion *> sortVersions(const QList<BaseQtVersion *> &input);
static BaseQtVersion *qtVersionForQMakeBinary(const Utils::FilePath &qmakePath);
static void addVersion(BaseQtVersion *version); static void addVersion(BaseQtVersion *version);
static void removeVersion(BaseQtVersion *version); static void removeVersion(BaseQtVersion *version);
static bool isValidId(int id);
signals: signals:
// content of BaseQtVersion objects with qmake path might have changed // content of BaseQtVersion objects with qmake path might have changed
void qtVersionsChanged(const QList<int> &addedIds, const QList<int> &removedIds, const QList<int> &changedIds); void qtVersionsChanged(const QList<int> &addedIds, const QList<int> &removedIds, const QList<int> &changedIds);