From 11838105063387aa106f462dcec962a0a33c016f Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Fri, 3 Jul 2020 13:24:42 +0200 Subject: [PATCH] SDKtool: Do not add empty CMake configuration values Do not add the empty string as CMake configuration. People are apparently trying to use the empty string to make sure nothing is set up. Task-number: QTCREATORBUG-21696 Change-Id: I702e26bc135e30c36f770210f885a4680d4b0359 Reviewed-by: Tobias Hunger --- src/tools/sdktool/addkitoperation.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/tools/sdktool/addkitoperation.cpp b/src/tools/sdktool/addkitoperation.cpp index df5b297c978..8b6a3355c96 100644 --- a/src/tools/sdktool/addkitoperation.cpp +++ b/src/tools/sdktool/addkitoperation.cpp @@ -260,7 +260,8 @@ bool AddKitOperation::setArguments(const QStringList &args) if (next.isNull()) return false; ++i; - m_cmakeConfiguration.append(next); + if (!next.isEmpty()) + m_cmakeConfiguration.append(next); continue; }