feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Remove two uses of FilePath::toString

Browse Source 
The context here (passed as part of command lines args)  suggests
the use of .nativePath(), but if .toString() was ok so far, .path()
(i.e. with forward slashs also on Windows) would change less.

Change-Id: I045c4311c67b8875b87c328fbe57ca79ae0d7f1a
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2023-01-06 11:08:30 +01:00
parent 33e8251edf
commit 126d1d009e
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/utils/archive.cpp
View File

@@ -105,8 +105,8 @@ static std::optional<Tool> unzipTool(const FilePath &src, const FilePath &dest)
const std::optional<Tool> resolvedTool = resolveTool(tool); const std::optional<Tool> resolvedTool = resolveTool(tool);
if (resolvedTool) { if (resolvedTool) {
Tool result = *resolvedTool; Tool result = *resolvedTool;
const QString srcStr = src.toString(); const QString srcStr = src.path();
const QString destStr = dest.toString(); const QString destStr = dest.path();
const QString args = result.command.arguments().replace("%{src}", srcStr).replace("%{dest}", destStr); const QString args = result.command.arguments().replace("%{src}", srcStr).replace("%{dest}", destStr);
result.command.setArguments(args); result.command.setArguments(args);
return result; return result;