feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

C++: Clarify units of a Token

Browse Source 
This will avoid confusion when later more length and indices methods are
added.

In Token:
    length() --> bytes()
    begin() --> bytesBegin()
    end() --> bytesEnd()

Change-Id: I244c69b022e239ee762b4114559e707f93ff344f
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
This commit is contained in:
Nikolai Kosjar
2013-12-13 18:41:15 +01:00
parent ba76baa65f
commit 126e69137a
32 changed files with 272 additions and 247 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/cppeditor/cppfunctiondecldeflink.cpp
View File

@@ -414,17 +414,17 @@ static bool hasCommentedName(
// maybe in a comment but in the right spot?
int nameStart = 0;
if (param->declarator)
nameStart = unit->tokenAt(param->declarator->lastToken() - 1).end();
nameStart = unit->tokenAt(param->declarator->lastToken() - 1).bytesEnd();
else if (param->type_specifier_list)
nameStart = unit->tokenAt(param->type_specifier_list->lastToken() - 1).end();
nameStart = unit->tokenAt(param->type_specifier_list->lastToken() - 1).bytesEnd();
else
nameStart = unit->tokenAt(param->firstToken()).begin();
nameStart = unit->tokenAt(param->firstToken()).bytesBegin();
int nameEnd = 0;
if (param->equal_token)
nameEnd = unit->tokenAt(param->equal_token).begin();
nameEnd = unit->tokenAt(param->equal_token).bytesBegin();
else
nameEnd = unit->tokenAt(param->lastToken()).begin(); // one token after
nameEnd = unit->tokenAt(param->lastToken()).bytesBegin(); // one token after
QString text = source.mid(nameStart, nameEnd - nameStart);