From 12810caea15d94475bf6241476c7fa9e6bc50921 Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Fri, 11 Dec 2020 13:47:39 +0100
Subject: [PATCH] Don't repeat the same code

Change-Id: Ied1d816481bef760a49a4572e9fda1f6ac538daa
Reviewed-by: David Schulz <david.schulz@qt.io>
---
 src/plugins/texteditor/texteditor.cpp | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/src/plugins/texteditor/texteditor.cpp b/src/plugins/texteditor/texteditor.cpp
index d6d83296afd..05a1994c317 100644
--- a/src/plugins/texteditor/texteditor.cpp
+++ b/src/plugins/texteditor/texteditor.cpp
@@ -618,6 +618,7 @@ public:
     void updateSyntaxInfoBar(const Highlighter::Definitions &definitions, const QString &fileName);
     void configureGenericHighlighter(const KSyntaxHighlighting::Definition &definition);
     void rememberCurrentSyntaxDefinition();
+    void openLinkUnderCursor(bool openInNextSplit);
 
 public:
     TextEditorWidget *q;
@@ -1958,22 +1959,12 @@ void TextEditorWidget::redo()
 
 void TextEditorWidget::openLinkUnderCursor()
 {
-    const bool openInNextSplit = alwaysOpenLinksInNextSplit();
-    findLinkAt(textCursor(),
-               [openInNextSplit, self = QPointer<TextEditorWidget>(this)](const Link &symbolLink) {
-        if (self)
-            self->openLink(symbolLink, openInNextSplit);
-    }, true, openInNextSplit);
+    d->openLinkUnderCursor(alwaysOpenLinksInNextSplit());
 }
 
 void TextEditorWidget::openLinkUnderCursorInNextSplit()
 {
-    const bool openInNextSplit = !alwaysOpenLinksInNextSplit();
-    findLinkAt(textCursor(),
-               [openInNextSplit, self = QPointer<TextEditorWidget>(this)](const Link &symbolLink) {
-        if (self)
-            self->openLink(symbolLink, openInNextSplit);
-    }, true, openInNextSplit);
+    d->openLinkUnderCursor(!alwaysOpenLinksInNextSplit());
 }
 
 void TextEditorWidget::findUsages()
@@ -3247,6 +3238,16 @@ void TextEditorWidgetPrivate::rememberCurrentSyntaxDefinition()
         Highlighter::rememberDefinitionForDocument(definition, m_document.data());
 }
 
+void TextEditorWidgetPrivate::openLinkUnderCursor(bool openInNextSplit)
+{
+    q->findLinkAt(q->textCursor(),
+               [openInNextSplit, self = QPointer<TextEditorWidget>(q)](const Link &symbolLink) {
+        if (self)
+            self->openLink(symbolLink, openInNextSplit);
+    }, true, openInNextSplit);
+}
+
+
 bool TextEditorWidget::codeFoldingVisible() const
 {
     return d->m_codeFoldingVisible;