feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix potential crash

Browse Source 
There's no need to call beginXYZ() or endXYZ() on our own as this
is done by TreeModel.

Change-Id: I647f280a45c5f3ebb191a8e945c423eed22d677c
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
This commit is contained in:
Christian Stenger
2015-10-29 10:14:35 +01:00
parent 33d1a8c307
commit 128995b272
1 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
plugins/autotest/testtreemodel.cpp
View File

@@ -631,14 +631,10 @@ void TestTreeModel::processChildren(QModelIndex &parentIndex, const TestTreeItem
// handle data tags - just remove old and add them // handle data tags - just remove old and add them
if (modifiedChild->childCount() || toBeModifiedChild->childCount()) { if (modifiedChild->childCount() || toBeModifiedChild->childCount()) {
beginRemoveRows(child, 0, toBeModifiedChild->childCount());
toBeModifiedChild->removeChildren(); toBeModifiedChild->removeChildren();
endRemoveRows();
const int count = modifiedChild->childCount(); const int count = modifiedChild->childCount();
beginInsertRows(child, 0, count);
for (int childRow = 0; childRow < count; ++childRow) for (int childRow = 0; childRow < count; ++childRow)
toBeModifiedChild->appendChild(new TestTreeItem(*modifiedChild->childItem(childRow))); toBeModifiedChild->appendChild(new TestTreeItem(*modifiedChild->childItem(childRow)));
endInsertRows();
} }
if (checkStates.contains(toBeModifiedChild->name())) { if (checkStates.contains(toBeModifiedChild->name())) {