feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix warning: "Missing reference in range-for with non trivial type"

Browse Source 
[-Wclazy-range-loop]

Change-Id: I5dcb263c754d423740e7bce3dcb948d52f2dec67
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Alessandro Portale
2019-01-16 14:47:24 +01:00
parent 7f641d3c08
commit 128a33548b
14 changed files with 16 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/git/gerrit/gerritremotechooser.cpp
View File

@@ -124,7 +124,7 @@ bool GerritRemoteChooser::updateRemotes(bool forceReload)
void GerritRemoteChooser::addRemote(const GerritServer &server, const QString &name)
{
if (!m_allowDups) {
for (auto remote : m_remotes) {
for (const auto &remote : qAsConst(m_remotes)) {
if (remote.second == server)
return;
}

2
src/plugins/git/gitgrep.cpp
View File

@@ -134,7 +134,7 @@ public:
}
single.matchingLine = text;
for (auto match : qAsConst(matches)) {
for (const auto &match : qAsConst(matches)) {
single.matchStart = match.matchStart;
single.matchLength = match.matchLength;
single.regexpCapturedTexts = match.regexpCapturedTexts;