feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Only allow a very limited number of imports

Browse Source 
Only allow a very limited number of imports for QML lite designer.

Change-Id: I4f96252fe66be53aa5da26ef9d6cb4509e6ec6d9
Reviewed-by: Henning Gründl <henning.gruendl@qt.io>
This commit is contained in:
Thomas Hartmann
2024-07-10 16:10:22 +02:00
parent dd44168ad5
commit 12bbc785a6
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/qmldesigner/components/itemlibrary/itemlibraryaddimportmodel.cpp
View File

@@ -7,6 +7,8 @@
#include <designermcumanager.h> #include <designermcumanager.h>
#include <utils/algorithm.h> #include <utils/algorithm.h>
#include <qmldesignerbase/qmldesignerbaseplugin.h>
#include <QDebug> #include <QDebug>
#include <QVariant> #include <QVariant>
#include <QMetaProperty> #include <QMetaProperty>
@@ -73,6 +75,9 @@ void ItemLibraryAddImportModel::update(const Imports &possibleImports)
const DesignerMcuManager &mcuManager = DesignerMcuManager::instance(); const DesignerMcuManager &mcuManager = DesignerMcuManager::instance();
const bool isQtForMCUs = mcuManager.isMCUProject(); const bool isQtForMCUs = mcuManager.isMCUProject();
Imports filteredImports; Imports filteredImports;
const bool isLiteDesigner = QmlDesigner::QmlDesignerBasePlugin::isLiteModeEnabled();
if (isQtForMCUs) { if (isQtForMCUs) {
const QStringList mcuAllowedList = mcuManager.allowedImports(); const QStringList mcuAllowedList = mcuManager.allowedImports();
const QStringList mcuBannedList = mcuManager.bannedImports(); const QStringList mcuBannedList = mcuManager.bannedImports();
@@ -82,6 +87,11 @@ void ItemLibraryAddImportModel::update(const Imports &possibleImports)
|| !import.url().startsWith("Qt")) || !import.url().startsWith("Qt"))
&& !mcuBannedList.contains(import.url()); && !mcuBannedList.contains(import.url());
}); });
} else if (isLiteDesigner) {
const QStringList liteAllowedList = {"QtQuick", "QtQuick.Layouts", "QtQuick.Controls"};
filteredImports = Utils::filtered(possibleImports, [&](const Import &import) {
return (liteAllowedList.contains(import.url()) || !import.url().startsWith("Qt"));
});
} else { } else {
filteredImports = possibleImports; filteredImports = possibleImports;
} }