From 12bcc11389ff7946615ea306dd9a70c7eebbf8bc Mon Sep 17 00:00:00 2001 From: goro Date: Fri, 19 Dec 2008 16:39:02 +0100 Subject: [PATCH] PathChooser migration for external app debug lanuching --- src/libs/utils/pathchooser.cpp | 3 +- src/plugins/debugger/startexternaldialog.cpp | 16 ++--- src/plugins/debugger/startexternaldialog.h | 3 - src/plugins/debugger/startexternaldialog.ui | 74 ++++++++++---------- 4 files changed, 43 insertions(+), 53 deletions(-) diff --git a/src/libs/utils/pathchooser.cpp b/src/libs/utils/pathchooser.cpp index 26fa60294ec..b769ea75589 100644 --- a/src/libs/utils/pathchooser.cpp +++ b/src/libs/utils/pathchooser.cpp @@ -138,8 +138,7 @@ QString PathChooser::path() const void PathChooser::setPath(const QString &path) { - const QString defaultPath = path.isEmpty() ? homePath() : path; - m_d->m_lineEdit->setText(QDir::toNativeSeparators(defaultPath)); + m_d->m_lineEdit->setText(QDir::toNativeSeparators(path)); } void PathChooser::slotBrowse() diff --git a/src/plugins/debugger/startexternaldialog.cpp b/src/plugins/debugger/startexternaldialog.cpp index b8a5a59691f..ba88f5f74c2 100644 --- a/src/plugins/debugger/startexternaldialog.cpp +++ b/src/plugins/debugger/startexternaldialog.cpp @@ -42,6 +42,8 @@ StartExternalDialog::StartExternalDialog(QWidget *parent) : QDialog(parent) { setupUi(this); + execFile->setExpectedKind(Core::Utils::PathChooser::File); + execFile->setPromptDialogTitle(tr("Select Executable")); buttonBox->button(QDialogButtonBox::Ok)->setDefault(true); //execLabel->setHidden(false); @@ -53,14 +55,11 @@ StartExternalDialog::StartExternalDialog(QWidget *parent) connect(buttonBox, SIGNAL(accepted()), this, SLOT(accept())); connect(buttonBox, SIGNAL(rejected()), this, SLOT(reject())); - - connect(browseButton, SIGNAL(clicked()), - this, SLOT(onBrowseButton())); } void StartExternalDialog::setExecutableFile(const QString &str) { - execEdit->setText(str); + execFile->setPath(str); } void StartExternalDialog::setExecutableArguments(const QString &str) @@ -70,7 +69,7 @@ void StartExternalDialog::setExecutableArguments(const QString &str) QString StartExternalDialog::executableFile() const { - return execEdit->text(); + return execFile->path(); } QString StartExternalDialog::executableArguments() const @@ -116,10 +115,3 @@ QString StartExternalDialog::executableArguments() const return result; */ } - -void StartExternalDialog::onBrowseButton() -{ - QString fileName = QFileDialog::getOpenFileName(this, tr("Select Executable"), - execEdit->text()); - execEdit->setText(fileName); -} diff --git a/src/plugins/debugger/startexternaldialog.h b/src/plugins/debugger/startexternaldialog.h index 3cfe4c54206..0707252774d 100644 --- a/src/plugins/debugger/startexternaldialog.h +++ b/src/plugins/debugger/startexternaldialog.h @@ -53,9 +53,6 @@ public: QString executableFile() const; QString executableArguments() const; - -private slots: - void onBrowseButton(); }; } // namespace Debugger diff --git a/src/plugins/debugger/startexternaldialog.ui b/src/plugins/debugger/startexternaldialog.ui index 7888db2a3e6..1b93356584c 100644 --- a/src/plugins/debugger/startexternaldialog.ui +++ b/src/plugins/debugger/startexternaldialog.ui @@ -1,7 +1,8 @@ - + + StartExternalDialog - - + + 0 0 @@ -9,59 +10,52 @@ 127 - + Start Debugger - - + + 6 - + 9 - - + + 0 - + 6 - - - - - - - - - + + + Executable: - - - - ... - - - - - - + + + Arguments: + + + + + + - + Qt::Vertical - + 407 16 @@ -70,24 +64,32 @@ - - + + Qt::Horizontal - - + + Qt::Horizontal - + QDialogButtonBox::Cancel|QDialogButtonBox::Ok + + + Core::Utils::PathChooser + QWidget +
utils/pathchooser.h
+ 1 +
+