feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Introduced IFile::checkPermission() and use it to reduce the number of calls to isWritable().

Browse Source 
Done with: mae
This commit is contained in:
Roberto Raggi
2009-05-08 15:48:00 +02:00
parent cc3f796113
commit 12e27549b0
6 changed files with 32 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/plugins/texteditor/basetextdocument.cpp
View File

@@ -70,6 +70,7 @@ BaseTextDocument::BaseTextDocument()
{
m_documentMarker = new DocumentMarker(m_document);
m_lineTerminatorMode = NativeLineTerminator;
m_fileIsReadOnly = false;
m_isBinaryData = false;
m_codec = QTextCodec::codecForLocale();
m_hasDecodingError = false;
@@ -149,17 +150,8 @@ bool BaseTextDocument::isReadOnly() const
const QFileInfo fi(m_fileName);
#ifdef Q_OS_WIN
// Check for permissions on NTFS file systems
qt_ntfs_permission_lookup++;
#endif
return m_fileIsReadOnly;
const bool ro = !fi.isWritable();
#ifdef Q_OS_WIN
qt_ntfs_permission_lookup--;
#endif
return ro;
}
bool BaseTextDocument::isModified() const
@@ -167,11 +159,33 @@ bool BaseTextDocument::isModified() const
return m_document->isModified();
}
void BaseTextDocument::checkPermissions()
{
if (!m_fileName.isEmpty()) {
const QFileInfo fi(m_fileName);
#ifdef Q_OS_WIN
// Check for permissions on NTFS file systems
qt_ntfs_permission_lookup++;
#endif
m_fileIsReadOnly = !fi.isWritable();
#ifdef Q_OS_WIN
qt_ntfs_permission_lookup--;
#endif
} else {
m_fileIsReadOnly = false;
}
}
bool BaseTextDocument::open(const QString &fileName)
{
QString title = tr("untitled");
if (!fileName.isEmpty()) {
const QFileInfo fi(fileName);
m_fileIsReadOnly = !fi.isWritable();
m_fileName = fi.absoluteFilePath();
QFile file(fileName);