feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fossil: Make settings more directly accessible

Browse Source 
I am still not sure how the final pattern may ideally look like
but it looks like some kind of singleton access to a plugin's
settings helps with clarity.

Change-Id: I6a6a5f5b7cfdfb062f5b5231a79086f34e09487f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2023-05-15 10:55:16 +02:00
parent ef4fa870fc
commit 12f788179e
8 changed files with 43 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/plugins/fossil/fossilsettings.cpp
View File

@@ -101,9 +101,9 @@ FossilSettings::FossilSettings()
class OptionsPageWidget final : public Core::IOptionsPageWidget
{
public:
OptionsPageWidget(FossilSettings *settings)
OptionsPageWidget()
{
FossilSettings &s = *settings;
FossilSettings &s = settings();
using namespace Layouting;
@@ -141,16 +141,22 @@ public:
}.attachTo(this);
setOnApply([settings] { settings->apply(); });
setOnApply([] { settings().apply(); });
}
};
OptionsPage::OptionsPage(FossilSettings *settings)
OptionsPage::OptionsPage()
{
setId(Constants::VCS_ID_FOSSIL);
setDisplayName(Tr::tr("Fossil"));
setWidgetCreator([settings] { return new OptionsPageWidget(settings); });
setWidgetCreator([] { return new OptionsPageWidget; });
setCategory(VcsBase::Constants::VCS_SETTINGS_CATEGORY);
}
FossilSettings &settings()
{
static FossilSettings theSettings;
return theSettings;
}
} // Fossil::Internal