feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

RemoteLinux: Fix ports gatherer API.

Browse Source 
The ports gatherer used to take an SshConnection for historical reasons
(connection sharing in the absence of a connection manager). This is no
longer required, since all the information needed for creating or
re-using a connection is available from the device.
In addition, the old code assumes the connection is already established,
which some newer callers did not adhere to, so this patch also fixes a
bug.

Change-Id: I3fd7fec7de9b64126358749f727a403bfa1e0a94
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@nokia.com>
This commit is contained in:
Christian Kandeler
2012-04-03 10:23:59 +02:00
parent 23a420eb3f
commit 1348e92971
6 changed files with 62 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/remotelinux/startgdbserverdialog.cpp
View File

@@ -325,8 +325,7 @@ void StartGdbServerDialog::startGdbServer()
d->startServerOnly = true;
if (exec() == QDialog::Rejected)
return;
LinuxDeviceConfiguration::ConstPtr device = d->currentDevice();
d->gatherer.start(SshConnection::create(device->sshParameters()), device);
d->gatherer.start(d->currentDevice());
}
void StartGdbServerDialog::attachToRemoteProcess()
@@ -334,8 +333,7 @@ void StartGdbServerDialog::attachToRemoteProcess()
d->startServerOnly = false;
if (exec() == QDialog::Rejected)
return;
LinuxDeviceConfiguration::ConstPtr device = d->currentDevice();
d->gatherer.start(SshConnection::create(device->sshParameters()), device);
d->gatherer.start(d->currentDevice());
}
void StartGdbServerDialog::handleConnectionError()