feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Spare unneeded lookups

Browse Source 
When deleting text marks from the cache we can safely
assume that each mark is unique.
This significantly reduces the time of cleaning up the
marks cache when having lots of marks which may happen
e.g. for Axivion analyses.

Change-Id: I185cf0696cc603afb773d50fdfbaee84df9b2e20
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2024-10-01 15:40:53 +02:00
parent b1a9eeaea5
commit 137538a994
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/texteditor/textdocument.cpp
View File

@@ -1034,7 +1034,7 @@ void TextDocument::removeMarkFromMarksCache(TextMark *mark)
{ {
auto documentLayout = qobject_cast<TextDocumentLayout*>(d->m_document.documentLayout()); auto documentLayout = qobject_cast<TextDocumentLayout*>(d->m_document.documentLayout());
QTC_ASSERT(documentLayout, return); QTC_ASSERT(documentLayout, return);
d->m_marksCache.removeAll(mark); d->m_marksCache.removeOne(mark);
auto scheduleLayoutUpdate = [documentLayout](){ auto scheduleLayoutUpdate = [documentLayout](){
// make sure all destructors that may directly or indirectly call this function are // make sure all destructors that may directly or indirectly call this function are