feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Fix clang warning

Browse Source 
src/plugins/qmldesigner/components/curveeditor/detail/selectionmodel.h:
62: warning: 'DesignTools::SelectionModel::select' hides overloaded
virtual function [-Woverloaded-virtual]
    void select(const std::vector<TreeItem::Path> &selection);
         ^

Change-Id: I68266a4281dca62c1c07940a981cfd1aff870ec8
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Christian Kandeler
2020-04-23 13:40:59 +02:00
parent 0655ddbd65
commit 137c0ca673
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmldesigner/components/curveeditor/curveeditormodel.cpp
View File

@@ -111,7 +111,7 @@ void CurveEditorModel::reset(const std::vector<TreeItem *> &items)
graphicsView()->reset(pinned); graphicsView()->reset(pinned);
if (SelectionModel *sm = selectionModel()) if (SelectionModel *sm = selectionModel())
sm->select(sel); sm->selectPaths(sel);
} }
} // End namespace DesignTools. } // End namespace DesignTools.

2
src/plugins/qmldesigner/components/curveeditor/detail/selectionmodel.cpp
View File

@@ -98,7 +98,7 @@ std::vector<PropertyTreeItem *> SelectionModel::selectedPropertyItems() const
return items; return items;
} }
void SelectionModel::select(const std::vector<TreeItem::Path> &selection) void SelectionModel::selectPaths(const std::vector<TreeItem::Path> &selection)
{ {
for (auto &&path : selection) { for (auto &&path : selection) {
if (auto *treeModel = qobject_cast<TreeModel *>(model())) { if (auto *treeModel = qobject_cast<TreeModel *>(model())) {

2
src/plugins/qmldesigner/components/curveeditor/detail/selectionmodel.h
View File

@@ -59,7 +59,7 @@ public:
std::vector<PropertyTreeItem *> selectedPropertyItems() const; std::vector<PropertyTreeItem *> selectedPropertyItems() const;
void select(const std::vector<TreeItem::Path> &selection); void selectPaths(const std::vector<TreeItem::Path> &selection);
private: private:
void changeSelection(const QItemSelection &selected, const QItemSelection &deselected); void changeSelection(const QItemSelection &selected, const QItemSelection &deselected);