forked from qt-creator/qt-creator
QtSupport: Replace BaseQtVersion::clone()
... by a mechanism that doesn't require re-implementation in each derived class. A QtVersion's type() is uniquely defined by the supported type of the factory creating it, so that factory can be found and used for cloning. Non-base data is copied by a fromMap(toMap()) dance as done in the project configurations. As a side-effect, the *QtVersion copy constructors are not used and not needed anymore. Change-Id: I3aa5a0fd90a27dd115769e0573647cb5669641a0 Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
@@ -42,16 +42,6 @@ using namespace ProjectExplorer;
|
||||
|
||||
IosQtVersion::IosQtVersion() = default;
|
||||
|
||||
IosQtVersion *IosQtVersion::clone() const
|
||||
{
|
||||
return new IosQtVersion(*this);
|
||||
}
|
||||
|
||||
QString IosQtVersion::type() const
|
||||
{
|
||||
return QLatin1String(Constants::IOSQT);
|
||||
}
|
||||
|
||||
bool IosQtVersion::isValid() const
|
||||
{
|
||||
if (!BaseQtVersion::isValid())
|
||||
|
||||
@@ -40,8 +40,6 @@ class IosQtVersion : public QtSupport::BaseQtVersion
|
||||
public:
|
||||
IosQtVersion();
|
||||
|
||||
IosQtVersion *clone() const override;
|
||||
QString type() const override;
|
||||
bool isValid() const override;
|
||||
QString invalidReason() const override;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user