From 13a93a6b576897db037601787bb65f08268e302a Mon Sep 17 00:00:00 2001 From: Amr Essam Date: Mon, 6 Feb 2023 18:14:57 +0200 Subject: [PATCH] QmlDesigner: Enable effect animation by default Also included some enhancements to ModelNodeOperations Task-number: QTBUG-110486 Change-Id: Ibaeef035121fff070119100560efcdab03e1a273 Reviewed-by: Mahmoud Badri --- .../components/componentcore/modelnodeoperations.cpp | 3 +-- src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp b/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp index 93696919fd4..3ca731a6395 100644 --- a/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp +++ b/src/plugins/qmldesigner/components/componentcore/modelnodeoperations.cpp @@ -1670,11 +1670,10 @@ void openEffectMaker(const QString &filePath) Utils::QtcProcess *qqemProcess = new Utils::QtcProcess(); qqemProcess->setEnvironment(env); qqemProcess->setCommand({ effectMakerPath, arguments }); - qqemProcess->start(); - QObject::connect(qqemProcess, &Utils::QtcProcess::done, [qqemProcess]() { qqemProcess->deleteLater(); }); + qqemProcess->start(); } } diff --git a/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp b/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp index 4570e5fc432..266bb5528aa 100644 --- a/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp +++ b/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp @@ -214,6 +214,9 @@ void QmlItemNode::placeEffectNode(NodeAbstractProperty &parentProperty, const Qm } else { parentProperty.parentModelNode().variantProperty("layer.enabled").setValue(true); } + + if (effectNode.modelNode().metaInfo().hasProperty("timeRunning")) + effectNode.modelNode().variantProperty("timeRunning").setValue(true); } bool QmlItemNode::isValid() const