feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Restrict selection ranges to a minimum of 500ns

Browse Source 
Smaller ranges shouldn't be useful for anything but create rounding
errors all over the place.

Task-number: QTCREATORBUG-10880
Change-Id: I5cf5e2c08b5cae676717ba8ada1cddee4523c399
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
This commit is contained in:
Ulf Hermann
2013-11-21 19:08:19 +01:00
parent 5a268789ef
commit 13abd6d65d
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qmlprofiler/qml/Overview.qml
View File

@@ -51,7 +51,7 @@ Canvas2D {
function updateRange() { function updateRange() {
var newStartTime = Math.round(rangeMover.getLeft() * qmlProfilerModelProxy.traceDuration() / width) + qmlProfilerModelProxy.traceStartTime(); var newStartTime = Math.round(rangeMover.getLeft() * qmlProfilerModelProxy.traceDuration() / width) + qmlProfilerModelProxy.traceStartTime();
var newEndTime = Math.round(rangeMover.getRight() * qmlProfilerModelProxy.traceDuration() / width) + qmlProfilerModelProxy.traceStartTime(); var newEndTime = Math.round(rangeMover.getRight() * qmlProfilerModelProxy.traceDuration() / width) + qmlProfilerModelProxy.traceStartTime();
if (startTime !== newStartTime || endTime !== newEndTime) { if ((startTime !== newStartTime || endTime !== newEndTime) && newEndTime - newStartTime > 500) {
zoomControl.setRange(newStartTime, newEndTime); zoomControl.setRange(newStartTime, newEndTime);
} }
} }

2
src/plugins/qmlprofiler/qml/SelectionRange.qml
View File

@@ -39,7 +39,7 @@ RangeMover {
property string durationString: detailedPrintTime(duration) property string durationString: detailedPrintTime(duration)
property real startTime: getLeft() * viewTimePerPixel + qmlProfilerModelProxy.traceStartTime() property real startTime: getLeft() * viewTimePerPixel + qmlProfilerModelProxy.traceStartTime()
property real duration: getWidth() * viewTimePerPixel property real duration: Math.max(getWidth() * viewTimePerPixel, 500)
property real viewTimePerPixel: 1 property real viewTimePerPixel: 1
property int creationState : 0 property int creationState : 0