feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Add semantic C++ operator-token styling

Browse Source 
We used to style overloaded operators in the same way
as C++'s built-in operators. There was no way to tell
if a + token would call a operator+() function or not.

Now, if an operator is overloaded (redefined),
we give it the "Overloaded Operator"-mixin so users
can style it differently.

Note: Calls to overloaded 'new' and 'delete' are not
highlighted by "Overloaded Operator". This is because
clang today always maps these to CXCursor_CXXNewExpr
and CXCursor_CXXDeleteExpr with cursor.spelling == ""
(empty string). So there is no (?) quick way for us
to tell if a new/delete-token was overloaded or not.

After follow-ups, follow symbol will work for operator
overload usages in current translation unit.
Commit is appended by Ivan Donchevskii.

Task-number: QTCREATORBUG-19659
Change-Id: I157855d482a61ad2059642a1ee982089fcb7d312
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
This commit is contained in:
Hugo Holgersson
2016-11-05 15:29:10 +01:00
parent bb6eae5c3b
commit 142ae0cdf9
15 changed files with 519 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
tests/unit/unittest/clangstring-test.cpp
View File

@@ -105,9 +105,9 @@ TEST(ClangString, NotEqualBetweenClangStrings)
ClangString text(CXString{"text", 0});
ClangString text2(CXString{"text ", 0});
bool textIsEqual = text == text2;
bool textIsNotEqual = text != text2;
ASSERT_FALSE(textIsEqual);
ASSERT_TRUE(textIsNotEqual);
}
TEST(ClangString, EqualClangStringAndCString)
@@ -123,9 +123,9 @@ TEST(ClangString, NotEqualClangStringAndCString)
{
ClangString text(CXString{"text", 0});
bool textIsEqual = text == "text ";
bool textIsNotEqual = text != "text ";
ASSERT_FALSE(textIsEqual);
ASSERT_TRUE(textIsNotEqual);
}
TEST(ClangString, EqualCStringAndClangString)
@@ -137,6 +137,15 @@ TEST(ClangString, EqualCStringAndClangString)
ASSERT_TRUE(textIsEqual);
}
TEST(ClangString, NotEqualCStringAndClangString)
{
ClangString text(CXString{"text", 0});
bool textIsNotEqual = "text " != text;
ASSERT_TRUE(textIsNotEqual);
}
TEST(ClangString, EqualClangStringPointerAndCString)
{
ClangString text(CXString{"text", 0});
@@ -152,9 +161,9 @@ TEST(ClangString, NotEqualClangStringPointerAndCString)
ClangString text(CXString{"text", 0});
const char *cString = "text ";
bool textIsEqual = cString == text;
bool textIsNotEqual = cString != text;
ASSERT_FALSE(textIsEqual);
ASSERT_TRUE(textIsNotEqual);
}
TEST(ClangString, EqualCStringAndClangStringPointer)
@@ -167,6 +176,16 @@ TEST(ClangString, EqualCStringAndClangStringPointer)
ASSERT_TRUE(textIsEqual);
}
TEST(ClangString, NotEqualCStringAndClangStringPointer)
{
ClangString text(CXString{"text", 0});
const char *cString = "text ";
bool textIsNotEqual = text != cString;
ASSERT_TRUE(textIsNotEqual);
}
TEST(ClangString, NullStringHasNoContent)
{
ClangString text(CXString{nullptr, 0});