feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Cvs: Use AsynchronousMessageBox

Browse Source 
Event loops can lead to crashes so it is better to use a dialog which has
not it's own event loop.

Change-Id: Iaa97b7696c693b064ac4fa2f00d57a09e7e3c303
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@theqtcompany.com>
This commit is contained in:
Marco Bubke
2014-11-25 12:40:29 +01:00
committed by Tobias Hunger
parent 9fd5c44f4b
commit 143e23f4d1
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/cvs/cvsplugin.cpp
View File

@@ -50,6 +50,7 @@
#include <coreplugin/icore.h> #include <coreplugin/icore.h>
#include <coreplugin/coreconstants.h> #include <coreplugin/coreconstants.h>
#include <coreplugin/documentmanager.h> #include <coreplugin/documentmanager.h>
#include <coreplugin/messagebox.h>
#include <coreplugin/messagemanager.h> #include <coreplugin/messagemanager.h>
#include <coreplugin/mimedatabase.h> #include <coreplugin/mimedatabase.h>
#include <coreplugin/actionmanager/actionmanager.h> #include <coreplugin/actionmanager/actionmanager.h>
@@ -617,8 +618,8 @@ void CvsPlugin::revertAll()
if (revertResponse.result == CvsResponse::Ok) if (revertResponse.result == CvsResponse::Ok)
cvsVersionControl()->emitRepositoryChanged(state.topLevel()); cvsVersionControl()->emitRepositoryChanged(state.topLevel());
else else
QMessageBox::warning(ICore::dialogParent(), title, Core::AsynchronousMessageBox::warning(title,
tr("Revert failed: %1").arg(revertResponse.message), QMessageBox::Ok); tr("Revert failed: %1").arg(revertResponse.message));
} }
void CvsPlugin::revertCurrentFile() void CvsPlugin::revertCurrentFile()