feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Use FilePath operations to create error flags

Browse Source 
Otherwise remote setups generate unrelated errors.

Change-Id: I11285048b1ac0424c45bed5b61779af6724a7a0f
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
hjk
2021-08-05 10:56:43 +02:00
parent ec013afe00
commit 1490aeb0e0
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/cmakeprojectmanager/cmakesettingspage.cpp
View File

@@ -136,10 +136,10 @@ public:
void updateErrorFlags() void updateErrorFlags()
{ {
const QFileInfo fi = CMakeTool::cmakeExecutable(m_executable).toFileInfo(); const FilePath filePath = CMakeTool::cmakeExecutable(m_executable);
m_pathExists = fi.exists(); m_pathExists = filePath.exists();
m_pathIsFile = fi.isFile(); m_pathIsFile = filePath.isFile();
m_pathIsExecutable = fi.isExecutable(); m_pathIsExecutable = filePath.isExecutableFile();
CMakeTool cmake(m_autodetected ? CMakeTool::AutoDetection CMakeTool cmake(m_autodetected ? CMakeTool::AutoDetection
: CMakeTool::ManualDetection, m_id); : CMakeTool::ManualDetection, m_id);