feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

GDB: Support operate by instruction also for core dump

Browse Source 
+ Deduplicate common capabilities.

Task-number: QTCREATORBUG-21454
Change-Id: Icd53b88274136c885b929030f1cfb71819667cc3
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Orgad Shaneh
2018-11-18 20:12:40 +02:00
committed by Orgad Shaneh
parent bd539f7f77
commit 14bdcd2bff
1 changed files with 17 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -1769,25 +1769,25 @@ static QString msgNoGdbBinaryForToolChain(const Abi &tc)
bool GdbEngine::hasCapability(unsigned cap) const
{
if (runParameters().startMode == AttachCore) {
return cap & (AutoDerefPointersCapability
| DisassemblerCapability
| RegisterCapability
| ShowMemoryCapability
| CreateFullBacktraceCapability
| AddWatcherCapability
| ShowModuleSymbolsCapability
| ShowModuleSectionsCapability
| WatchComplexExpressionsCapability
| MemoryAddressCapability
| AdditionalQmlStackCapability);
if (cap & (AutoDerefPointersCapability
| DisassemblerCapability
| RegisterCapability
| ShowMemoryCapability
| CreateFullBacktraceCapability
| AddWatcherCapability
| ShowModuleSymbolsCapability
| ShowModuleSectionsCapability
| OperateByInstructionCapability
| WatchComplexExpressionsCapability
| MemoryAddressCapability
| AdditionalQmlStackCapability)) {
return true;
}
return cap & (AutoDerefPointersCapability
| DisassemblerCapability
| RegisterCapability
| ShowMemoryCapability
| JumpToLineCapability
if (runParameters().startMode == AttachCore)
return false;
return cap & (JumpToLineCapability
| ReloadModuleCapability
| ReloadModuleSymbolsCapability
| BreakOnThrowAndCatchCapability
@@ -1795,18 +1795,12 @@ bool GdbEngine::hasCapability(unsigned cap) const
| BreakIndividualLocationsCapability
| TracePointCapability
| ReturnFromFunctionCapability
| CreateFullBacktraceCapability
| WatchpointByAddressCapability
| WatchpointByExpressionCapability
| AddWatcherCapability
| AddWatcherWhileRunningCapability
| WatchWidgetsCapability
| ShowModuleSymbolsCapability
| ShowModuleSectionsCapability
| CatchCapability
| OperateByInstructionCapability
| RunToLineCapability
| WatchComplexExpressionsCapability
| MemoryAddressCapability
| AdditionalQmlStackCapability
| NativeMixedCapability