From 14ff95b1bfdd74022808a88d7c03ab12da024868 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Thu, 1 Feb 2024 11:33:42 +0100 Subject: [PATCH] Utils: Replace the last QSharedPointer usage with std::shared_ptr Replace it in Pty::Data. Remove the usage of shared pointer from PathListPlainTextEdit. According to https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews QSharedPointer impl is poor and it's going to be removed from Qt 7. Change-Id: I5f19edf438eed3dde17b0f9abf570d2b53df93d7 Reviewed-by: hjk --- src/libs/utils/pathlisteditor.cpp | 5 ++--- src/libs/utils/processinterface.h | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/libs/utils/pathlisteditor.cpp b/src/libs/utils/pathlisteditor.cpp index 383ca88b030..5964027dc6c 100644 --- a/src/libs/utils/pathlisteditor.cpp +++ b/src/libs/utils/pathlisteditor.cpp @@ -10,7 +10,6 @@ #include #include #include -#include #include #include @@ -64,9 +63,9 @@ void PathListPlainTextEdit::insertFromMimeData(const QMimeData *source) // replace separator QString text = source->text().trimmed(); text.replace(HostOsInfo::pathListSeparator(), QLatin1Char('\n')); - QSharedPointer fixed(new QMimeData); + QMimeData *fixed = new QMimeData; fixed->setText(text); - QPlainTextEdit::insertFromMimeData(fixed.data()); + QPlainTextEdit::insertFromMimeData(fixed); } else { QPlainTextEdit::insertFromMimeData(source); } diff --git a/src/libs/utils/processinterface.h b/src/libs/utils/processinterface.h index 41f68e811d8..1e233b88abf 100644 --- a/src/libs/utils/processinterface.h +++ b/src/libs/utils/processinterface.h @@ -55,7 +55,7 @@ public: private: QSize m_size{80, 60}; - QSharedPointer m_data; + std::shared_ptr m_data; }; } // namespace Pty