From 156282a97f10aa76df4e9bc5d9020a8c2ed080b3 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Tue, 8 Nov 2016 11:56:53 +0100 Subject: [PATCH] CMake: Use QT_INSTALL_PREFIX for CMAKE_PREFIX_PATH QQT_INSTALL_LIBS does not work as intended. That was not obvious since Qt Creatod adapts the PATH, which had a similar effect, but breaks when trying to build the project outside Qt Creator. Change-Id: I36c7caf69a157ae0d4e3dc500265042fd5964681 Reviewed-by: Florian Apolloner Reviewed-by: Tim Jenssen --- src/plugins/cmakeprojectmanager/cmakekitinformation.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/cmakeprojectmanager/cmakekitinformation.cpp b/src/plugins/cmakeprojectmanager/cmakekitinformation.cpp index d4bf985b8ed..7375c7feb2a 100644 --- a/src/plugins/cmakeprojectmanager/cmakekitinformation.cpp +++ b/src/plugins/cmakeprojectmanager/cmakekitinformation.cpp @@ -507,7 +507,7 @@ CMakeConfig CMakeConfigurationKitInformation::defaultConfiguration(const Kit *k) // Qt4: config << CMakeConfigItem(CMAKE_QMAKE_KEY, "%{Qt:qmakeExecutable}"); // Qt5: - config << CMakeConfigItem(CMAKE_PREFIX_PATH_KEY, "%{Qt:QT_INSTALL_LIBS}"); + config << CMakeConfigItem(CMAKE_PREFIX_PATH_KEY, "%{Qt:QT_INSTALL_PREFIX}"); config << CMakeConfigItem(CMAKE_C_TOOLCHAIN_KEY, "%{Compiler:Executable:C}"); config << CMakeConfigItem(CMAKE_CXX_TOOLCHAIN_KEY, "%{Compiler:Executable:Cxx}"); @@ -535,7 +535,7 @@ QList CMakeConfigurationKitInformation::validate(const Kit *k) const const bool isQt4 = version && version->qtVersion() < QtSupport::QtVersionNumber(5, 0, 0); Utils::FileName qmakePath; - QStringList qtLibDirs; + QStringList qtInstallDirs; Utils::FileName tcCPath; Utils::FileName tcCxxPath; foreach (const CMakeConfigItem &i, config) { @@ -549,7 +549,7 @@ QList CMakeConfigurationKitInformation::validate(const Kit *k) const else if (i.key == CMAKE_CXX_TOOLCHAIN_KEY) tcCxxPath = expandedValue; else if (i.key == CMAKE_PREFIX_PATH_KEY) - qtLibDirs = CMakeConfigItem::cmakeSplitValue(expandedValue.toString()); + qtInstallDirs = CMakeConfigItem::cmakeSplitValue(expandedValue.toString()); } QList result; @@ -572,7 +572,7 @@ QList CMakeConfigurationKitInformation::validate(const Kit *k) const Utils::FileName(), -1, Core::Id(Constants::TASK_CATEGORY_BUILDSYSTEM)); } } - if (version && !qtLibDirs.contains(version->qmakeProperty("QT_INSTALL_LIBS")) && !isQt4) { + if (version && !qtInstallDirs.contains(version->qmakeProperty("QT_INSTALL_PREFIX")) && !isQt4) { if (version->isValid()) { result << Task(Task::Warning, tr("CMake configuration has no CMAKE_PREFIX_PATH set " "that points to the kit Qt version."),