feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Tighten Perspective interface

Browse Source 
Pass id in constructor, so it can be const.

Change-Id: Id33fe19c4416109af8aa05a3ed0a09918eeb5cdf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2018-08-13 09:34:47 +02:00
parent 1d68e08359
commit 1567679b81
8 changed files with 49 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/debugger/debuggermainwindow.cpp
View File

@@ -102,10 +102,9 @@ DebuggerMainWindow::~DebuggerMainWindow()
delete perspective;
}
void DebuggerMainWindow::registerPerspective(const QByteArray &perspectiveId, Perspective *perspective)
void DebuggerMainWindow::registerPerspective(Perspective *perspective)
{
m_perspectives.append(perspective);
perspective->m_id = perspectiveId;
QByteArray parentPerspective = perspective->parentPerspective();
// Add "main" perspectives to the chooser.
if (parentPerspective.isEmpty()) {
@@ -481,6 +480,13 @@ void DebuggerMainWindow::savePerspectiveHelper(const Perspective *perspective)
settings->setValue(QLatin1String(LAST_PERSPECTIVE_KEY), perspective->m_id);
}
// Perspective
Perspective::Perspective(const QByteArray &id, const QString &name)
: m_id(id), m_name(name)
{
}
Perspective::~Perspective()
{
for (const ToolbarOperation &op : m_toolbarOperations) {
@@ -501,11 +507,6 @@ QString Perspective::name() const
return m_name;
}
void Perspective::setName(const QString &name)
{
m_name = name;
}
void Perspective::setAboutToActivateCallback(const Perspective::Callback &cb)
{
m_aboutToActivateCallback = cb;
@@ -563,11 +564,6 @@ QWidget *Perspective::centralWidget() const
return m_centralWidget;
}
Perspective::Perspective(const QString &name)
: m_name(name)
{
}
void Perspective::addWindow(QWidget *widget, OperationType type, QWidget *anchorWidget,
bool visibleByDefault, Qt::DockWidgetArea area)
{