feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Tighten Perspective interface

Browse Source 
Pass id in constructor, so it can be const.

Change-Id: Id33fe19c4416109af8aa05a3ed0a09918eeb5cdf
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2018-08-13 09:34:47 +02:00
parent 1d68e08359
commit 1567679b81
8 changed files with 49 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/debugger/debuggermainwindow.h
View File

@@ -51,8 +51,7 @@ class DEBUGGER_EXPORT Perspective
public:
enum OperationType { SplitVertical, SplitHorizontal, AddToTab, Raise };
Perspective() = default;
explicit Perspective(const QString &name);
explicit Perspective(const QByteArray &id, const QString &name);
~Perspective();
void setCentralWidget(QWidget *centralWidget);
@@ -69,7 +68,6 @@ public:
QWidget *centralWidget() const;
QString name() const;
void setName(const QString &name);
using Callback = std::function<void()>;
void setAboutToActivateCallback(const Callback &cb);
@@ -104,7 +102,7 @@ private:
QIcon icon;
};
QByteArray m_id;
const QByteArray m_id;
QString m_name;
QByteArray m_parentPerspective;
QVector<Operation> m_operations;
@@ -121,7 +119,7 @@ public:
DebuggerMainWindow();
~DebuggerMainWindow() override;
void registerPerspective(const QByteArray &perspectiveId, Perspective *perspective);
void registerPerspective(Perspective *perspective);
void destroyDynamicPerspective(Perspective *perspective);
void resetCurrentPerspective();