feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakePM: Allow http(s) Url navigation

Browse Source 
The CMake snippets do have comments with the origin of the snippet and
this patchset allows navigation to the url in question.

Change-Id: I6eb2565e8f7b9100a1cc19dbf8ccda430c698613
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Cristian Adam
2023-09-29 18:07:51 +02:00
parent ba1e54b8a4
commit 15903ad17a
1 changed files with 47 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

56
src/plugins/cmakeprojectmanager/cmakeeditor.cpp
View File

@@ -145,6 +145,14 @@ static QString unescape(const QString &s)
return result; return result;
} }
static bool isValidUrlChar(const QChar &c)
{
static QSet<QChar> urlChars{'-', '.', '_', '~', ':', '/', '?', '#', '[', ']', '@', '!',
'$', '&', '\'', '(', ')', '*', '+', ',', ';', '%', '='};
return (c.isLetterOrNumber() || urlChars.contains(c)) && !c.isSpace();
}
QHash<QString, Utils::Link> getLocalSymbolsHash(const QByteArray &content, const Utils::FilePath &filePath) QHash<QString, Utils::Link> getLocalSymbolsHash(const QByteArray &content, const Utils::FilePath &filePath)
{ {
cmListFile cmakeListFile; cmListFile cmakeListFile;
@@ -187,14 +195,50 @@ void CMakeEditorWidget::findLinkAt(const QTextCursor &cursor,
const QString block = cursor.block().text(); const QString block = cursor.block().text();
int beginPos = 0;
int endPos = 0;
auto addTextStartEndToLink = [&](Utils::Link &link) {
link.linkTextStart = cursor.position() - column + beginPos + 1;
link.linkTextEnd = cursor.position() - column + endPos;
return link;
};
// check if the current position is commented out // check if the current position is commented out
const qsizetype hashPos = block.indexOf(QLatin1Char('#')); const qsizetype hashPos = block.indexOf(QLatin1Char('#'));
if (hashPos >= 0 && hashPos < column) if (hashPos >= 0 && hashPos < column) {
// Check to see if we have a https:// link
QString buffer;
beginPos = column - 1;
while (beginPos > hashPos) {
if (isValidUrlChar(block[beginPos])) {
buffer.prepend(block.at(beginPos));
beginPos--;
} else {
break;
}
}
// find the end of the url
endPos = column;
while (endPos < block.size()) {
if (isValidUrlChar(block[endPos])) {
buffer.append(block.at(endPos));
endPos++;
} else {
break;
}
}
if (buffer.startsWith("http")) {
link.targetFilePath = FilePath::fromPathPart(buffer);
addTextStartEndToLink(link);
return processLinkCallback(link); return processLinkCallback(link);
}
return processLinkCallback(link);
}
// find the beginning of a filename // find the beginning of a filename
QString buffer; QString buffer;
int beginPos = column - 1; beginPos = column - 1;
while (beginPos >= 0) { while (beginPos >= 0) {
if (isValidFileNameChar(block, beginPos)) { if (isValidFileNameChar(block, beginPos)) {
buffer.prepend(block.at(beginPos)); buffer.prepend(block.at(beginPos));
@@ -205,7 +249,7 @@ void CMakeEditorWidget::findLinkAt(const QTextCursor &cursor,
} }
// find the end of a filename // find the end of a filename
int endPos = column; endPos = column;
while (endPos < block.size()) { while (endPos < block.size()) {
if (isValidFileNameChar(block, endPos)) { if (isValidFileNameChar(block, endPos)) {
buffer.append(block.at(endPos)); buffer.append(block.at(endPos));
@@ -222,12 +266,6 @@ void CMakeEditorWidget::findLinkAt(const QTextCursor &cursor,
buffer.replace("${CMAKE_CURRENT_SOURCE_DIR}", dir.path()); buffer.replace("${CMAKE_CURRENT_SOURCE_DIR}", dir.path());
buffer.replace("${CMAKE_CURRENT_LIST_DIR}", dir.path()); buffer.replace("${CMAKE_CURRENT_LIST_DIR}", dir.path());
auto addTextStartEndToLink = [&](Utils::Link &link) {
link.linkTextStart = cursor.position() - column + beginPos + 1;
link.linkTextEnd = cursor.position() - column + endPos;
return link;
};
if (auto project = ProjectTree::currentProject()) { if (auto project = ProjectTree::currentProject()) {
buffer.replace("${CMAKE_SOURCE_DIR}", project->projectDirectory().path()); buffer.replace("${CMAKE_SOURCE_DIR}", project->projectDirectory().path());
if (auto bs = ProjectTree::currentBuildSystem()) { if (auto bs = ProjectTree::currentBuildSystem()) {