ProjectExplorer: Use Qt5-style connects

The heavy lifting was done by clazy.

Change-Id: I619db09a79760186b72e7662490ed1205155c1a7
Reviewed-by: Tobias Hunger <tobias.hunger@theqtcompany.com>
This commit is contained in:
Orgad Shaneh
2016-01-29 16:38:37 +02:00
committed by Orgad Shaneh
parent db8b9f9463
commit 15f8bb07ed
137 changed files with 901 additions and 919 deletions

View File

@@ -80,14 +80,16 @@ AbiWidget::AbiWidget(QWidget *parent) :
d->m_abi->setSizeAdjustPolicy(QComboBox::AdjustToMinimumContentsLengthWithIcon); d->m_abi->setSizeAdjustPolicy(QComboBox::AdjustToMinimumContentsLengthWithIcon);
d->m_abi->setMinimumContentsLength(4); d->m_abi->setMinimumContentsLength(4);
layout->addWidget(d->m_abi); layout->addWidget(d->m_abi);
connect(d->m_abi, SIGNAL(currentIndexChanged(int)), this, SLOT(modeChanged())); connect(d->m_abi, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
this, &AbiWidget::modeChanged);
d->m_architectureComboBox = new QComboBox(this); d->m_architectureComboBox = new QComboBox(this);
layout->addWidget(d->m_architectureComboBox); layout->addWidget(d->m_architectureComboBox);
for (int i = 0; i <= static_cast<int>(Abi::UnknownArchitecture); ++i) for (int i = 0; i <= static_cast<int>(Abi::UnknownArchitecture); ++i)
d->m_architectureComboBox->addItem(Abi::toString(static_cast<Abi::Architecture>(i)), i); d->m_architectureComboBox->addItem(Abi::toString(static_cast<Abi::Architecture>(i)), i);
d->m_architectureComboBox->setCurrentIndex(static_cast<int>(Abi::UnknownArchitecture)); d->m_architectureComboBox->setCurrentIndex(static_cast<int>(Abi::UnknownArchitecture));
connect(d->m_architectureComboBox, SIGNAL(currentIndexChanged(int)), this, SLOT(customAbiChanged())); connect(d->m_architectureComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
this, &AbiWidget::customAbiChanged);
QLabel *separator1 = new QLabel(this); QLabel *separator1 = new QLabel(this);
separator1->setText(QLatin1String("-")); separator1->setText(QLatin1String("-"));
@@ -99,7 +101,8 @@ AbiWidget::AbiWidget(QWidget *parent) :
for (int i = 0; i <= static_cast<int>(Abi::UnknownOS); ++i) for (int i = 0; i <= static_cast<int>(Abi::UnknownOS); ++i)
d->m_osComboBox->addItem(Abi::toString(static_cast<Abi::OS>(i)), i); d->m_osComboBox->addItem(Abi::toString(static_cast<Abi::OS>(i)), i);
d->m_osComboBox->setCurrentIndex(static_cast<int>(Abi::UnknownOS)); d->m_osComboBox->setCurrentIndex(static_cast<int>(Abi::UnknownOS));
connect(d->m_osComboBox, SIGNAL(currentIndexChanged(int)), this, SLOT(osChanged())); connect(d->m_osComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
this, &AbiWidget::osChanged);
QLabel *separator2 = new QLabel(this); QLabel *separator2 = new QLabel(this);
separator2->setText(QLatin1String("-")); separator2->setText(QLatin1String("-"));
@@ -108,7 +111,8 @@ AbiWidget::AbiWidget(QWidget *parent) :
d->m_osFlavorComboBox = new QComboBox(this); d->m_osFlavorComboBox = new QComboBox(this);
layout->addWidget(d->m_osFlavorComboBox); layout->addWidget(d->m_osFlavorComboBox);
connect(d->m_osFlavorComboBox, SIGNAL(currentIndexChanged(int)), this, SLOT(customAbiChanged())); connect(d->m_osFlavorComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
this, &AbiWidget::customAbiChanged);
QLabel *separator3 = new QLabel(this); QLabel *separator3 = new QLabel(this);
separator3->setText(QLatin1String("-")); separator3->setText(QLatin1String("-"));
@@ -120,7 +124,8 @@ AbiWidget::AbiWidget(QWidget *parent) :
for (int i = 0; i <= static_cast<int>(Abi::UnknownFormat); ++i) for (int i = 0; i <= static_cast<int>(Abi::UnknownFormat); ++i)
d->m_binaryFormatComboBox->addItem(Abi::toString(static_cast<Abi::BinaryFormat>(i)), i); d->m_binaryFormatComboBox->addItem(Abi::toString(static_cast<Abi::BinaryFormat>(i)), i);
d->m_binaryFormatComboBox->setCurrentIndex(static_cast<int>(Abi::UnknownFormat)); d->m_binaryFormatComboBox->setCurrentIndex(static_cast<int>(Abi::UnknownFormat));
connect(d->m_binaryFormatComboBox, SIGNAL(currentIndexChanged(int)), this, SLOT(customAbiChanged())); connect(d->m_binaryFormatComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
this, &AbiWidget::customAbiChanged);
QLabel *separator4 = new QLabel(this); QLabel *separator4 = new QLabel(this);
separator4->setText(QLatin1String("-")); separator4->setText(QLatin1String("-"));
@@ -134,7 +139,8 @@ AbiWidget::AbiWidget(QWidget *parent) :
d->m_wordWidthComboBox->addItem(Abi::toString(64), 64); d->m_wordWidthComboBox->addItem(Abi::toString(64), 64);
d->m_wordWidthComboBox->addItem(Abi::toString(0), 0); d->m_wordWidthComboBox->addItem(Abi::toString(0), 0);
d->m_wordWidthComboBox->setCurrentIndex(2); d->m_wordWidthComboBox->setCurrentIndex(2);
connect(d->m_wordWidthComboBox, SIGNAL(currentIndexChanged(int)), this, SLOT(customAbiChanged())); connect(d->m_wordWidthComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
this, &AbiWidget::customAbiChanged);
layout->setStretchFactor(d->m_abi, 1); layout->setStretchFactor(d->m_abi, 1);

View File

@@ -55,12 +55,11 @@ public:
signals: signals:
void abiChanged(); void abiChanged();
private slots: private:
void osChanged(); void osChanged();
void modeChanged(); void modeChanged();
void customAbiChanged(); void customAbiChanged();
private:
void setCustomAbi(const Abi &a); void setCustomAbi(const Abi &a);
Internal::AbiWidgetPrivate *const d; Internal::AbiWidgetPrivate *const d;

View File

@@ -213,13 +213,13 @@ void AbstractProcessStep::run(QFutureInterface<bool> &fi)
m_process->setWorkingDirectory(wd.absolutePath()); m_process->setWorkingDirectory(wd.absolutePath());
m_process->setEnvironment(m_param.environment()); m_process->setEnvironment(m_param.environment());
connect(m_process, SIGNAL(readyReadStandardOutput()), connect(m_process, &QProcess::readyReadStandardOutput,
this, SLOT(processReadyReadStdOutput())); this, &AbstractProcessStep::processReadyReadStdOutput);
connect(m_process, SIGNAL(readyReadStandardError()), connect(m_process, &QProcess::readyReadStandardError,
this, SLOT(processReadyReadStdError())); this, &AbstractProcessStep::processReadyReadStdError);
connect(m_process, SIGNAL(finished(int,QProcess::ExitStatus)), connect(m_process, static_cast<void (QProcess::*)(int,QProcess::ExitStatus)>(&QProcess::finished),
this, SLOT(slotProcessFinished(int,QProcess::ExitStatus))); this, &AbstractProcessStep::slotProcessFinished);
m_process->setCommand(effectiveCommand, m_param.effectiveArguments()); m_process->setCommand(effectiveCommand, m_param.effectiveArguments());
m_process->start(); m_process->start();
@@ -234,7 +234,7 @@ void AbstractProcessStep::run(QFutureInterface<bool> &fi)
processStarted(); processStarted();
m_timer = new QTimer(); m_timer = new QTimer();
connect(m_timer, SIGNAL(timeout()), this, SLOT(checkForCancel())); connect(m_timer, &QTimer::timeout, this, &AbstractProcessStep::checkForCancel);
m_timer->start(500); m_timer->start(500);
m_killProcess = false; m_killProcess = false;
} }

View File

@@ -77,7 +77,7 @@ protected:
QFutureInterface<bool> *futureInterface() const; QFutureInterface<bool> *futureInterface() const;
private slots: private:
void processReadyReadStdOutput(); void processReadyReadStdOutput();
void processReadyReadStdError(); void processReadyReadStdError();
void slotProcessFinished(int, QProcess::ExitStatus); void slotProcessFinished(int, QProcess::ExitStatus);
@@ -89,7 +89,6 @@ private slots:
void outputAdded(const QString &string, BuildStep::OutputFormat format); void outputAdded(const QString &string, BuildStep::OutputFormat format);
private:
QTimer *m_timer; QTimer *m_timer;
QFutureInterface<bool> *m_futureInterface; QFutureInterface<bool> *m_futureInterface;
ProcessParameters m_param; ProcessParameters m_param;

View File

@@ -44,8 +44,8 @@ AllProjectsFilter::AllProjectsFilter()
setShortcutString(QString(QLatin1Char('a'))); setShortcutString(QString(QLatin1Char('a')));
setIncludedByDefault(true); setIncludedByDefault(true);
connect(ProjectExplorerPlugin::instance(), SIGNAL(fileListChanged()), connect(ProjectExplorerPlugin::instance(), &ProjectExplorerPlugin::fileListChanged,
this, SLOT(markFilesAsOutOfDate())); this, &AllProjectsFilter::markFilesAsOutOfDate);
} }
void AllProjectsFilter::markFilesAsOutOfDate() void AllProjectsFilter::markFilesAsOutOfDate()
@@ -69,5 +69,5 @@ void AllProjectsFilter::prepareSearch(const QString &entry)
void AllProjectsFilter::refresh(QFutureInterface<void> &future) void AllProjectsFilter::refresh(QFutureInterface<void> &future)
{ {
Q_UNUSED(future) Q_UNUSED(future)
QTimer::singleShot(0, this, SLOT(markFilesAsOutOfDate())); QTimer::singleShot(0, this, &AllProjectsFilter::markFilesAsOutOfDate);
} }

View File

@@ -42,7 +42,7 @@ public:
void refresh(QFutureInterface<void> &future); void refresh(QFutureInterface<void> &future);
void prepareSearch(const QString &entry); void prepareSearch(const QString &entry);
private slots: private:
void markFilesAsOutOfDate(); void markFilesAsOutOfDate();
}; };

View File

@@ -49,7 +49,8 @@ using namespace TextEditor;
AllProjectsFind::AllProjectsFind() AllProjectsFind::AllProjectsFind()
: m_configWidget(0) : m_configWidget(0)
{ {
connect(ProjectExplorerPlugin::instance(), SIGNAL(fileListChanged()), this, SLOT(handleFileListChanged())); connect(ProjectExplorerPlugin::instance(), &ProjectExplorerPlugin::fileListChanged,
this, &AllProjectsFind::handleFileListChanged);
} }
QString AllProjectsFind::id() const QString AllProjectsFind::id() const

View File

@@ -62,10 +62,9 @@ protected:
QString label() const; QString label() const;
QString toolTip() const; QString toolTip() const;
private slots: private:
void handleFileListChanged(); void handleFileListChanged();
private:
QPointer<QWidget> m_configWidget; QPointer<QWidget> m_configWidget;
}; };

View File

@@ -92,37 +92,38 @@ ApplicationLauncher::ApplicationLauncher(QObject *parent)
d->m_guiProcess.setReadChannelMode(QProcess::MergedChannels); d->m_guiProcess.setReadChannelMode(QProcess::MergedChannels);
} else { } else {
d->m_guiProcess.setReadChannelMode(QProcess::SeparateChannels); d->m_guiProcess.setReadChannelMode(QProcess::SeparateChannels);
connect(&d->m_guiProcess, SIGNAL(readyReadStandardError()), connect(&d->m_guiProcess, &QProcess::readyReadStandardError,
this, SLOT(readStandardError())); this, &ApplicationLauncher::readStandardError);
} }
connect(&d->m_guiProcess, SIGNAL(readyReadStandardOutput()), connect(&d->m_guiProcess, &QProcess::readyReadStandardOutput,
this, SLOT(readStandardOutput())); this, &ApplicationLauncher::readStandardOutput);
connect(&d->m_guiProcess, SIGNAL(error(QProcess::ProcessError)), connect(&d->m_guiProcess, static_cast<void (QProcess::*)(QProcess::ProcessError)>(&QProcess::error),
this, SLOT(guiProcessError())); this, &ApplicationLauncher::guiProcessError);
connect(&d->m_guiProcess, SIGNAL(finished(int,QProcess::ExitStatus)), connect(&d->m_guiProcess, static_cast<void (QProcess::*)(int,QProcess::ExitStatus)>(&QProcess::finished),
this, SLOT(processDone(int,QProcess::ExitStatus))); this, &ApplicationLauncher::processDone);
connect(&d->m_guiProcess, SIGNAL(started()), connect(&d->m_guiProcess, &QProcess::started,
this, SLOT(bringToForeground())); this, &ApplicationLauncher::bringToForeground);
connect(&d->m_guiProcess, SIGNAL(error(QProcess::ProcessError)), connect(&d->m_guiProcess, static_cast<void (QProcess::*)(QProcess::ProcessError)>(&QProcess::error),
this, SIGNAL(error(QProcess::ProcessError))); this, &ApplicationLauncher::error);
#ifdef Q_OS_UNIX #ifdef Q_OS_UNIX
d->m_consoleProcess.setSettings(Core::ICore::settings()); d->m_consoleProcess.setSettings(Core::ICore::settings());
#endif #endif
connect(&d->m_consoleProcess, SIGNAL(processStarted()), connect(&d->m_consoleProcess, &Utils::ConsoleProcess::processStarted,
this, SIGNAL(processStarted())); this, &ApplicationLauncher::processStarted);
connect(&d->m_consoleProcess, SIGNAL(processError(QString)), connect(&d->m_consoleProcess, &Utils::ConsoleProcess::processError,
this, SLOT(consoleProcessError(QString))); this, &ApplicationLauncher::consoleProcessError);
connect(&d->m_consoleProcess, SIGNAL(processStopped(int,QProcess::ExitStatus)), connect(&d->m_consoleProcess, &Utils::ConsoleProcess::processStopped,
this, SLOT(processDone(int,QProcess::ExitStatus))); this, &ApplicationLauncher::processDone);
connect(&d->m_consoleProcess, SIGNAL(error(QProcess::ProcessError)), connect(&d->m_consoleProcess,
this, SIGNAL(error(QProcess::ProcessError))); static_cast<void (Utils::ConsoleProcess::*)(QProcess::ProcessError)>(&Utils::ConsoleProcess::error),
this, &ApplicationLauncher::error);
#ifdef Q_OS_WIN #ifdef Q_OS_WIN
connect(WinDebugInterface::instance(), SIGNAL(cannotRetrieveDebugOutput()), connect(WinDebugInterface::instance(), &WinDebugInterface::cannotRetrieveDebugOutput,
this, SLOT(cannotRetrieveDebugOutput())); this, &ApplicationLauncher::cannotRetrieveDebugOutput);
connect(WinDebugInterface::instance(), SIGNAL(debugOutput(qint64,QString)), connect(WinDebugInterface::instance(), &WinDebugInterface::debugOutput,
this, SLOT(checkDebugOutput(qint64,QString)), Qt::BlockingQueuedConnection); this, &ApplicationLauncher::checkDebugOutput, Qt::BlockingQueuedConnection);
#endif #endif
#ifdef WITH_JOURNALD #ifdef WITH_JOURNALD
connect(JournaldWatcher::instance(), &JournaldWatcher::journaldOutput, connect(JournaldWatcher::instance(), &JournaldWatcher::journaldOutput,

View File

@@ -69,7 +69,7 @@ signals:
void bringToForegroundRequested(qint64 pid); void bringToForegroundRequested(qint64 pid);
void error(QProcess::ProcessError error); void error(QProcess::ProcessError error);
private slots: private:
void guiProcessError(); void guiProcessError();
void consoleProcessError(const QString &error); void consoleProcessError(const QString &error);
void readStandardOutput(); void readStandardOutput();
@@ -81,7 +81,6 @@ private slots:
void processDone(int, QProcess::ExitStatus); void processDone(int, QProcess::ExitStatus);
void bringToForeground(); void bringToForeground();
private:
ApplicationLauncherPrivate *d; ApplicationLauncherPrivate *d;
}; };

View File

@@ -90,9 +90,8 @@ signals:
void contextMenuRequested(const QPoint &pos, const int index); void contextMenuRequested(const QPoint &pos, const int index);
protected: protected:
bool eventFilter(QObject *object, QEvent *event); bool eventFilter(QObject *object, QEvent *event);
private slots:
void slotContextMenuRequested(const QPoint &pos);
private: private:
void slotContextMenuRequested(const QPoint &pos);
int m_tabIndexForMiddleClick; int m_tabIndexForMiddleClick;
}; };
@@ -104,8 +103,8 @@ TabWidget::TabWidget(QWidget *parent)
{ {
tabBar()->installEventFilter(this); tabBar()->installEventFilter(this);
setContextMenuPolicy(Qt::CustomContextMenu); setContextMenuPolicy(Qt::CustomContextMenu);
connect(this, SIGNAL(customContextMenuRequested(QPoint)), connect(this, &QWidget::customContextMenuRequested,
this, SLOT(slotContextMenuRequested(QPoint))); this, &TabWidget::slotContextMenuRequested);
} }
bool TabWidget::eventFilter(QObject *object, QEvent *event) bool TabWidget::eventFilter(QObject *object, QEvent *event)
@@ -163,8 +162,8 @@ AppOutputPane::AppOutputPane() :
m_reRunButton->setToolTip(tr("Re-run this run-configuration")); m_reRunButton->setToolTip(tr("Re-run this run-configuration"));
m_reRunButton->setAutoRaise(true); m_reRunButton->setAutoRaise(true);
m_reRunButton->setEnabled(false); m_reRunButton->setEnabled(false);
connect(m_reRunButton, SIGNAL(clicked()), connect(m_reRunButton, &QAbstractButton::clicked,
this, SLOT(reRunRunControl())); this, &AppOutputPane::reRunRunControl);
// Stop // Stop
m_stopAction->setIcon(Icons::STOP_SMALL.icon()); m_stopAction->setIcon(Icons::STOP_SMALL.icon());
@@ -176,8 +175,8 @@ AppOutputPane::AppOutputPane() :
m_stopButton->setDefaultAction(cmd->action()); m_stopButton->setDefaultAction(cmd->action());
m_stopButton->setAutoRaise(true); m_stopButton->setAutoRaise(true);
connect(m_stopAction, SIGNAL(triggered()), connect(m_stopAction, &QAction::triggered,
this, SLOT(stopRunControl())); this, &AppOutputPane::stopRunControl);
// Attach // Attach
m_attachButton->setToolTip(msgAttachDebuggerTooltip()); m_attachButton->setToolTip(msgAttachDebuggerTooltip());
@@ -185,8 +184,8 @@ AppOutputPane::AppOutputPane() :
m_attachButton->setIcon(Core::Icons::DEBUG_START_SMALL.icon()); m_attachButton->setIcon(Core::Icons::DEBUG_START_SMALL.icon());
m_attachButton->setAutoRaise(true); m_attachButton->setAutoRaise(true);
connect(m_attachButton, SIGNAL(clicked()), connect(m_attachButton, &QAbstractButton::clicked,
this, SLOT(attachToRunControl())); this, &AppOutputPane::attachToRunControl);
m_zoomInButton->setToolTip(tr("Increase Font Size")); m_zoomInButton->setToolTip(tr("Increase Font Size"));
m_zoomInButton->setIcon(Core::Icons::PLUS.icon()); m_zoomInButton->setIcon(Core::Icons::PLUS.icon());
@@ -209,11 +208,13 @@ AppOutputPane::AppOutputPane() :
m_tabWidget->setDocumentMode(true); m_tabWidget->setDocumentMode(true);
m_tabWidget->setTabsClosable(true); m_tabWidget->setTabsClosable(true);
m_tabWidget->setMovable(true); m_tabWidget->setMovable(true);
connect(m_tabWidget, SIGNAL(tabCloseRequested(int)), this, SLOT(closeTab(int))); connect(m_tabWidget, &QTabWidget::tabCloseRequested,
this, [this](int index) { closeTab(index); });
layout->addWidget(m_tabWidget); layout->addWidget(m_tabWidget);
connect(m_tabWidget, SIGNAL(currentChanged(int)), this, SLOT(tabChanged(int))); connect(m_tabWidget, &QTabWidget::currentChanged, this, &AppOutputPane::tabChanged);
connect(m_tabWidget, SIGNAL(contextMenuRequested(QPoint,int)), this, SLOT(contextMenuRequested(QPoint,int))); connect(m_tabWidget, &TabWidget::contextMenuRequested,
this, &AppOutputPane::contextMenuRequested);
m_mainWidget->setLayout(layout); m_mainWidget->setLayout(layout);
@@ -223,10 +224,10 @@ AppOutputPane::AppOutputPane() :
connect(TextEditor::TextEditorSettings::instance(), &TextEditor::TextEditorSettings::behaviorSettingsChanged, connect(TextEditor::TextEditorSettings::instance(), &TextEditor::TextEditorSettings::behaviorSettingsChanged,
this, &AppOutputPane::updateBehaviorSettings); this, &AppOutputPane::updateBehaviorSettings);
connect(SessionManager::instance(), SIGNAL(aboutToUnloadSession(QString)), connect(SessionManager::instance(), &SessionManager::aboutToUnloadSession,
this, SLOT(aboutToUnloadSession())); this, &AppOutputPane::aboutToUnloadSession);
connect(ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()), connect(ProjectExplorerPlugin::instance(), &ProjectExplorerPlugin::settingsChanged,
this, SLOT(updateFromSettings())); this, &AppOutputPane::updateFromSettings);
#ifdef Q_OS_WIN #ifdef Q_OS_WIN
connect(this, &AppOutputPane::allRunControlsFinished, connect(this, &AppOutputPane::allRunControlsFinished,
@@ -381,14 +382,15 @@ void AppOutputPane::updateBehaviorSettings()
void AppOutputPane::createNewOutputWindow(RunControl *rc) void AppOutputPane::createNewOutputWindow(RunControl *rc)
{ {
connect(rc, SIGNAL(started()), connect(rc, &RunControl::started,
this, SLOT(slotRunControlStarted())); this, &AppOutputPane::slotRunControlStarted);
connect(rc, SIGNAL(finished()), connect(rc, &RunControl::finished,
this, SLOT(slotRunControlFinished())); this, &AppOutputPane::slotRunControlFinished);
connect(rc, SIGNAL(applicationProcessHandleChanged()), connect(rc, &RunControl::applicationProcessHandleChanged,
this, SLOT(enableButtons())); this, &AppOutputPane::enableDefaultButtons);
connect(rc, SIGNAL(appendMessage(ProjectExplorer::RunControl*,QString,Utils::OutputFormat)), connect(rc, static_cast<void (RunControl::*)(
this, SLOT(appendMessage(ProjectExplorer::RunControl*,QString,Utils::OutputFormat))); ProjectExplorer::RunControl *, const QString &, Utils::OutputFormat)>(&RunControl::appendMessage),
this, &AppOutputPane::appendMessage);
Utils::OutputFormatter *formatter = rc->outputFormatter(); Utils::OutputFormatter *formatter = rc->outputFormatter();
@@ -536,11 +538,6 @@ QList<RunControl *> AppOutputPane::allRunControls() const
}); });
} }
bool AppOutputPane::closeTab(int index)
{
return closeTab(index, CloseTabWithPrompt);
}
bool AppOutputPane::closeTab(int tabIndex, CloseTabMode closeTabMode) bool AppOutputPane::closeTab(int tabIndex, CloseTabMode closeTabMode)
{ {
int index = indexOf(m_tabWidget->widget(tabIndex)); int index = indexOf(m_tabWidget->widget(tabIndex));
@@ -605,7 +602,7 @@ void AppOutputPane::projectRemoved()
tabChanged(m_tabWidget->currentIndex()); tabChanged(m_tabWidget->currentIndex());
} }
void AppOutputPane::enableButtons() void AppOutputPane::enableDefaultButtons()
{ {
const RunControl *rc = currentRunControl(); const RunControl *rc = currentRunControl();
const bool isRunning = rc && rc->isRunning(); const bool isRunning = rc && rc->isRunning();
@@ -663,7 +660,7 @@ void AppOutputPane::tabChanged(int i)
const RunControl *rc = m_runControlTabs.at(index).runControl; const RunControl *rc = m_runControlTabs.at(index).runControl;
enableButtons(rc, rc->isRunning()); enableButtons(rc, rc->isRunning());
} else { } else {
enableButtons(); enableDefaultButtons();
} }
} }
@@ -695,8 +692,7 @@ void AppOutputPane::slotRunControlStarted()
void AppOutputPane::slotRunControlFinished() void AppOutputPane::slotRunControlFinished()
{ {
RunControl *rc = qobject_cast<RunControl *>(sender()); RunControl *rc = qobject_cast<RunControl *>(sender());
QMetaObject::invokeMethod(this, "slotRunControlFinished2", Qt::QueuedConnection, QTimer::singleShot(0, this, [this, rc]() { slotRunControlFinished2(rc); });
Q_ARG(ProjectExplorer::RunControl *, rc));
rc->outputFormatter()->flush(); rc->outputFormatter()->flush();
} }

View File

@@ -101,11 +101,10 @@ public slots:
void appendMessage(ProjectExplorer::RunControl *rc, const QString &out, void appendMessage(ProjectExplorer::RunControl *rc, const QString &out,
Utils::OutputFormat format); Utils::OutputFormat format);
private slots: private:
void reRunRunControl(); void reRunRunControl();
void stopRunControl(); void stopRunControl();
void attachToRunControl(); void attachToRunControl();
bool closeTab(int index);
void tabChanged(int); void tabChanged(int);
void contextMenuRequested(const QPoint &pos, int index); void contextMenuRequested(const QPoint &pos, int index);
void slotRunControlStarted(); void slotRunControlStarted();
@@ -114,12 +113,11 @@ private slots:
void aboutToUnloadSession(); void aboutToUnloadSession();
void updateFromSettings(); void updateFromSettings();
void enableButtons(); void enableDefaultButtons();
void zoomIn(); void zoomIn();
void zoomOut(); void zoomOut();
private:
void enableButtons(const RunControl *rc, bool isRunning); void enableButtons(const RunControl *rc, bool isRunning);
struct RunControlTab { struct RunControlTab {
@@ -133,7 +131,7 @@ private:
}; };
bool isRunning() const; bool isRunning() const;
bool closeTab(int index, CloseTabMode cm); bool closeTab(int index, CloseTabMode cm = CloseTabWithPrompt);
bool optionallyPromptToStop(RunControl *runControl); bool optionallyPromptToStop(RunControl *runControl);
int indexOf(const RunControl *) const; int indexOf(const RunControl *) const;

View File

@@ -67,9 +67,10 @@ BuildConfiguration::BuildConfiguration(Target *target, Core::Id id) :
emitEnvironmentChanged(); emitEnvironmentChanged();
connect(target, SIGNAL(kitChanged()), connect(target, &Target::kitChanged,
this, SLOT(handleKitUpdate())); this, &BuildConfiguration::handleKitUpdate);
connect(this, SIGNAL(environmentChanged()), this, SLOT(emitBuildDirectoryChanged())); connect(this, &BuildConfiguration::environmentChanged,
this, &BuildConfiguration::emitBuildDirectoryChanged);
ctor(); ctor();
} }
@@ -87,8 +88,8 @@ BuildConfiguration::BuildConfiguration(Target *target, BuildConfiguration *sourc
emitEnvironmentChanged(); emitEnvironmentChanged();
connect(target, SIGNAL(kitChanged()), connect(target, &Target::kitChanged,
this, SLOT(handleKitUpdate())); this, &BuildConfiguration::handleKitUpdate);
ctor(); ctor();
} }

View File

@@ -101,11 +101,10 @@ protected:
void cloneSteps(BuildConfiguration *source); void cloneSteps(BuildConfiguration *source);
void emitEnvironmentChanged(); void emitEnvironmentChanged();
private slots: private:
void handleKitUpdate(); void handleKitUpdate();
void emitBuildDirectoryChanged(); void emitBuildDirectoryChanged();
private:
void ctor(); void ctor();
bool m_clearSystemEnvironment; bool m_clearSystemEnvironment;

View File

@@ -59,14 +59,14 @@ BuildConfigurationModel::BuildConfigurationModel(Target *target, QObject *parent
m_buildConfigurations = m_target->buildConfigurations(); m_buildConfigurations = m_target->buildConfigurations();
Utils::sort(m_buildConfigurations, BuildConfigurationComparer()); Utils::sort(m_buildConfigurations, BuildConfigurationComparer());
connect(target, SIGNAL(addedBuildConfiguration(ProjectExplorer::BuildConfiguration*)), connect(target, &Target::addedBuildConfiguration,
this, SLOT(addedBuildConfiguration(ProjectExplorer::BuildConfiguration*))); this, &BuildConfigurationModel::addedBuildConfiguration);
connect(target, SIGNAL(removedBuildConfiguration(ProjectExplorer::BuildConfiguration*)), connect(target, &Target::removedBuildConfiguration,
this, SLOT(removedBuildConfiguration(ProjectExplorer::BuildConfiguration*))); this, &BuildConfigurationModel::removedBuildConfiguration);
foreach (BuildConfiguration *bc, m_buildConfigurations) foreach (BuildConfiguration *bc, m_buildConfigurations)
connect(bc, SIGNAL(displayNameChanged()), connect(bc, &ProjectConfiguration::displayNameChanged,
this, SLOT(displayNameChanged())); this, &BuildConfigurationModel::displayNameChanged);
} }
int BuildConfigurationModel::rowCount(const QModelIndex &parent) const int BuildConfigurationModel::rowCount(const QModelIndex &parent) const
@@ -171,8 +171,8 @@ void BuildConfigurationModel::addedBuildConfiguration(BuildConfiguration *bc)
endInsertRows(); endInsertRows();
connect(bc, SIGNAL(displayNameChanged()), connect(bc, &ProjectConfiguration::displayNameChanged,
this, SLOT(displayNameChanged())); this, &BuildConfigurationModel::displayNameChanged);
} }
void BuildConfigurationModel::removedBuildConfiguration(BuildConfiguration *bc) void BuildConfigurationModel::removedBuildConfiguration(BuildConfiguration *bc)

View File

@@ -46,11 +46,10 @@ public:
BuildConfiguration *buildConfigurationAt(int i); BuildConfiguration *buildConfigurationAt(int i);
BuildConfiguration *buildConfigurationFor(const QModelIndex &idx); BuildConfiguration *buildConfigurationFor(const QModelIndex &idx);
QModelIndex indexFor(BuildConfiguration *rc); QModelIndex indexFor(BuildConfiguration *rc);
private slots: private:
void addedBuildConfiguration(ProjectExplorer::BuildConfiguration*); void addedBuildConfiguration(ProjectExplorer::BuildConfiguration*);
void removedBuildConfiguration(ProjectExplorer::BuildConfiguration*); void removedBuildConfiguration(ProjectExplorer::BuildConfiguration*);
void displayNameChanged(); void displayNameChanged();
private:
Target *m_target; Target *m_target;
QList<BuildConfiguration *> m_buildConfigurations; QList<BuildConfiguration *> m_buildConfigurations;
}; };

View File

@@ -46,15 +46,15 @@ BuildEnvironmentWidget::BuildEnvironmentWidget(BuildConfiguration *bc)
m_buildEnvironmentWidget = new EnvironmentWidget(this, m_clearSystemEnvironmentCheckBox); m_buildEnvironmentWidget = new EnvironmentWidget(this, m_clearSystemEnvironmentCheckBox);
vbox->addWidget(m_buildEnvironmentWidget); vbox->addWidget(m_buildEnvironmentWidget);
connect(m_buildEnvironmentWidget, SIGNAL(userChangesChanged()), connect(m_buildEnvironmentWidget, &EnvironmentWidget::userChangesChanged,
this, SLOT(environmentModelUserChangesChanged())); this, &BuildEnvironmentWidget::environmentModelUserChangesChanged);
connect(m_clearSystemEnvironmentCheckBox, SIGNAL(toggled(bool)), connect(m_clearSystemEnvironmentCheckBox, &QAbstractButton::toggled,
this, SLOT(clearSystemEnvironmentCheckBoxClicked(bool))); this, &BuildEnvironmentWidget::clearSystemEnvironmentCheckBoxClicked);
m_buildConfiguration = bc; m_buildConfiguration = bc;
connect(m_buildConfiguration->target(), SIGNAL(environmentChanged()), connect(m_buildConfiguration->target(), &Target::environmentChanged,
this, SLOT(environmentChanged())); this, &BuildEnvironmentWidget::environmentChanged);
m_clearSystemEnvironmentCheckBox->setChecked(!m_buildConfiguration->useSystemEnvironment()); m_clearSystemEnvironmentCheckBox->setChecked(!m_buildConfiguration->useSystemEnvironment());
m_buildEnvironmentWidget->setBaseEnvironment(m_buildConfiguration->baseEnvironment()); m_buildEnvironmentWidget->setBaseEnvironment(m_buildConfiguration->baseEnvironment());

View File

@@ -44,12 +44,11 @@ class PROJECTEXPLORER_EXPORT BuildEnvironmentWidget : public NamedWidget
public: public:
BuildEnvironmentWidget(BuildConfiguration *bc); BuildEnvironmentWidget(BuildConfiguration *bc);
private slots: private:
void environmentModelUserChangesChanged(); void environmentModelUserChangesChanged();
void clearSystemEnvironmentCheckBoxClicked(bool checked); void clearSystemEnvironmentCheckBoxClicked(bool checked);
void environmentChanged(); void environmentChanged();
private:
EnvironmentWidget *m_buildEnvironmentWidget; EnvironmentWidget *m_buildEnvironmentWidget;
QCheckBox *m_clearSystemEnvironmentCheckBox; QCheckBox *m_clearSystemEnvironmentCheckBox;
BuildConfiguration *m_buildConfiguration; BuildConfiguration *m_buildConfiguration;

View File

@@ -116,18 +116,18 @@ BuildManager::BuildManager(QObject *parent, QAction *cancelBuildAction)
m_instance = this; m_instance = this;
d = new BuildManagerPrivate; d = new BuildManagerPrivate;
connect(&d->m_watcher, SIGNAL(finished()), connect(&d->m_watcher, &QFutureWatcherBase::finished,
this, SLOT(nextBuildQueue()), Qt::QueuedConnection); this, &BuildManager::nextBuildQueue, Qt::QueuedConnection);
connect(&d->m_watcher, SIGNAL(progressValueChanged(int)), connect(&d->m_watcher, &QFutureWatcherBase::progressValueChanged,
this, SLOT(progressChanged())); this, &BuildManager::progressChanged);
connect(&d->m_watcher, SIGNAL(progressTextChanged(QString)), connect(&d->m_watcher, &QFutureWatcherBase::progressTextChanged,
this, SLOT(progressTextChanged())); this, &BuildManager::progressTextChanged);
connect(&d->m_watcher, SIGNAL(progressRangeChanged(int,int)), connect(&d->m_watcher, &QFutureWatcherBase::progressRangeChanged,
this, SLOT(progressChanged())); this, &BuildManager::progressChanged);
connect(SessionManager::instance(), SIGNAL(aboutToRemoveProject(ProjectExplorer::Project*)), connect(SessionManager::instance(), &SessionManager::aboutToRemoveProject,
this, SLOT(aboutToRemoveProject(ProjectExplorer::Project*))); this, &BuildManager::aboutToRemoveProject);
d->m_outputWindow = new Internal::CompileOutputWindow(cancelBuildAction); d->m_outputWindow = new Internal::CompileOutputWindow(cancelBuildAction);
ExtensionSystem::PluginManager::addObject(d->m_outputWindow); ExtensionSystem::PluginManager::addObject(d->m_outputWindow);
@@ -138,16 +138,16 @@ BuildManager::BuildManager(QObject *parent, QAction *cancelBuildAction)
qRegisterMetaType<ProjectExplorer::BuildStep::OutputFormat>(); qRegisterMetaType<ProjectExplorer::BuildStep::OutputFormat>();
qRegisterMetaType<ProjectExplorer::BuildStep::OutputNewlineSetting>(); qRegisterMetaType<ProjectExplorer::BuildStep::OutputNewlineSetting>();
connect(d->m_taskWindow, SIGNAL(tasksChanged()), connect(d->m_taskWindow, &Internal::TaskWindow::tasksChanged,
this, SLOT(updateTaskCount())); this, &BuildManager::updateTaskCount);
connect(d->m_taskWindow, SIGNAL(tasksCleared()), connect(d->m_taskWindow, &Internal::TaskWindow::tasksCleared,
this,SIGNAL(tasksCleared())); this,&BuildManager::tasksCleared);
connect(&d->m_progressWatcher, SIGNAL(canceled()), connect(&d->m_progressWatcher, &QFutureWatcherBase::canceled,
this, SLOT(cancel())); this, &BuildManager::cancel);
connect(&d->m_progressWatcher, SIGNAL(finished()), connect(&d->m_progressWatcher, &QFutureWatcherBase::finished,
this, SLOT(finish())); this, &BuildManager::finish);
} }
BuildManager *BuildManager::instance() BuildManager *BuildManager::instance()
@@ -235,14 +235,14 @@ void BuildManager::finish()
QString time = format.toString(QLatin1String("h:mm:ss")); QString time = format.toString(QLatin1String("h:mm:ss"));
if (time.startsWith(QLatin1String("0:"))) if (time.startsWith(QLatin1String("0:")))
time.remove(0, 2); // Don't display zero hours time.remove(0, 2); // Don't display zero hours
addToOutputWindow(tr("Elapsed time: %1.") .arg(time), BuildStep::MessageOutput); m_instance->addToOutputWindow(tr("Elapsed time: %1.") .arg(time), BuildStep::MessageOutput);
QApplication::alert(ICore::mainWindow(), 3000); QApplication::alert(ICore::mainWindow(), 3000);
} }
void BuildManager::emitCancelMessage() void BuildManager::emitCancelMessage()
{ {
addToOutputWindow(tr("Canceled build/deployment."), BuildStep::ErrorMessageOutput); m_instance->addToOutputWindow(tr("Canceled build/deployment."), BuildStep::ErrorMessageOutput);
} }
void BuildManager::clearBuildQueue() void BuildManager::clearBuildQueue()
@@ -310,7 +310,8 @@ void BuildManager::startBuildQueue()
d->m_futureProgress = ProgressManager::addTask(d->m_progressFutureInterface->future(), d->m_futureProgress = ProgressManager::addTask(d->m_progressFutureInterface->future(),
QString(), "ProjectExplorer.Task.Build", QString(), "ProjectExplorer.Task.Build",
ProgressManager::KeepOnFinish | ProgressManager::ShowInApplicationIcon); ProgressManager::KeepOnFinish | ProgressManager::ShowInApplicationIcon);
connect(d->m_futureProgress.data(), SIGNAL(clicked()), m_instance, SLOT(showBuildResults())); connect(d->m_futureProgress.data(), &FutureProgress::clicked,
m_instance, &BuildManager::showBuildResults);
d->m_futureProgress.data()->setWidget(new Internal::BuildProgress(d->m_taskWindow)); d->m_futureProgress.data()->setWidget(new Internal::BuildProgress(d->m_taskWindow));
d->m_futureProgress.data()->setStatusBarWidget(new Internal::BuildProgress(d->m_taskWindow, d->m_futureProgress.data()->setStatusBarWidget(new Internal::BuildProgress(d->m_taskWindow,
Qt::Horizontal)); Qt::Horizontal));
@@ -344,7 +345,7 @@ void BuildManager::addToTaskWindow(const Task &task, int linkedOutputLines, int
} }
void BuildManager::addToOutputWindow(const QString &string, BuildStep::OutputFormat format, void BuildManager::addToOutputWindow(const QString &string, BuildStep::OutputFormat format,
BuildStep::OutputNewlineSetting newLineSetting) BuildStep::OutputNewlineSetting newlineSettings)
{ {
QString stringToWrite; QString stringToWrite;
if (format == BuildStep::MessageOutput || format == BuildStep::ErrorMessageOutput) { if (format == BuildStep::MessageOutput || format == BuildStep::ErrorMessageOutput) {
@@ -352,15 +353,15 @@ void BuildManager::addToOutputWindow(const QString &string, BuildStep::OutputFor
stringToWrite += QLatin1String(": "); stringToWrite += QLatin1String(": ");
} }
stringToWrite += string; stringToWrite += string;
if (newLineSetting == BuildStep::DoAppendNewline) if (newlineSettings == BuildStep::DoAppendNewline)
stringToWrite += QLatin1Char('\n'); stringToWrite += QLatin1Char('\n');
d->m_outputWindow->appendText(stringToWrite, format); d->m_outputWindow->appendText(stringToWrite, format);
} }
void BuildManager::buildStepFinishedAsync() void BuildManager::buildStepFinishedAsync()
{ {
disconnect(d->m_currentBuildStep, SIGNAL(finished()), disconnect(d->m_currentBuildStep, &BuildStep::finished,
m_instance, SLOT(buildStepFinishedAsync())); this, &BuildManager::buildStepFinishedAsync);
d->m_futureInterfaceForAysnc = QFutureInterface<bool>(); d->m_futureInterfaceForAysnc = QFutureInterface<bool>();
nextBuildQueue(); nextBuildQueue();
} }
@@ -370,7 +371,7 @@ void BuildManager::nextBuildQueue()
d->m_outputWindow->flush(); d->m_outputWindow->flush();
if (d->m_canceling) { if (d->m_canceling) {
d->m_canceling = false; d->m_canceling = false;
QTimer::singleShot(0, m_instance, SLOT(emitCancelMessage())); QTimer::singleShot(0, m_instance, &BuildManager::emitCancelMessage);
disconnectOutput(d->m_currentBuildStep); disconnectOutput(d->m_currentBuildStep);
decrementActiveBuildSteps(d->m_currentBuildStep); decrementActiveBuildSteps(d->m_currentBuildStep);
@@ -454,8 +455,8 @@ void BuildManager::nextStep()
} }
if (d->m_currentBuildStep->runInGuiThread()) { if (d->m_currentBuildStep->runInGuiThread()) {
connect (d->m_currentBuildStep, SIGNAL(finished()), connect(d->m_currentBuildStep, &BuildStep::finished,
m_instance, SLOT(buildStepFinishedAsync())); m_instance, &BuildManager::buildStepFinishedAsync);
d->m_watcher.setFuture(d->m_futureInterfaceForAysnc.future()); d->m_watcher.setFuture(d->m_futureInterfaceForAysnc.future());
d->m_currentBuildStep->run(d->m_futureInterfaceForAysnc); d->m_currentBuildStep->run(d->m_futureInterfaceForAysnc);
} else { } else {
@@ -492,10 +493,8 @@ bool BuildManager::buildQueueAppend(QList<BuildStep *> steps, QStringList names,
int i = 0; int i = 0;
for (; i < count; ++i) { for (; i < count; ++i) {
BuildStep *bs = steps.at(i); BuildStep *bs = steps.at(i);
connect(bs, SIGNAL(addTask(ProjectExplorer::Task, int, int)), connect(bs, &BuildStep::addTask, m_instance, &BuildManager::addToTaskWindow);
m_instance, SLOT(addToTaskWindow(ProjectExplorer::Task, int, int))); connect(bs, &BuildStep::addOutput, m_instance, &BuildManager::addToOutputWindow);
connect(bs, SIGNAL(addOutput(QString,ProjectExplorer::BuildStep::OutputFormat,ProjectExplorer::BuildStep::OutputNewlineSetting)),
m_instance, SLOT(addToOutputWindow(QString,ProjectExplorer::BuildStep::OutputFormat,ProjectExplorer::BuildStep::OutputNewlineSetting)));
if (bs->enabled()) { if (bs->enabled()) {
init = bs->init(earlierSteps); init = bs->init(earlierSteps);
if (!init) if (!init)
@@ -654,12 +653,8 @@ void BuildManager::decrementActiveBuildSteps(BuildStep *bs)
void BuildManager::disconnectOutput(BuildStep *bs) void BuildManager::disconnectOutput(BuildStep *bs)
{ {
disconnect(bs, SIGNAL(addTask(ProjectExplorer::Task, int, int)), disconnect(bs, &BuildStep::addTask, m_instance, 0);
m_instance, SLOT(addToTaskWindow(ProjectExplorer::Task, int, int))); disconnect(bs, &BuildStep::addOutput, m_instance, 0);
disconnect(bs, SIGNAL(addOutput(QString, ProjectExplorer::BuildStep::OutputFormat,
ProjectExplorer::BuildStep::OutputNewlineSetting)),
m_instance, SLOT(addToOutputWindow(QString, ProjectExplorer::BuildStep::OutputFormat,
ProjectExplorer::BuildStep::OutputNewlineSetting)));
} }
} // namespace ProjectExplorer } // namespace ProjectExplorer

View File

@@ -80,12 +80,12 @@ signals:
void taskAdded(const ProjectExplorer::Task &task); void taskAdded(const ProjectExplorer::Task &task);
void tasksCleared(); void tasksCleared();
private slots: private:
static void addToTaskWindow(const ProjectExplorer::Task &task, int linkedOutputLines, int skipLines); static void addToTaskWindow(const ProjectExplorer::Task &task, int linkedOutputLines, int skipLines);
static void addToOutputWindow(const QString &string, ProjectExplorer::BuildStep::OutputFormat, static void addToOutputWindow(const QString &string, BuildStep::OutputFormat format,
ProjectExplorer::BuildStep::OutputNewlineSetting = BuildStep::DoAppendNewline); BuildStep::OutputNewlineSetting newlineSettings = BuildStep::DoAppendNewline);
static void buildStepFinishedAsync(); void buildStepFinishedAsync();
static void nextBuildQueue(); static void nextBuildQueue();
static void progressChanged(); static void progressChanged();
static void progressTextChanged(); static void progressTextChanged();
@@ -94,7 +94,6 @@ private slots:
static void updateTaskCount(); static void updateTaskCount();
static void finish(); static void finish();
private:
static void startBuildQueue(); static void startBuildQueue();
static void nextStep(); static void nextStep();
static void clearBuildQueue(); static void clearBuildQueue();

View File

@@ -87,7 +87,7 @@ BuildProgress::BuildProgress(TaskWindow *taskWindow, Qt::Orientation orientation
m_contentWidget->hide(); m_contentWidget->hide();
connect(m_taskWindow, SIGNAL(tasksChanged()), this, SLOT(updateState())); connect(m_taskWindow.data(), &TaskWindow::tasksChanged, this, &BuildProgress::updateState);
} }
void BuildProgress::updateState() void BuildProgress::updateState()

View File

@@ -42,10 +42,9 @@ class BuildProgress : public QWidget
public: public:
BuildProgress(TaskWindow *taskWindow, Qt::Orientation orientation = Qt::Vertical); BuildProgress(TaskWindow *taskWindow, Qt::Orientation orientation = Qt::Vertical);
private slots: private:
void updateState(); void updateState();
private:
QWidget *m_contentWidget; QWidget *m_contentWidget;
QLabel *m_errorIcon; QLabel *m_errorIcon;
QLabel *m_warningIcon; QLabel *m_warningIcon;

View File

@@ -116,19 +116,19 @@ BuildSettingsWidget::BuildSettingsWidget(Target *target) :
updateAddButtonMenu(); updateAddButtonMenu();
updateBuildSettings(); updateBuildSettings();
connect(m_buildConfigurationComboBox, SIGNAL(currentIndexChanged(int)), connect(m_buildConfigurationComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
this, SLOT(currentIndexChanged(int))); this, &BuildSettingsWidget::currentIndexChanged);
connect(m_removeButton, SIGNAL(clicked()), connect(m_removeButton, &QAbstractButton::clicked,
this, SLOT(deleteConfiguration())); this, [this]() { deleteConfiguration(m_buildConfiguration); });
connect(m_renameButton, SIGNAL(clicked()), connect(m_renameButton, &QAbstractButton::clicked,
this, SLOT(renameConfiguration())); this, &BuildSettingsWidget::renameConfiguration);
connect(m_target, SIGNAL(activeBuildConfigurationChanged(ProjectExplorer::BuildConfiguration*)), connect(m_target, &Target::activeBuildConfigurationChanged,
this, SLOT(updateActiveConfiguration())); this, &BuildSettingsWidget::updateActiveConfiguration);
connect(m_target, SIGNAL(kitChanged()), this, SLOT(updateAddButtonMenu())); connect(m_target, &Target::kitChanged, this, &BuildSettingsWidget::updateAddButtonMenu);
} }
void BuildSettingsWidget::addSubWidget(NamedWidget *widget) void BuildSettingsWidget::addSubWidget(NamedWidget *widget)
@@ -137,8 +137,8 @@ void BuildSettingsWidget::addSubWidget(NamedWidget *widget)
QLabel *label = new QLabel(this); QLabel *label = new QLabel(this);
label->setText(widget->displayName()); label->setText(widget->displayName());
connect(widget, SIGNAL(displayNameChanged(QString)), connect(widget, &NamedWidget::displayNameChanged,
label, SLOT(setText(QString))); label, &QLabel::setText);
QFont f = label->font(); QFont f = label->font();
f.setBold(true); f.setBold(true);
f.setPointSizeF(f.pointSizeF() * 1.2); f.setPointSizeF(f.pointSizeF() * 1.2);
@@ -174,8 +174,9 @@ void BuildSettingsWidget::updateAddButtonMenu()
if (m_target) { if (m_target) {
if (m_target->activeBuildConfiguration()) { if (m_target->activeBuildConfiguration()) {
m_addButtonMenu->addAction(tr("&Clone Selected"), QAction *cloneAction = m_addButtonMenu->addAction(tr("&Clone Selected"));
this, SLOT(cloneConfiguration())); connect(cloneAction, &QAction::triggered,
this, [this]() { cloneConfiguration(m_buildConfiguration); });
} }
IBuildConfigurationFactory *factory = IBuildConfigurationFactory::find(m_target); IBuildConfigurationFactory *factory = IBuildConfigurationFactory::find(m_target);
if (!factory) if (!factory)
@@ -259,16 +260,6 @@ void BuildSettingsWidget::createConfiguration(BuildInfo *info)
info->displayName = originalDisplayName; info->displayName = originalDisplayName;
} }
void BuildSettingsWidget::cloneConfiguration()
{
cloneConfiguration(m_buildConfiguration);
}
void BuildSettingsWidget::deleteConfiguration()
{
deleteConfiguration(m_buildConfiguration);
}
QString BuildSettingsWidget::uniqueName(const QString & name) QString BuildSettingsWidget::uniqueName(const QString & name)
{ {
QString result = name.trimmed(); QString result = name.trimmed();

View File

@@ -55,18 +55,15 @@ public:
void addSubWidget(NamedWidget *widget); void addSubWidget(NamedWidget *widget);
QList<NamedWidget *> subWidgets() const; QList<NamedWidget *> subWidgets() const;
private slots: private:
void updateBuildSettings(); void updateBuildSettings();
void currentIndexChanged(int index); void currentIndexChanged(int index);
void cloneConfiguration();
void deleteConfiguration();
void renameConfiguration(); void renameConfiguration();
void updateAddButtonMenu(); void updateAddButtonMenu();
void updateActiveConfiguration(); void updateActiveConfiguration();
private:
void createConfiguration(BuildInfo *info); void createConfiguration(BuildInfo *info);
void cloneConfiguration(BuildConfiguration *toClone); void cloneConfiguration(BuildConfiguration *toClone);
void deleteConfiguration(BuildConfiguration *toDelete); void deleteConfiguration(BuildConfiguration *toDelete);

View File

@@ -85,7 +85,7 @@ signals:
/// Adds \p string to the compile output view, formatted in \p format /// Adds \p string to the compile output view, formatted in \p format
void addOutput(const QString &string, ProjectExplorer::BuildStep::OutputFormat format, void addOutput(const QString &string, ProjectExplorer::BuildStep::OutputFormat format,
ProjectExplorer::BuildStep::OutputNewlineSetting newlineSetting = DoAppendNewline) const; ProjectExplorer::BuildStep::OutputNewlineSetting newlineSetting = DoAppendNewline);
void finished(); void finished();
@@ -142,7 +142,8 @@ public:
SimpleBuildStepConfigWidget(BuildStep *step) SimpleBuildStepConfigWidget(BuildStep *step)
: m_step(step) : m_step(step)
{ {
connect(m_step, SIGNAL(displayNameChanged()), SIGNAL(updateSummary())); connect(m_step, &ProjectConfiguration::displayNameChanged,
this, &BuildStepConfigWidget::updateSummary);
} }
~SimpleBuildStepConfigWidget() {} ~SimpleBuildStepConfigWidget() {}

View File

@@ -106,10 +106,10 @@ ToolWidget::ToolWidget(QWidget *parent)
layout->addWidget(m_secondWidget); layout->addWidget(m_secondWidget);
connect(m_disableButton, SIGNAL(clicked()), this, SIGNAL(disabledClicked())); connect(m_disableButton, &QAbstractButton::clicked, this, &ToolWidget::disabledClicked);
connect(m_upButton, SIGNAL(clicked()), this, SIGNAL(upClicked())); connect(m_upButton, &QAbstractButton::clicked, this, &ToolWidget::upClicked);
connect(m_downButton, SIGNAL(clicked()), this, SIGNAL(downClicked())); connect(m_downButton, &QAbstractButton::clicked, this, &ToolWidget::downClicked);
connect(m_removeButton, SIGNAL(clicked()), this, SIGNAL(removeClicked())); connect(m_removeButton, &QAbstractButton::clicked, this, &ToolWidget::removeClicked);
} }
void ToolWidget::setOpacity(qreal value) void ToolWidget::setOpacity(qreal value)
@@ -255,14 +255,17 @@ void BuildStepListWidget::init(BuildStepList *bsl)
setupUi(); setupUi();
if (m_buildStepList) { if (m_buildStepList) {
disconnect(m_buildStepList, SIGNAL(stepInserted(int)), this, SLOT(addBuildStep(int))); disconnect(m_buildStepList, &BuildStepList::stepInserted,
disconnect(m_buildStepList, SIGNAL(stepRemoved(int)), this, SLOT(removeBuildStep(int))); this, &BuildStepListWidget::addBuildStep);
disconnect(m_buildStepList, SIGNAL(stepMoved(int,int)), this, SLOT(stepMoved(int,int))); disconnect(m_buildStepList, &BuildStepList::stepRemoved,
this, &BuildStepListWidget::removeBuildStep);
disconnect(m_buildStepList, &BuildStepList::stepMoved,
this, &BuildStepListWidget::stepMoved);
} }
connect(bsl, SIGNAL(stepInserted(int)), this, SLOT(addBuildStep(int))); connect(bsl, &BuildStepList::stepInserted, this, &BuildStepListWidget::addBuildStep);
connect(bsl, SIGNAL(stepRemoved(int)), this, SLOT(removeBuildStep(int))); connect(bsl, &BuildStepList::stepRemoved, this, &BuildStepListWidget::removeBuildStep);
connect(bsl, SIGNAL(stepMoved(int,int)), this, SLOT(stepMoved(int,int))); connect(bsl, &BuildStepList::stepMoved, this, &BuildStepListWidget::stepMoved);
qDeleteAll(m_buildStepsData); qDeleteAll(m_buildStepsData);
m_buildStepsData.clear(); m_buildStepsData.clear();
@@ -326,22 +329,22 @@ void BuildStepListWidget::addBuildStepWidget(int pos, BuildStep *step)
m_vbox->insertWidget(pos, s->detailsWidget); m_vbox->insertWidget(pos, s->detailsWidget);
connect(s->widget, SIGNAL(updateSummary()), connect(s->widget, &BuildStepConfigWidget::updateSummary,
this, SLOT(updateSummary())); this, &BuildStepListWidget::updateSummary);
connect(s->widget, SIGNAL(updateAdditionalSummary()), connect(s->widget, &BuildStepConfigWidget::updateAdditionalSummary,
this, SLOT(updateAdditionalSummary())); this, &BuildStepListWidget::updateAdditionalSummary);
connect(s->step, SIGNAL(enabledChanged()), connect(s->step, &BuildStep::enabledChanged,
this, SLOT(updateEnabledState())); this, &BuildStepListWidget::updateEnabledState);
connect(s->toolWidget, SIGNAL(disabledClicked()), connect(s->toolWidget, &ToolWidget::disabledClicked,
m_disableMapper, SLOT(map())); m_disableMapper, static_cast<void (QSignalMapper::*)()>(&QSignalMapper::map));
connect(s->toolWidget, SIGNAL(upClicked()), connect(s->toolWidget, &ToolWidget::upClicked,
m_upMapper, SLOT(map())); m_upMapper, static_cast<void (QSignalMapper::*)()>(&QSignalMapper::map));
connect(s->toolWidget, SIGNAL(downClicked()), connect(s->toolWidget, &ToolWidget::downClicked,
m_downMapper, SLOT(map())); m_downMapper, static_cast<void (QSignalMapper::*)()>(&QSignalMapper::map));
connect(s->toolWidget, SIGNAL(removeClicked()), connect(s->toolWidget, &ToolWidget::removeClicked,
m_removeMapper, SLOT(map())); m_removeMapper, static_cast<void (QSignalMapper::*)()>(&QSignalMapper::map));
} }
void BuildStepListWidget::addBuildStep(int pos) void BuildStepListWidget::addBuildStep(int pos)
@@ -413,17 +416,17 @@ void BuildStepListWidget::setupUi()
return; return;
m_disableMapper = new QSignalMapper(this); m_disableMapper = new QSignalMapper(this);
connect(m_disableMapper, SIGNAL(mapped(int)), connect(m_disableMapper, static_cast<void (QSignalMapper::*)(int)>(&QSignalMapper::mapped),
this, SLOT(triggerDisable(int))); this, &BuildStepListWidget::triggerDisable);
m_upMapper = new QSignalMapper(this); m_upMapper = new QSignalMapper(this);
connect(m_upMapper, SIGNAL(mapped(int)), connect(m_upMapper, static_cast<void (QSignalMapper::*)(int)>(&QSignalMapper::mapped),
this, SLOT(triggerStepMoveUp(int))); this, &BuildStepListWidget::triggerStepMoveUp);
m_downMapper = new QSignalMapper(this); m_downMapper = new QSignalMapper(this);
connect(m_downMapper, SIGNAL(mapped(int)), connect(m_downMapper, static_cast<void (QSignalMapper::*)(int)>(&QSignalMapper::mapped),
this, SLOT(triggerStepMoveDown(int))); this, &BuildStepListWidget::triggerStepMoveDown);
m_removeMapper = new QSignalMapper(this); m_removeMapper = new QSignalMapper(this);
connect(m_removeMapper, SIGNAL(mapped(int)), connect(m_removeMapper, static_cast<void (QSignalMapper::*)(int)>(&QSignalMapper::mapped),
this, SLOT(triggerRemoveBuildStep(int))); this, &BuildStepListWidget::triggerRemoveBuildStep);
m_vbox = new QVBoxLayout(this); m_vbox = new QVBoxLayout(this);
m_vbox->setContentsMargins(0, 0, 0, 0); m_vbox->setContentsMargins(0, 0, 0, 0);
@@ -446,8 +449,8 @@ void BuildStepListWidget::setupUi()
m_vbox->addLayout(hboxLayout); m_vbox->addLayout(hboxLayout);
connect(m_addButton->menu(), SIGNAL(aboutToShow()), connect(m_addButton->menu(), &QMenu::aboutToShow,
this, SLOT(updateAddBuildStepMenu())); this, &BuildStepListWidget::updateAddBuildStepMenu);
} }
void BuildStepListWidget::updateBuildStepButtonsState() void BuildStepListWidget::updateBuildStepButtonsState()

View File

@@ -103,7 +103,7 @@ public:
void init(BuildStepList *bsl); void init(BuildStepList *bsl);
private slots: private:
void updateAddBuildStepMenu(); void updateAddBuildStepMenu();
void addBuildStep(int pos); void addBuildStep(int pos);
void updateSummary(); void updateSummary();
@@ -116,7 +116,6 @@ private slots:
void removeBuildStep(int pos); void removeBuildStep(int pos);
void triggerDisable(int pos); void triggerDisable(int pos);
private:
void setupUi(); void setupUi();
void updateBuildStepButtonsState(); void updateBuildStepButtonsState();
void addBuildStepWidget(int pos, BuildStep *step); void addBuildStepWidget(int pos, BuildStep *step);

View File

@@ -55,7 +55,7 @@ CodeStyleSettingsWidget::CodeStyleSettingsWidget(Project *project) : QWidget(),
m_ui.languageComboBox->addItem(factory->displayName()); m_ui.languageComboBox->addItem(factory->displayName());
} }
connect(m_ui.languageComboBox, SIGNAL(currentIndexChanged(int)), connect(m_ui.languageComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
m_ui.stackedWidget, SLOT(setCurrentIndex(int))); m_ui.stackedWidget, &QStackedWidget::setCurrentIndex);
} }

View File

@@ -76,8 +76,8 @@ public:
fontSettingsChanged(); fontSettingsChanged();
connect(TextEditor::TextEditorSettings::instance(), SIGNAL(fontSettingsChanged(TextEditor::FontSettings)), connect(TextEditor::TextEditorSettings::instance(), &TextEditor::TextEditorSettings::fontSettingsChanged,
this, SLOT(fontSettingsChanged())); this, &CompileOutputTextEdit::fontSettingsChanged);
connect(Core::ICore::instance(), &Core::ICore::saveSettingsRequested, connect(Core::ICore::instance(), &Core::ICore::saveSettingsRequested,
this, &CompileOutputTextEdit::saveSettings); this, &CompileOutputTextEdit::saveSettings);
@@ -100,7 +100,7 @@ public:
{ {
m_taskids.clear(); m_taskids.clear();
} }
private slots: private:
void fontSettingsChanged() void fontSettingsChanged()
{ {
setBaseFont(TextEditor::TextEditorSettings::fontSettings().font()); setBaseFont(TextEditor::TextEditorSettings::fontSettings().font());
@@ -190,8 +190,8 @@ CompileOutputWindow::CompileOutputWindow(QAction *cancelBuildAction) :
m_handler = new ShowOutputTaskHandler(this); m_handler = new ShowOutputTaskHandler(this);
ExtensionSystem::PluginManager::addObject(m_handler); ExtensionSystem::PluginManager::addObject(m_handler);
connect(ProjectExplorerPlugin::instance(), SIGNAL(settingsChanged()), connect(ProjectExplorerPlugin::instance(), &ProjectExplorerPlugin::settingsChanged,
this, SLOT(updateWordWrapMode())); this, &CompileOutputWindow::updateWordWrapMode);
updateWordWrapMode(); updateWordWrapMode();
} }

View File

@@ -81,11 +81,10 @@ public:
void flush(); void flush();
private slots: private:
void updateWordWrapMode(); void updateWordWrapMode();
void updateZoomEnabled(); void updateZoomEnabled();
private:
CompileOutputTextEdit *m_outputWindow; CompileOutputTextEdit *m_outputWindow;
QHash<unsigned int, QPair<int, int>> m_taskPositions; QHash<unsigned int, QPair<int, int>> m_taskPositions;
ShowOutputTaskHandler * m_handler; ShowOutputTaskHandler * m_handler;

View File

@@ -73,10 +73,12 @@ void CurrentProjectFilter::currentProjectChanged()
if (project == m_project) if (project == m_project)
return; return;
if (m_project) if (m_project)
disconnect(m_project, SIGNAL(fileListChanged()), this, SLOT(markFilesAsOutOfDate())); disconnect(m_project, &Project::fileListChanged,
this, &CurrentProjectFilter::markFilesAsOutOfDate);
if (project) if (project)
connect(project, SIGNAL(fileListChanged()), this, SLOT(markFilesAsOutOfDate())); connect(project, &Project::fileListChanged,
this, &CurrentProjectFilter::markFilesAsOutOfDate);
m_project = project; m_project = project;
markFilesAsOutOfDate(); markFilesAsOutOfDate();
@@ -85,5 +87,5 @@ void CurrentProjectFilter::currentProjectChanged()
void CurrentProjectFilter::refresh(QFutureInterface<void> &future) void CurrentProjectFilter::refresh(QFutureInterface<void> &future)
{ {
Q_UNUSED(future) Q_UNUSED(future)
QTimer::singleShot(0, this, SLOT(markFilesAsOutOfDate())); QTimer::singleShot(0, this, &CurrentProjectFilter::markFilesAsOutOfDate);
} }

View File

@@ -46,11 +46,10 @@ public:
void refresh(QFutureInterface<void> &future); void refresh(QFutureInterface<void> &future);
void prepareSearch(const QString &entry); void prepareSearch(const QString &entry);
private slots: private:
void currentProjectChanged(); void currentProjectChanged();
void markFilesAsOutOfDate(); void markFilesAsOutOfDate();
private:
Project *m_project; Project *m_project;
}; };

View File

@@ -55,7 +55,7 @@ protected:
QVariant additionalParameters() const; QVariant additionalParameters() const;
QString label() const; QString label() const;
private slots: private:
void handleProjectChanged(); void handleProjectChanged();
void recheckEnabled(); void recheckEnabled();
}; };

View File

@@ -39,16 +39,24 @@ CustomParserConfigDialog::CustomParserConfigDialog(QDialog *parent) :
{ {
ui->setupUi(this); ui->setupUi(this);
connect(ui->errorPattern, SIGNAL(textChanged(QString)), this, SLOT(changed())); connect(ui->errorPattern, &QLineEdit::textChanged, this, &CustomParserConfigDialog::changed);
connect(ui->errorOutputMessage, SIGNAL(textChanged(QString)), this, SLOT(changed())); connect(ui->errorOutputMessage, &QLineEdit::textChanged,
connect(ui->errorFileNameCap, SIGNAL(valueChanged(int)), this, SLOT(changed())); this, &CustomParserConfigDialog::changed);
connect(ui->errorLineNumberCap, SIGNAL(valueChanged(int)), this, SLOT(changed())); connect(ui->errorFileNameCap, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged),
connect(ui->errorMessageCap, SIGNAL(valueChanged(int)), this, SLOT(changed())); this, &CustomParserConfigDialog::changed);
connect(ui->warningPattern, SIGNAL(textChanged(QString)), this, SLOT(changed())); connect(ui->errorLineNumberCap, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged),
connect(ui->warningOutputMessage, SIGNAL(textChanged(QString)), this, SLOT(changed())); this, &CustomParserConfigDialog::changed);
connect(ui->warningFileNameCap, SIGNAL(valueChanged(int)), this, SLOT(changed())); connect(ui->errorMessageCap, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged),
connect(ui->warningLineNumberCap, SIGNAL(valueChanged(int)), this, SLOT(changed())); this, &CustomParserConfigDialog::changed);
connect(ui->warningMessageCap, SIGNAL(valueChanged(int)), this, SLOT(changed())); connect(ui->warningPattern, &QLineEdit::textChanged, this, &CustomParserConfigDialog::changed);
connect(ui->warningOutputMessage, &QLineEdit::textChanged,
this, &CustomParserConfigDialog::changed);
connect(ui->warningFileNameCap, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged),
this, &CustomParserConfigDialog::changed);
connect(ui->warningLineNumberCap, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged),
this, &CustomParserConfigDialog::changed);
connect(ui->warningMessageCap, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged),
this, &CustomParserConfigDialog::changed);
changed(); changed();
m_dirty = false; m_dirty = false;

View File

@@ -77,10 +77,9 @@ public:
bool isDirty() const; bool isDirty() const;
private slots: private:
void changed(); void changed();
private:
bool checkPattern(QLineEdit *pattern, const QString &outputText, bool checkPattern(QLineEdit *pattern, const QString &outputText,
QString *errorMessage, QRegularExpressionMatch *match); QString *errorMessage, QRegularExpressionMatch *match);

View File

@@ -528,17 +528,19 @@ CustomToolChainConfigWidget::CustomToolChainConfigWidget(CustomToolChain *tc) :
m_predefinedDetails->updateSummaryText(); m_predefinedDetails->updateSummaryText();
m_headerDetails->updateSummaryText(); m_headerDetails->updateSummaryText();
connect(m_compilerCommand, SIGNAL(rawPathChanged(QString)), this, SIGNAL(dirty())); connect(m_compilerCommand, &PathChooser::rawPathChanged, this, &ToolChainConfigWidget::dirty);
connect(m_makeCommand, SIGNAL(rawPathChanged(QString)), this, SIGNAL(dirty())); connect(m_makeCommand, &PathChooser::rawPathChanged, this, &ToolChainConfigWidget::dirty);
connect(m_abiWidget, SIGNAL(abiChanged()), this, SIGNAL(dirty())); connect(m_abiWidget, &AbiWidget::abiChanged, this, &ToolChainConfigWidget::dirty);
connect(m_predefinedMacros, SIGNAL(textChanged()), this, SLOT(updateSummaries())); connect(m_predefinedMacros, &QPlainTextEdit::textChanged,
connect(m_headerPaths, SIGNAL(textChanged()), this, SLOT(updateSummaries())); this, &CustomToolChainConfigWidget::updateSummaries);
connect(m_cxx11Flags, SIGNAL(textChanged(QString)), this, SIGNAL(dirty())); connect(m_headerPaths, &QPlainTextEdit::textChanged,
connect(m_mkspecs, SIGNAL(textChanged(QString)), this, SIGNAL(dirty())); this, &CustomToolChainConfigWidget::updateSummaries);
connect(m_errorParserComboBox, SIGNAL(currentIndexChanged(int)), connect(m_cxx11Flags, &QLineEdit::textChanged, this, &ToolChainConfigWidget::dirty);
this, SLOT(errorParserChanged(int))); connect(m_mkspecs, &QLineEdit::textChanged, this, &ToolChainConfigWidget::dirty);
connect(m_customParserSettingsButton, SIGNAL(clicked()), connect(m_errorParserComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
this, SLOT(openCustomParserSettingsDialog())); this, &CustomToolChainConfigWidget::errorParserChanged);
connect(m_customParserSettingsButton, &QAbstractButton::clicked,
this, &CustomToolChainConfigWidget::openCustomParserSettingsDialog);
errorParserChanged(m_errorParserComboBox->currentIndex()); errorParserChanged(m_errorParserComboBox->currentIndex());
} }

View File

@@ -169,7 +169,7 @@ class CustomToolChainConfigWidget : public ToolChainConfigWidget
public: public:
CustomToolChainConfigWidget(CustomToolChain *); CustomToolChainConfigWidget(CustomToolChain *);
private slots: private:
void updateSummaries(); void updateSummaries();
void errorParserChanged(int index); void errorParserChanged(int index);
void openCustomParserSettingsDialog(); void openCustomParserSettingsDialog();

View File

@@ -146,7 +146,7 @@ protected:
void initProjectWizardDialog(BaseProjectWizardDialog *w, const QString &defaultPath, void initProjectWizardDialog(BaseProjectWizardDialog *w, const QString &defaultPath,
const QList<QWizardPage *> &extensionPages) const; const QList<QWizardPage *> &extensionPages) const;
private slots: private:
void projectParametersChanged(const QString &project, const QString &path); void projectParametersChanged(const QString &project, const QString &path);
}; };

View File

@@ -213,7 +213,7 @@ QWidget *CustomWizardFieldPage::registerComboBox(const QString &fieldName,
} while (false); } while (false);
registerField(fieldName, combo, "text", SIGNAL(text4Changed(QString))); registerField(fieldName, combo, "text", SIGNAL(text4Changed(QString)));
// Connect to completeChanged() for derived classes that reimplement isComplete() // Connect to completeChanged() for derived classes that reimplement isComplete()
connect(combo, SIGNAL(text4Changed(QString)), SIGNAL(completeChanged())); connect(combo, &TextFieldComboBox::text4Changed, this, &QWizardPage::completeChanged);
return combo; return combo;
} // QComboBox } // QComboBox
@@ -227,7 +227,7 @@ QWidget *CustomWizardFieldPage::registerTextEdit(const QString &fieldName,
textEdit->setAcceptRichText(acceptRichText); textEdit->setAcceptRichText(acceptRichText);
// Connect to completeChanged() for derived classes that reimplement isComplete() // Connect to completeChanged() for derived classes that reimplement isComplete()
registerField(fieldName, textEdit, "plainText", SIGNAL(textChanged())); registerField(fieldName, textEdit, "plainText", SIGNAL(textChanged()));
connect(textEdit, SIGNAL(textChanged()), SIGNAL(completeChanged())); connect(textEdit, &QTextEdit::textChanged, this, &QWizardPage::completeChanged);
const QString defaultText = field.controlAttributes.value(QLatin1String("defaulttext")); const QString defaultText = field.controlAttributes.value(QLatin1String("defaulttext"));
m_textEdits.push_back(TextEditData(textEdit, defaultText)); m_textEdits.push_back(TextEditData(textEdit, defaultText));
return textEdit; return textEdit;
@@ -254,7 +254,7 @@ QWidget *CustomWizardFieldPage::registerPathChooser(const QString &fieldName,
registerField(fieldName, pathChooser, "path", SIGNAL(rawPathChanged(QString))); registerField(fieldName, pathChooser, "path", SIGNAL(rawPathChanged(QString)));
// Connect to completeChanged() for derived classes that reimplement isComplete() // Connect to completeChanged() for derived classes that reimplement isComplete()
connect(pathChooser, SIGNAL(rawPathChanged(QString)), SIGNAL(completeChanged())); connect(pathChooser, &PathChooser::rawPathChanged, this, &QWizardPage::completeChanged);
const QString defaultText = field.controlAttributes.value(QLatin1String("defaulttext")); const QString defaultText = field.controlAttributes.value(QLatin1String("defaulttext"));
m_pathChoosers.push_back(PathChooserData(pathChooser, defaultText)); m_pathChoosers.push_back(PathChooserData(pathChooser, defaultText));
return pathChooser; return pathChooser;
@@ -277,7 +277,7 @@ QWidget *CustomWizardFieldPage::registerCheckBox(const QString &fieldName,
checkBox->setFalseText(falseTextIt.value()); checkBox->setFalseText(falseTextIt.value());
registerField(fieldName, checkBox, "text", SIGNAL(textChanged(QString))); registerField(fieldName, checkBox, "text", SIGNAL(textChanged(QString)));
// Connect to completeChanged() for derived classes that reimplement isComplete() // Connect to completeChanged() for derived classes that reimplement isComplete()
connect(checkBox, SIGNAL(textChanged(QString)), SIGNAL(completeChanged())); connect(checkBox, &TextFieldCheckBox::textChanged, this, &QWizardPage::completeChanged);
return checkBox; return checkBox;
} }
@@ -296,7 +296,7 @@ QWidget *CustomWizardFieldPage::registerLineEdit(const QString &fieldName,
} }
registerField(fieldName, lineEdit, "text", SIGNAL(textEdited(QString))); registerField(fieldName, lineEdit, "text", SIGNAL(textEdited(QString)));
// Connect to completeChanged() for derived classes that reimplement isComplete() // Connect to completeChanged() for derived classes that reimplement isComplete()
connect(lineEdit, SIGNAL(textEdited(QString)), SIGNAL(completeChanged())); connect(lineEdit, &QLineEdit::textEdited, this, &QWizardPage::completeChanged);
const QString defaultText = field.controlAttributes.value(QLatin1String("defaulttext")); const QString defaultText = field.controlAttributes.value(QLatin1String("defaulttext"));
const QString placeholderText = field.controlAttributes.value(QLatin1String("placeholdertext")); const QString placeholderText = field.controlAttributes.value(QLatin1String("placeholdertext"));
@@ -434,7 +434,7 @@ CustomWizardPage::CustomWizardPage(const QSharedPointer<CustomWizardContext> &ct
{ {
m_pathChooser->setHistoryCompleter(QLatin1String("PE.ProjectDir.History")); m_pathChooser->setHistoryCompleter(QLatin1String("PE.ProjectDir.History"));
addRow(tr("Path:"), m_pathChooser); addRow(tr("Path:"), m_pathChooser);
connect(m_pathChooser, SIGNAL(validChanged(bool)), this, SIGNAL(completeChanged())); connect(m_pathChooser, &PathChooser::validChanged, this, &QWizardPage::completeChanged);
} }
QString CustomWizardPage::path() const QString CustomWizardPage::path() const

View File

@@ -57,14 +57,14 @@ DeployConfigurationModel::DeployConfigurationModel(Target *target, QObject *pare
m_deployConfigurations = m_target->deployConfigurations(); m_deployConfigurations = m_target->deployConfigurations();
Utils::sort(m_deployConfigurations, DeployConfigurationComparer()); Utils::sort(m_deployConfigurations, DeployConfigurationComparer());
connect(target, SIGNAL(addedDeployConfiguration(ProjectExplorer::DeployConfiguration*)), connect(target, &Target::addedDeployConfiguration,
this, SLOT(addedDeployConfiguration(ProjectExplorer::DeployConfiguration*))); this, &DeployConfigurationModel::addedDeployConfiguration);
connect(target, SIGNAL(removedDeployConfiguration(ProjectExplorer::DeployConfiguration*)), connect(target, &Target::removedDeployConfiguration,
this, SLOT(removedDeployConfiguration(ProjectExplorer::DeployConfiguration*))); this, &DeployConfigurationModel::removedDeployConfiguration);
foreach (DeployConfiguration *dc, m_deployConfigurations) foreach (DeployConfiguration *dc, m_deployConfigurations)
connect(dc, SIGNAL(displayNameChanged()), connect(dc, &ProjectConfiguration::displayNameChanged,
this, SLOT(displayNameChanged())); this, &DeployConfigurationModel::displayNameChanged);
} }
int DeployConfigurationModel::rowCount(const QModelIndex &parent) const int DeployConfigurationModel::rowCount(const QModelIndex &parent) const
@@ -168,8 +168,8 @@ void DeployConfigurationModel::addedDeployConfiguration(DeployConfiguration *dc)
m_deployConfigurations.insert(i, dc); m_deployConfigurations.insert(i, dc);
endInsertRows(); endInsertRows();
connect(dc, SIGNAL(displayNameChanged()), connect(dc, &ProjectConfiguration::displayNameChanged,
this, SLOT(displayNameChanged())); this, &DeployConfigurationModel::displayNameChanged);
} }
void DeployConfigurationModel::removedDeployConfiguration(DeployConfiguration *dc) void DeployConfigurationModel::removedDeployConfiguration(DeployConfiguration *dc)

View File

@@ -47,11 +47,10 @@ public:
DeployConfiguration *deployConfigurationAt(int i); DeployConfiguration *deployConfigurationAt(int i);
DeployConfiguration *deployConfigurationFor(const QModelIndex &idx); DeployConfiguration *deployConfigurationFor(const QModelIndex &idx);
QModelIndex indexFor(DeployConfiguration *rc); QModelIndex indexFor(DeployConfiguration *rc);
private slots: private:
void addedDeployConfiguration(ProjectExplorer::DeployConfiguration*); void addedDeployConfiguration(ProjectExplorer::DeployConfiguration*);
void removedDeployConfiguration(ProjectExplorer::DeployConfiguration*); void removedDeployConfiguration(ProjectExplorer::DeployConfiguration*);
void displayNameChanged(); void displayNameChanged();
private:
Target *m_target; Target *m_target;
QList<DeployConfiguration *> m_deployConfigurations; QList<DeployConfiguration *> m_deployConfigurations;
}; };

View File

@@ -55,7 +55,8 @@ DeploymentDataView::DeploymentDataView(Target *target, QWidget *parent) :
d->target = target; d->target = target;
connect(target, SIGNAL(deploymentDataChanged()), SLOT(updateDeploymentDataModel())); connect(target, &Target::deploymentDataChanged,
this, &DeploymentDataView::updateDeploymentDataModel);
updateDeploymentDataModel(); updateDeploymentDataModel();
} }

View File

@@ -42,10 +42,9 @@ public:
explicit DeploymentDataView(Target *target, QWidget *parent = 0); explicit DeploymentDataView(Target *target, QWidget *parent = 0);
~DeploymentDataView(); ~DeploymentDataView();
private slots: private:
void updateDeploymentDataModel(); void updateDeploymentDataModel();
private:
Internal::DeploymentDataViewPrivate * const d; Internal::DeploymentDataViewPrivate * const d;
}; };

View File

@@ -41,8 +41,8 @@ DesktopDeviceConfigurationWidget::DesktopDeviceConfigurationWidget(const IDevice
m_ui(new Ui::DesktopDeviceConfigurationWidget) m_ui(new Ui::DesktopDeviceConfigurationWidget)
{ {
m_ui->setupUi(this); m_ui->setupUi(this);
connect(m_ui->freePortsLineEdit, SIGNAL(textChanged(QString)), connect(m_ui->freePortsLineEdit, &QLineEdit::textChanged,
SLOT(updateFreePorts())); this, &DesktopDeviceConfigurationWidget::updateFreePorts);
initGui(); initGui();
} }

View File

@@ -40,10 +40,9 @@ public:
void updateDeviceFromUi(); void updateDeviceFromUi();
private slots: private:
void updateFreePorts(); void updateFreePorts();
private:
void initGui(); void initGui();
private: private:

View File

@@ -56,9 +56,10 @@ DeviceFactorySelectionDialog::DeviceFactorySelectionDialog(QWidget *parent) :
} }
} }
connect(ui->listWidget, SIGNAL(itemSelectionChanged()), SLOT(handleItemSelectionChanged())); connect(ui->listWidget, &QListWidget::itemSelectionChanged,
connect(ui->listWidget, SIGNAL(itemDoubleClicked(QListWidgetItem*)), this, &DeviceFactorySelectionDialog::handleItemSelectionChanged);
SLOT(handleItemDoubleClicked())); connect(ui->listWidget, &QListWidget::itemDoubleClicked,
this, &DeviceFactorySelectionDialog::handleItemDoubleClicked);
handleItemSelectionChanged(); handleItemSelectionChanged();
} }

View File

@@ -46,8 +46,8 @@ public:
Core::Id selectedId() const; Core::Id selectedId() const;
private: private:
Q_SLOT void handleItemSelectionChanged(); void handleItemSelectionChanged();
Q_SLOT void handleItemDoubleClicked(); void handleItemDoubleClicked();
Ui::DeviceFactorySelectionDialog *ui; Ui::DeviceFactorySelectionDialog *ui;
}; };

View File

@@ -354,7 +354,7 @@ DeviceManager::DeviceManager(bool isInstance) : d(new DeviceManagerPrivate)
if (!d->hostKeyDatabase->load(keyFilePath, &error)) if (!d->hostKeyDatabase->load(keyFilePath, &error))
Core::MessageManager::write(error); Core::MessageManager::write(error);
} }
connect(Core::ICore::instance(), SIGNAL(saveSettingsRequested()), SLOT(save())); connect(Core::ICore::instance(), &Core::ICore::saveSettingsRequested, this, &DeviceManager::save);
} }
} }
@@ -478,11 +478,11 @@ void ProjectExplorerPlugin::testDeviceManager()
QVERIFY(!mgr->find(dev->id())); QVERIFY(!mgr->find(dev->id()));
const int oldDeviceCount = mgr->deviceCount(); const int oldDeviceCount = mgr->deviceCount();
QSignalSpy deviceAddedSpy(mgr, SIGNAL(deviceAdded(Core::Id))); QSignalSpy deviceAddedSpy(mgr, &DeviceManager::deviceAdded);
QSignalSpy deviceRemovedSpy(mgr, SIGNAL(deviceRemoved(Core::Id))); QSignalSpy deviceRemovedSpy(mgr, &DeviceManager::deviceRemoved);
QSignalSpy deviceUpdatedSpy(mgr, SIGNAL(deviceUpdated(Core::Id))); QSignalSpy deviceUpdatedSpy(mgr, &DeviceManager::deviceUpdated);
QSignalSpy deviceListReplacedSpy(mgr, SIGNAL(deviceListReplaced())); QSignalSpy deviceListReplacedSpy(mgr, &DeviceManager::deviceListReplaced);
QSignalSpy updatedSpy(mgr, SIGNAL(updated())); QSignalSpy updatedSpy(mgr, &DeviceManager::updated);
mgr->addDevice(dev); mgr->addDevice(dev);
QCOMPARE(mgr->deviceCount(), oldDeviceCount + 1); QCOMPARE(mgr->deviceCount(), oldDeviceCount + 1);

View File

@@ -79,10 +79,9 @@ signals:
void devicesLoaded(); // Emitted once load() is done void devicesLoaded(); // Emitted once load() is done
private slots: private:
void save(); void save();
private:
DeviceManager(bool isInstance = true); DeviceManager(bool isInstance = true);
void load(); void load();

View File

@@ -48,10 +48,14 @@ DeviceManagerModel::DeviceManagerModel(const DeviceManager *deviceManager, QObje
{ {
d->deviceManager = deviceManager; d->deviceManager = deviceManager;
handleDeviceListChanged(); handleDeviceListChanged();
connect(deviceManager, SIGNAL(deviceAdded(Core::Id)), SLOT(handleDeviceAdded(Core::Id))); connect(deviceManager, &DeviceManager::deviceAdded,
connect(deviceManager, SIGNAL(deviceRemoved(Core::Id)), SLOT(handleDeviceRemoved(Core::Id))); this, &DeviceManagerModel::handleDeviceAdded);
connect(deviceManager, SIGNAL(deviceUpdated(Core::Id)), SLOT(handleDeviceUpdated(Core::Id))); connect(deviceManager, &DeviceManager::deviceRemoved,
connect(deviceManager, SIGNAL(deviceListReplaced()), SLOT(handleDeviceListChanged())); this, &DeviceManagerModel::handleDeviceRemoved);
connect(deviceManager, &DeviceManager::deviceUpdated,
this, &DeviceManagerModel::handleDeviceUpdated);
connect(deviceManager, &DeviceManager::deviceListReplaced,
this, &DeviceManagerModel::handleDeviceListChanged);
} }
DeviceManagerModel::~DeviceManagerModel() DeviceManagerModel::~DeviceManagerModel()

View File

@@ -54,13 +54,12 @@ public:
void updateDevice(Core::Id id); void updateDevice(Core::Id id);
private slots: private:
void handleDeviceAdded(Core::Id id); void handleDeviceAdded(Core::Id id);
void handleDeviceRemoved(Core::Id id); void handleDeviceRemoved(Core::Id id);
void handleDeviceUpdated(Core::Id id); void handleDeviceUpdated(Core::Id id);
void handleDeviceListChanged(); void handleDeviceListChanged();
private:
QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const; QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const;
bool matchesTypeFilter(const IDevice::ConstPtr &dev) const; bool matchesTypeFilter(const IDevice::ConstPtr &dev) const;

View File

@@ -89,9 +89,8 @@ class DeviceProcessesDialogPrivate : public QObject
Q_OBJECT Q_OBJECT
public: public:
DeviceProcessesDialogPrivate(KitChooser *chooser, QWidget *parent); DeviceProcessesDialogPrivate(KitChooser *chooser, QDialog *parent);
public slots:
void setDevice(const IDevice::ConstPtr &device); void setDevice(const IDevice::ConstPtr &device);
void updateProcessList(); void updateProcessList();
void updateDevice(); void updateDevice();
@@ -102,8 +101,7 @@ public slots:
void updateButtons(); void updateButtons();
DeviceProcessItem selectedProcess() const; DeviceProcessItem selectedProcess() const;
public: QDialog *q;
QWidget *q;
DeviceProcessList *processList; DeviceProcessList *processList;
ProcessListFilterModel proxyModel; ProcessListFilterModel proxyModel;
QLabel *kitLabel; QLabel *kitLabel;
@@ -118,7 +116,7 @@ public:
QDialogButtonBox *buttonBox; QDialogButtonBox *buttonBox;
}; };
DeviceProcessesDialogPrivate::DeviceProcessesDialogPrivate(KitChooser *chooser, QWidget *parent) DeviceProcessesDialogPrivate::DeviceProcessesDialogPrivate(KitChooser *chooser, QDialog *parent)
: q(parent) : q(parent)
, kitLabel(new QLabel(DeviceProcessesDialog::tr("Kit:"), parent)) , kitLabel(new QLabel(DeviceProcessesDialog::tr("Kit:"), parent))
, kitChooser(chooser) , kitChooser(chooser)
@@ -187,17 +185,24 @@ DeviceProcessesDialogPrivate::DeviceProcessesDialogPrivate(KitChooser *chooser,
proxyModel.setFilterRegExp(processFilterLineEdit->text()); proxyModel.setFilterRegExp(processFilterLineEdit->text());
connect(processFilterLineEdit, SIGNAL(textChanged(QString)), connect(processFilterLineEdit,
&proxyModel, SLOT(setFilterRegExp(QString))); static_cast<void (FancyLineEdit::*)(const QString &)>(&FancyLineEdit::textChanged),
&proxyModel,
static_cast<void (ProcessListFilterModel::*)(const QString &)>(
&ProcessListFilterModel::setFilterRegExp));
connect(procView->selectionModel(), connect(procView->selectionModel(),
SIGNAL(selectionChanged(QItemSelection,QItemSelection)), &QItemSelectionModel::selectionChanged,
SLOT(updateButtons())); this, &DeviceProcessesDialogPrivate::updateButtons);
connect(updateListButton, SIGNAL(clicked()), SLOT(updateProcessList())); connect(updateListButton, &QAbstractButton::clicked,
connect(kitChooser, SIGNAL(currentIndexChanged(int)), SLOT(updateDevice())); this, &DeviceProcessesDialogPrivate::updateProcessList);
connect(killProcessButton, SIGNAL(clicked()), SLOT(killProcess())); connect(kitChooser, &KitChooser::currentIndexChanged,
connect(&proxyModel, SIGNAL(layoutChanged()), SLOT(handleProcessListUpdated())); this, &DeviceProcessesDialogPrivate::updateDevice);
connect(buttonBox, SIGNAL(accepted()), q, SLOT(accept())); connect(killProcessButton, &QAbstractButton::clicked,
connect(buttonBox, SIGNAL(rejected()), q, SLOT(reject())); this, &DeviceProcessesDialogPrivate::killProcess);
connect(&proxyModel, &QAbstractItemModel::layoutChanged,
this, &DeviceProcessesDialogPrivate::handleProcessListUpdated);
connect(buttonBox, &QDialogButtonBox::accepted, q, &QDialog::accept);
connect(buttonBox, &QDialogButtonBox::rejected, q, &QDialog::reject);
QWidget::setTabOrder(kitChooser, processFilterLineEdit); QWidget::setTabOrder(kitChooser, processFilterLineEdit);
QWidget::setTabOrder(processFilterLineEdit, procView); QWidget::setTabOrder(processFilterLineEdit, procView);
@@ -216,12 +221,12 @@ void DeviceProcessesDialogPrivate::setDevice(const IDevice::ConstPtr &device)
QTC_ASSERT(processList, return); QTC_ASSERT(processList, return);
proxyModel.setSourceModel(processList); proxyModel.setSourceModel(processList);
connect(processList, SIGNAL(error(QString)), connect(processList, &DeviceProcessList::error,
SLOT(handleRemoteError(QString))); this, &DeviceProcessesDialogPrivate::handleRemoteError);
connect(processList, SIGNAL(processListUpdated()), connect(processList, &DeviceProcessList::processListUpdated,
SLOT(handleProcessListUpdated())); this, &DeviceProcessesDialogPrivate::handleProcessListUpdated);
connect(processList, SIGNAL(processKilled()), connect(processList, &DeviceProcessList::processKilled,
SLOT(handleProcessKilled()), Qt::QueuedConnection); this, &DeviceProcessesDialogPrivate::handleProcessKilled, Qt::QueuedConnection);
updateButtons(); updateButtons();
updateProcessList(); updateProcessList();
@@ -329,8 +334,8 @@ void DeviceProcessesDialog::addAcceptButton(const QString &label)
{ {
d->acceptButton = new QPushButton(label); d->acceptButton = new QPushButton(label);
d->buttonBox->addButton(d->acceptButton, QDialogButtonBox::AcceptRole); d->buttonBox->addButton(d->acceptButton, QDialogButtonBox::AcceptRole);
connect(d->procView, SIGNAL(activated(QModelIndex)), connect(d->procView, &QAbstractItemView::activated,
d->acceptButton, SLOT(click())); d->acceptButton, &QAbstractButton::click);
d->buttonBox->addButton(QDialogButtonBox::Cancel); d->buttonBox->addButton(QDialogButtonBox::Cancel);
} }

View File

@@ -93,7 +93,8 @@ DeviceSettingsWidget::DeviceSettingsWidget(QWidget *parent)
m_configWidget(0) m_configWidget(0)
{ {
initGui(); initGui();
connect(m_deviceManager, SIGNAL(deviceUpdated(Core::Id)), SLOT(handleDeviceUpdated(Core::Id))); connect(m_deviceManager, &DeviceManager::deviceUpdated,
this, &DeviceSettingsWidget::handleDeviceUpdated);
} }
DeviceSettingsWidget::~DeviceSettingsWidget() DeviceSettingsWidget::~DeviceSettingsWidget()
@@ -122,11 +123,11 @@ void DeviceSettingsWidget::initGui()
lastIndex = 0; lastIndex = 0;
if (lastIndex < m_ui->configurationComboBox->count()) if (lastIndex < m_ui->configurationComboBox->count())
m_ui->configurationComboBox->setCurrentIndex(lastIndex); m_ui->configurationComboBox->setCurrentIndex(lastIndex);
connect(m_ui->configurationComboBox, SIGNAL(currentIndexChanged(int)), connect(m_ui->configurationComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
SLOT(currentDeviceChanged(int))); this, &DeviceSettingsWidget::currentDeviceChanged);
currentDeviceChanged(currentIndex()); currentDeviceChanged(currentIndex());
connect(m_ui->defaultDeviceButton, SIGNAL(clicked()), connect(m_ui->defaultDeviceButton, &QAbstractButton::clicked,
SLOT(setDefaultDevice())); this, &DeviceSettingsWidget::setDefaultDevice);
} }
void DeviceSettingsWidget::addDevice() void DeviceSettingsWidget::addDevice()
@@ -280,14 +281,15 @@ void DeviceSettingsWidget::currentDeviceChanged(int index)
if (device->hasDeviceTester()) { if (device->hasDeviceTester()) {
QPushButton * const button = new QPushButton(tr("Test")); QPushButton * const button = new QPushButton(tr("Test"));
m_additionalActionButtons << button; m_additionalActionButtons << button;
connect(button, SIGNAL(clicked()), SLOT(testDevice())); connect(button, &QAbstractButton::clicked, this, &DeviceSettingsWidget::testDevice);
m_ui->buttonsLayout->insertWidget(m_ui->buttonsLayout->count() - 1, button); m_ui->buttonsLayout->insertWidget(m_ui->buttonsLayout->count() - 1, button);
} }
if (device->canCreateProcessModel()) { if (device->canCreateProcessModel()) {
QPushButton * const button = new QPushButton(tr("Show Running Processes...")); QPushButton * const button = new QPushButton(tr("Show Running Processes..."));
m_additionalActionButtons << button; m_additionalActionButtons << button;
connect(button, SIGNAL(clicked()), SLOT(handleProcessListRequested())); connect(button, &QAbstractButton::clicked,
this, &DeviceSettingsWidget::handleProcessListRequested);
m_ui->buttonsLayout->insertWidget(m_ui->buttonsLayout->count() - 1, button); m_ui->buttonsLayout->insertWidget(m_ui->buttonsLayout->count() - 1, button);
} }

View File

@@ -55,10 +55,12 @@ DeviceTestDialog::DeviceTestDialog(const IDevice::ConstPtr &deviceConfiguration,
d->ui.setupUi(this); d->ui.setupUi(this);
d->deviceTester->setParent(this); d->deviceTester->setParent(this);
connect(d->deviceTester, SIGNAL(progressMessage(QString)), SLOT(handleProgressMessage(QString))); connect(d->deviceTester, &DeviceTester::progressMessage,
connect(d->deviceTester, SIGNAL(errorMessage(QString)), SLOT(handleErrorMessage(QString))); this, &DeviceTestDialog::handleProgressMessage);
connect(d->deviceTester, SIGNAL(finished(ProjectExplorer::DeviceTester::TestResult)), connect(d->deviceTester, &DeviceTester::errorMessage,
SLOT(handleTestFinished(ProjectExplorer::DeviceTester::TestResult))); this, &DeviceTestDialog::handleErrorMessage);
connect(d->deviceTester, &DeviceTester::finished,
this, &DeviceTestDialog::handleTestFinished);
d->deviceTester->testDevice(deviceConfiguration); d->deviceTester->testDevice(deviceConfiguration);
} }

View File

@@ -43,12 +43,11 @@ public:
void reject(); void reject();
private slots: private:
void handleProgressMessage(const QString &message); void handleProgressMessage(const QString &message);
void handleErrorMessage(const QString &message); void handleErrorMessage(const QString &message);
void handleTestFinished(ProjectExplorer::DeviceTester::TestResult result); void handleTestFinished(ProjectExplorer::DeviceTester::TestResult result);
private:
void addText(const QString &text, const QString &color, bool bold); void addText(const QString &text, const QString &color, bool bold);
class DeviceTestDialogPrivate; class DeviceTestDialogPrivate;

View File

@@ -69,12 +69,14 @@ void DeviceUsedPortsGatherer::start(const IDevice::ConstPtr &device)
d->device = device; d->device = device;
d->connection = QSsh::acquireConnection(device->sshParameters()); d->connection = QSsh::acquireConnection(device->sshParameters());
connect(d->connection, SIGNAL(error(QSsh::SshError)), SLOT(handleConnectionError())); connect(d->connection, &SshConnection::error,
this, &DeviceUsedPortsGatherer::handleConnectionError);
if (d->connection->state() == SshConnection::Connected) { if (d->connection->state() == SshConnection::Connected) {
handleConnectionEstablished(); handleConnectionEstablished();
return; return;
} }
connect(d->connection, SIGNAL(connected()), SLOT(handleConnectionEstablished())); connect(d->connection, &SshConnection::connected,
this, &DeviceUsedPortsGatherer::handleConnectionEstablished);
if (d->connection->state() == SshConnection::Unconnected) if (d->connection->state() == SshConnection::Unconnected)
d->connection->connectToHost(); d->connection->connectToHost();
} }
@@ -86,9 +88,9 @@ void DeviceUsedPortsGatherer::handleConnectionEstablished()
const QByteArray commandLine = d->device->portsGatheringMethod()->commandLine(protocol); const QByteArray commandLine = d->device->portsGatheringMethod()->commandLine(protocol);
d->process = d->connection->createRemoteProcess(commandLine); d->process = d->connection->createRemoteProcess(commandLine);
connect(d->process.data(), SIGNAL(closed(int)), SLOT(handleProcessClosed(int))); connect(d->process.data(), &SshRemoteProcess::closed, this, &DeviceUsedPortsGatherer::handleProcessClosed);
connect(d->process.data(), SIGNAL(readyReadStandardOutput()), SLOT(handleRemoteStdOut())); connect(d->process.data(), &SshRemoteProcess::readyReadStandardOutput, this, &DeviceUsedPortsGatherer::handleRemoteStdOut);
connect(d->process.data(), SIGNAL(readyReadStandardError()), SLOT(handleRemoteStdErr())); connect(d->process.data(), &SshRemoteProcess::readyReadStandardError, this, &DeviceUsedPortsGatherer::handleRemoteStdErr);
d->process->start(); d->process->start();
} }

View File

@@ -50,14 +50,13 @@ signals:
void error(const QString &errMsg); void error(const QString &errMsg);
void portListReady(); void portListReady();
private slots: private:
void handleConnectionEstablished(); void handleConnectionEstablished();
void handleConnectionError(); void handleConnectionError();
void handleProcessClosed(int exitStatus); void handleProcessClosed(int exitStatus);
void handleRemoteStdOut(); void handleRemoteStdOut();
void handleRemoteStdErr(); void handleRemoteStdErr();
private:
void setupUsedPorts(); void setupUsedPorts();
Internal::DeviceUsedPortsGathererPrivate * const d; Internal::DeviceUsedPortsGathererPrivate * const d;

View File

@@ -235,8 +235,8 @@ QList<DeviceProcessItem> LocalProcessList::getLocalProcesses()
void LocalProcessList::doKillProcess(const DeviceProcessItem &process) void LocalProcessList::doKillProcess(const DeviceProcessItem &process)
{ {
DeviceProcessSignalOperation::Ptr signalOperation = device()->signalOperation(); DeviceProcessSignalOperation::Ptr signalOperation = device()->signalOperation();
connect(signalOperation.data(), SIGNAL(finished(QString)), connect(signalOperation.data(), &DeviceProcessSignalOperation::finished,
SLOT(reportDelayedKillStatus(QString))); this, &LocalProcessList::reportDelayedKillStatus);
signalOperation->killProcess(process.pid); signalOperation->killProcess(process.pid);
} }
@@ -255,7 +255,7 @@ void LocalProcessList::handleUpdate()
void LocalProcessList::doUpdate() void LocalProcessList::doUpdate()
{ {
QTimer::singleShot(0, this, SLOT(handleUpdate())); QTimer::singleShot(0, this, &LocalProcessList::handleUpdate);
} }
void LocalProcessList::reportDelayedKillStatus(const QString &errorMessage) void LocalProcessList::reportDelayedKillStatus(const QString &errorMessage)

View File

@@ -51,11 +51,10 @@ private:
void doUpdate(); void doUpdate();
void doKillProcess(const DeviceProcessItem &process); void doKillProcess(const DeviceProcessItem &process);
private slots: private:
void handleUpdate(); void handleUpdate();
void reportDelayedKillStatus(const QString &errorMessage); void reportDelayedKillStatus(const QString &errorMessage);
private:
const qint64 m_myPid; const qint64 m_myPid;
}; };

View File

@@ -68,7 +68,7 @@ SshDeviceProcess::SshDeviceProcess(const IDevice::ConstPtr &device, QObject *par
d->connection = 0; d->connection = 0;
d->state = SshDeviceProcessPrivate::Inactive; d->state = SshDeviceProcessPrivate::Inactive;
setSshServerSupportsSignals(false); setSshServerSupportsSignals(false);
connect(&d->killTimer, SIGNAL(timeout()), SLOT(handleKillOperationTimeout())); connect(&d->killTimer, &QTimer::timeout, this, &SshDeviceProcess::handleKillOperationTimeout);
} }
SshDeviceProcess::~SshDeviceProcess() SshDeviceProcess::~SshDeviceProcess()
@@ -87,12 +87,15 @@ void SshDeviceProcess::start(const Runnable &runnable)
d->exitCode = -1; d->exitCode = -1;
d->runnable = runnable.as<StandardRunnable>(); d->runnable = runnable.as<StandardRunnable>();
d->connection = QSsh::acquireConnection(device()->sshParameters()); d->connection = QSsh::acquireConnection(device()->sshParameters());
connect(d->connection, SIGNAL(error(QSsh::SshError)), SLOT(handleConnectionError())); connect(d->connection, &QSsh::SshConnection::error,
connect(d->connection, SIGNAL(disconnected()), SLOT(handleDisconnected())); this, &SshDeviceProcess::handleConnectionError);
connect(d->connection, &QSsh::SshConnection::disconnected,
this, &SshDeviceProcess::handleDisconnected);
if (d->connection->state() == QSsh::SshConnection::Connected) { if (d->connection->state() == QSsh::SshConnection::Connected) {
handleConnected(); handleConnected();
} else { } else {
connect(d->connection, SIGNAL(connected()), SLOT(handleConnected())); connect(d->connection, &QSsh::SshConnection::connected,
this, &SshDeviceProcess::handleConnected);
if (d->connection->state() == QSsh::SshConnection::Unconnected) if (d->connection->state() == QSsh::SshConnection::Unconnected)
d->connection->connectToHost(); d->connection->connectToHost();
} }
@@ -171,10 +174,10 @@ void SshDeviceProcess::handleConnected()
d->setState(SshDeviceProcessPrivate::Connected); d->setState(SshDeviceProcessPrivate::Connected);
d->process = d->connection->createRemoteProcess(fullCommandLine(d->runnable).toUtf8()); d->process = d->connection->createRemoteProcess(fullCommandLine(d->runnable).toUtf8());
connect(d->process.data(), SIGNAL(started()), SLOT(handleProcessStarted())); connect(d->process.data(), &QSsh::SshRemoteProcess::started, this, &SshDeviceProcess::handleProcessStarted);
connect(d->process.data(), SIGNAL(closed(int)), SLOT(handleProcessFinished(int))); connect(d->process.data(), &QSsh::SshRemoteProcess::closed, this, &SshDeviceProcess::handleProcessFinished);
connect(d->process.data(), SIGNAL(readyReadStandardOutput()), SLOT(handleStdout())); connect(d->process.data(), &QSsh::SshRemoteProcess::readyReadStandardOutput, this, &SshDeviceProcess::handleStdout);
connect(d->process.data(), SIGNAL(readyReadStandardError()), SLOT(handleStderr())); connect(d->process.data(), &QSsh::SshRemoteProcess::readyReadStandardError, this, &SshDeviceProcess::handleStderr);
d->process->clearEnvironment(); d->process->clearEnvironment();
const Utils::Environment env = d->runnable.environment; const Utils::Environment env = d->runnable.environment;
@@ -302,8 +305,8 @@ void SshDeviceProcess::SshDeviceProcessPrivate::doSignal(QSsh::SshRemoteProcess:
if (killOperation) // We are already in the process of killing the app. if (killOperation) // We are already in the process of killing the app.
return; return;
killOperation = signalOperation; killOperation = signalOperation;
connect(signalOperation.data(), SIGNAL(finished(QString)), q, connect(signalOperation.data(), &DeviceProcessSignalOperation::finished, q,
SLOT(handleKillOperationFinished(QString))); &SshDeviceProcess::handleKillOperationFinished);
killTimer.start(5000); killTimer.start(5000);
signalOperation->killProcess(runnable.executable); signalOperation->killProcess(runnable.executable);
} }

View File

@@ -57,7 +57,7 @@ public:
// Default is "false" due to OpenSSH not implementing this feature for some reason. // Default is "false" due to OpenSSH not implementing this feature for some reason.
void setSshServerSupportsSignals(bool signalsSupported); void setSshServerSupportsSignals(bool signalsSupported);
private slots: private:
void handleConnected(); void handleConnected();
void handleConnectionError(); void handleConnectionError();
void handleDisconnected(); void handleDisconnected();
@@ -68,7 +68,6 @@ private slots:
void handleKillOperationFinished(const QString &errorMessage); void handleKillOperationFinished(const QString &errorMessage);
void handleKillOperationTimeout(); void handleKillOperationTimeout();
private:
virtual QString fullCommandLine(const StandardRunnable &runnable) const; virtual QString fullCommandLine(const StandardRunnable &runnable) const;
class SshDeviceProcessPrivate; class SshDeviceProcessPrivate;

View File

@@ -53,8 +53,10 @@ SshDeviceProcessList::~SshDeviceProcessList()
void SshDeviceProcessList::doUpdate() void SshDeviceProcessList::doUpdate()
{ {
connect(&d->process, SIGNAL(connectionError()), SLOT(handleConnectionError())); connect(&d->process, &SshRemoteProcessRunner::connectionError,
connect(&d->process, SIGNAL(processClosed(int)), SLOT(handleListProcessFinished(int))); this, &SshDeviceProcessList::handleConnectionError);
connect(&d->process, &SshRemoteProcessRunner::processClosed,
this, &SshDeviceProcessList::handleListProcessFinished);
d->process.run(listProcessesCommandLine().toUtf8(), device()->sshParameters()); d->process.run(listProcessesCommandLine().toUtf8(), device()->sshParameters());
} }
@@ -62,8 +64,8 @@ void SshDeviceProcessList::doKillProcess(const DeviceProcessItem &process)
{ {
d->signalOperation = device()->signalOperation(); d->signalOperation = device()->signalOperation();
QTC_ASSERT(d->signalOperation, return); QTC_ASSERT(d->signalOperation, return);
connect(d->signalOperation.data(), SIGNAL(finished(QString)), connect(d->signalOperation.data(), &DeviceProcessSignalOperation::finished,
SLOT(handleKillProcessFinished(QString))); this, &SshDeviceProcessList::handleKillProcessFinished);
d->signalOperation->killProcess(process.pid); d->signalOperation->killProcess(process.pid);
} }

View File

@@ -37,12 +37,11 @@ public:
explicit SshDeviceProcessList(const IDevice::ConstPtr &device, QObject *parent = 0); explicit SshDeviceProcessList(const IDevice::ConstPtr &device, QObject *parent = 0);
~SshDeviceProcessList(); ~SshDeviceProcessList();
private slots: private:
void handleConnectionError(); void handleConnectionError();
void handleListProcessFinished(int exitStatus); void handleListProcessFinished(int exitStatus);
void handleKillProcessFinished(const QString &errorString); void handleKillProcessFinished(const QString &errorString);
private:
virtual QString listProcessesCommandLine() const = 0; virtual QString listProcessesCommandLine() const = 0;
virtual QList<DeviceProcessItem> buildProcessList(const QString &listProcessesReply) const = 0; virtual QList<DeviceProcessItem> buildProcessList(const QString &listProcessesReply) const = 0;

View File

@@ -114,8 +114,8 @@ EditorConfiguration::EditorConfiguration() : d(new EditorConfigurationPrivate)
// if setCurrentDelegate is 0 values are read from *this prefs // if setCurrentDelegate is 0 values are read from *this prefs
d->m_defaultCodeStyle->setCurrentDelegate(TextEditorSettings::codeStyle()); d->m_defaultCodeStyle->setCurrentDelegate(TextEditorSettings::codeStyle());
connect(SessionManager::instance(), SIGNAL(aboutToRemoveProject(ProjectExplorer::Project*)), connect(SessionManager::instance(), &SessionManager::aboutToRemoveProject,
this, SLOT(slotAboutToRemoveProject(ProjectExplorer::Project*))); this, &EditorConfiguration::slotAboutToRemoveProject);
} }
EditorConfiguration::~EditorConfiguration() EditorConfiguration::~EditorConfiguration()
@@ -285,30 +285,31 @@ void EditorConfiguration::setUseGlobalSettings(bool use)
} }
} }
static void switchSettings_helper(const QObject *newSender, const QObject *oldSender, template<typename New, typename Old>
static void switchSettings_helper(const New *newSender, const Old *oldSender,
TextEditorWidget *widget) TextEditorWidget *widget)
{ {
QObject::disconnect(oldSender, SIGNAL(marginSettingsChanged(TextEditor::MarginSettings)), QObject::disconnect(oldSender, &Old::marginSettingsChanged,
widget, SLOT(setMarginSettings(TextEditor::MarginSettings))); widget, &TextEditorWidget::setMarginSettings);
QObject::disconnect(oldSender, SIGNAL(typingSettingsChanged(TextEditor::TypingSettings)), QObject::disconnect(oldSender, &Old::typingSettingsChanged,
widget, SLOT(setTypingSettings(TextEditor::TypingSettings))); widget, &TextEditorWidget::setTypingSettings);
QObject::disconnect(oldSender, SIGNAL(storageSettingsChanged(TextEditor::StorageSettings)), QObject::disconnect(oldSender, &Old::storageSettingsChanged,
widget, SLOT(setStorageSettings(TextEditor::StorageSettings))); widget, &TextEditorWidget::setStorageSettings);
QObject::disconnect(oldSender, SIGNAL(behaviorSettingsChanged(TextEditor::BehaviorSettings)), QObject::disconnect(oldSender, &Old::behaviorSettingsChanged,
widget, SLOT(setBehaviorSettings(TextEditor::BehaviorSettings))); widget, &TextEditorWidget::setBehaviorSettings);
QObject::disconnect(oldSender, SIGNAL(extraEncodingSettingsChanged(TextEditor::ExtraEncodingSettings)), QObject::disconnect(oldSender, &Old::extraEncodingSettingsChanged,
widget, SLOT(setExtraEncodingSettings(TextEditor::ExtraEncodingSettings))); widget, &TextEditorWidget::setExtraEncodingSettings);
QObject::connect(newSender, SIGNAL(marginSettingsChanged(TextEditor::MarginSettings)), QObject::connect(newSender, &New::marginSettingsChanged,
widget, SLOT(setMarginSettings(TextEditor::MarginSettings))); widget, &TextEditorWidget::setMarginSettings);
QObject::connect(newSender, SIGNAL(typingSettingsChanged(TextEditor::TypingSettings)), QObject::connect(newSender, &New::typingSettingsChanged,
widget, SLOT(setTypingSettings(TextEditor::TypingSettings))); widget, &TextEditorWidget::setTypingSettings);
QObject::connect(newSender, SIGNAL(storageSettingsChanged(TextEditor::StorageSettings)), QObject::connect(newSender, &New::storageSettingsChanged,
widget, SLOT(setStorageSettings(TextEditor::StorageSettings))); widget, &TextEditorWidget::setStorageSettings);
QObject::connect(newSender, SIGNAL(behaviorSettingsChanged(TextEditor::BehaviorSettings)), QObject::connect(newSender, &New::behaviorSettingsChanged,
widget, SLOT(setBehaviorSettings(TextEditor::BehaviorSettings))); widget, &TextEditorWidget::setBehaviorSettings);
QObject::connect(newSender, SIGNAL(extraEncodingSettingsChanged(TextEditor::ExtraEncodingSettings)), QObject::connect(newSender, &New::extraEncodingSettingsChanged,
widget, SLOT(setExtraEncodingSettings(TextEditor::ExtraEncodingSettings))); widget, &TextEditorWidget::setExtraEncodingSettings);
} }
void EditorConfiguration::switchSettings(TextEditorWidget *widget) const void EditorConfiguration::switchSettings(TextEditorWidget *widget) const

View File

@@ -85,15 +85,6 @@ public:
QVariantMap toMap() const; QVariantMap toMap() const;
void fromMap(const QVariantMap &map); void fromMap(const QVariantMap &map);
signals:
void typingSettingsChanged(const TextEditor::TypingSettings &);
void storageSettingsChanged(const TextEditor::StorageSettings &);
void behaviorSettingsChanged(const TextEditor::BehaviorSettings &);
void extraEncodingSettingsChanged(const TextEditor::ExtraEncodingSettings &);
void marginSettingsChanged(const TextEditor::MarginSettings &);
private slots:
void setTypingSettings(const TextEditor::TypingSettings &settings); void setTypingSettings(const TextEditor::TypingSettings &settings);
void setStorageSettings(const TextEditor::StorageSettings &settings); void setStorageSettings(const TextEditor::StorageSettings &settings);
void setBehaviorSettings(const TextEditor::BehaviorSettings &settings); void setBehaviorSettings(const TextEditor::BehaviorSettings &settings);
@@ -106,6 +97,14 @@ private slots:
void setTextCodec(QTextCodec *textCodec); void setTextCodec(QTextCodec *textCodec);
void slotAboutToRemoveProject(ProjectExplorer::Project *project); void slotAboutToRemoveProject(ProjectExplorer::Project *project);
signals:
void typingSettingsChanged(const TextEditor::TypingSettings &);
void storageSettingsChanged(const TextEditor::StorageSettings &);
void behaviorSettingsChanged(const TextEditor::BehaviorSettings &);
void extraEncodingSettingsChanged(const TextEditor::ExtraEncodingSettings &);
void marginSettingsChanged(const TextEditor::MarginSettings &);
private: private:
void switchSettings(TextEditor::TextEditorWidget *baseTextEditor) const; void switchSettings(TextEditor::TextEditorWidget *baseTextEditor) const;

View File

@@ -42,23 +42,27 @@ EditorSettingsWidget::EditorSettingsWidget(Project *project) : QWidget(), m_proj
globalSettingsActivated(config->useGlobalSettings() ? 0 : 1); globalSettingsActivated(config->useGlobalSettings() ? 0 : 1);
connect(m_ui.globalSelector, SIGNAL(activated(int)),
this, SLOT(globalSettingsActivated(int)));
connect(m_ui.restoreButton, SIGNAL(clicked()), this, SLOT(restoreDefaultValues()));
connect(m_ui.showWrapColumn, SIGNAL(toggled(bool)), config, SLOT(setShowWrapColumn(bool))); connect(m_ui.globalSelector, static_cast<void (QComboBox::*)(int)>(&QComboBox::activated),
connect(m_ui.wrapColumn, SIGNAL(valueChanged(int)), config, SLOT(setWrapColumn(int))); this, &EditorSettingsWidget::globalSettingsActivated);
connect(m_ui.restoreButton, &QAbstractButton::clicked,
this, &EditorSettingsWidget::restoreDefaultValues);
connect(m_ui.behaviorSettingsWidget, SIGNAL(typingSettingsChanged(TextEditor::TypingSettings)), connect(m_ui.showWrapColumn, &QAbstractButton::toggled,
config, SLOT(setTypingSettings(TextEditor::TypingSettings))); config, &EditorConfiguration::setShowWrapColumn);
connect(m_ui.behaviorSettingsWidget, SIGNAL(storageSettingsChanged(TextEditor::StorageSettings)), connect(m_ui.wrapColumn, static_cast<void (QSpinBox::*)(int)>(&QSpinBox::valueChanged),
config, SLOT(setStorageSettings(TextEditor::StorageSettings))); config, &EditorConfiguration::setWrapColumn);
connect(m_ui.behaviorSettingsWidget, SIGNAL(behaviorSettingsChanged(TextEditor::BehaviorSettings)),
config, SLOT(setBehaviorSettings(TextEditor::BehaviorSettings))); connect(m_ui.behaviorSettingsWidget, &TextEditor::BehaviorSettingsWidget::typingSettingsChanged,
connect(m_ui.behaviorSettingsWidget, SIGNAL(extraEncodingSettingsChanged(TextEditor::ExtraEncodingSettings)), config, &EditorConfiguration::setTypingSettings);
config, SLOT(setExtraEncodingSettings(TextEditor::ExtraEncodingSettings))); connect(m_ui.behaviorSettingsWidget, &TextEditor::BehaviorSettingsWidget::storageSettingsChanged,
connect(m_ui.behaviorSettingsWidget, SIGNAL(textCodecChanged(QTextCodec*)), config, &EditorConfiguration::setStorageSettings);
config, SLOT(setTextCodec(QTextCodec*))); connect(m_ui.behaviorSettingsWidget, &TextEditor::BehaviorSettingsWidget::behaviorSettingsChanged,
config, &EditorConfiguration::setBehaviorSettings);
connect(m_ui.behaviorSettingsWidget, &TextEditor::BehaviorSettingsWidget::extraEncodingSettingsChanged,
config, &EditorConfiguration::setExtraEncodingSettings);
connect(m_ui.behaviorSettingsWidget, &TextEditor::BehaviorSettingsWidget::textCodecChanged,
config, &EditorConfiguration::setTextCodec);
} }
void EditorSettingsWidget::settingsToUi(const EditorConfiguration *config) void EditorSettingsWidget::settingsToUi(const EditorConfiguration *config)

View File

@@ -40,11 +40,10 @@ class EditorSettingsWidget : public QWidget
public: public:
EditorSettingsWidget(Project *project); EditorSettingsWidget(Project *project);
private slots: private:
void globalSettingsActivated(int index); void globalSettingsActivated(int index);
void restoreDefaultValues(); void restoreDefaultValues();
private:
void settingsToUi(const EditorConfiguration *config); void settingsToUi(const EditorConfiguration *config);
Ui::EditorSettingsPropertiesPage m_ui; Ui::EditorSettingsPropertiesPage m_ui;

View File

@@ -73,8 +73,8 @@ EnvironmentAspectWidget::EnvironmentAspectWidget(EnvironmentAspect *aspect, QWid
if (m_baseEnvironmentComboBox->count() == 1) if (m_baseEnvironmentComboBox->count() == 1)
m_baseEnvironmentComboBox->setEnabled(false); m_baseEnvironmentComboBox->setEnabled(false);
connect(m_baseEnvironmentComboBox, SIGNAL(currentIndexChanged(int)), connect(m_baseEnvironmentComboBox, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
this, SLOT(baseEnvironmentSelected(int))); this, &EnvironmentAspectWidget::baseEnvironmentSelected);
baseLayout->addWidget(m_baseEnvironmentComboBox); baseLayout->addWidget(m_baseEnvironmentComboBox);
baseLayout->addStretch(10); baseLayout->addStretch(10);
@@ -88,14 +88,15 @@ EnvironmentAspectWidget::EnvironmentAspectWidget(EnvironmentAspect *aspect, QWid
m_environmentWidget->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding); m_environmentWidget->setSizePolicy(QSizePolicy::Expanding, QSizePolicy::Expanding);
topLayout->addWidget(m_environmentWidget); topLayout->addWidget(m_environmentWidget);
connect(m_environmentWidget, SIGNAL(userChangesChanged()), connect(m_environmentWidget, &EnvironmentWidget::userChangesChanged,
this, SLOT(userChangesEdited())); this, &EnvironmentAspectWidget::userChangesEdited);
connect(m_aspect, SIGNAL(baseEnvironmentChanged()), this, SLOT(changeBaseEnvironment())); connect(m_aspect, &EnvironmentAspect::baseEnvironmentChanged,
connect(m_aspect, SIGNAL(userEnvironmentChangesChanged(QList<Utils::EnvironmentItem>)), this, &EnvironmentAspectWidget::changeBaseEnvironment);
this, SLOT(changeUserChanges(QList<Utils::EnvironmentItem>))); connect(m_aspect, &EnvironmentAspect::userEnvironmentChangesChanged,
connect(m_aspect, SIGNAL(environmentChanged()), this, &EnvironmentAspectWidget::changeUserChanges);
this, SLOT(environmentChanged())); connect(m_aspect, &EnvironmentAspect::environmentChanged,
this, &EnvironmentAspectWidget::environmentChanged);
} }
QString EnvironmentAspectWidget::displayName() const QString EnvironmentAspectWidget::displayName() const

View File

@@ -58,14 +58,13 @@ public:
QWidget *additionalWidget() const; QWidget *additionalWidget() const;
private slots: private:
void baseEnvironmentSelected(int idx); void baseEnvironmentSelected(int idx);
void changeBaseEnvironment(); void changeBaseEnvironment();
void userChangesEdited(); void userChangesEdited();
void changeUserChanges(QList<Utils::EnvironmentItem> changes); void changeUserChanges(QList<Utils::EnvironmentItem> changes);
void environmentChanged(); void environmentChanged();
private:
EnvironmentAspect *m_aspect; EnvironmentAspect *m_aspect;
bool m_ignoreChange; bool m_ignoreChange;

View File

@@ -106,8 +106,8 @@ EnvironmentItemsDialog::EnvironmentItemsDialog(QWidget *parent) :
d->m_editor = new EnvironmentItemsWidget(this); d->m_editor = new EnvironmentItemsWidget(this);
QDialogButtonBox *box = new QDialogButtonBox( QDialogButtonBox *box = new QDialogButtonBox(
QDialogButtonBox::Ok | QDialogButtonBox::Cancel, Qt::Horizontal, this); QDialogButtonBox::Ok | QDialogButtonBox::Cancel, Qt::Horizontal, this);
connect(box, SIGNAL(accepted()), this, SLOT(accept())); connect(box, &QDialogButtonBox::accepted, this, &QDialog::accept);
connect(box, SIGNAL(rejected()), this, SLOT(reject())); connect(box, &QDialogButtonBox::rejected, this, &QDialog::reject);
QVBoxLayout *layout = new QVBoxLayout(this); QVBoxLayout *layout = new QVBoxLayout(this);
layout->addWidget(d->m_editor); layout->addWidget(d->m_editor);
layout->addWidget(box); layout->addWidget(box);

View File

@@ -135,13 +135,13 @@ EnvironmentWidget::EnvironmentWidget(QWidget *parent, QWidget *additionalDetails
: QWidget(parent), d(new EnvironmentWidgetPrivate) : QWidget(parent), d(new EnvironmentWidgetPrivate)
{ {
d->m_model = new Utils::EnvironmentModel(); d->m_model = new Utils::EnvironmentModel();
connect(d->m_model, SIGNAL(userChangesChanged()), connect(d->m_model, &Utils::EnvironmentModel::userChangesChanged,
this, SIGNAL(userChangesChanged())); this, &EnvironmentWidget::userChangesChanged);
connect(d->m_model, SIGNAL(modelReset()), connect(d->m_model, &QAbstractItemModel::modelReset,
this, SLOT(invalidateCurrentIndex())); this, &EnvironmentWidget::invalidateCurrentIndex);
connect(d->m_model, SIGNAL(focusIndex(QModelIndex)), connect(d->m_model, &Utils::EnvironmentModel::focusIndex,
this, SLOT(focusIndex(QModelIndex))); this, &EnvironmentWidget::focusIndex);
QVBoxLayout *vbox = new QVBoxLayout(this); QVBoxLayout *vbox = new QVBoxLayout(this);
vbox->setContentsMargins(0, 0, 0, 0); vbox->setContentsMargins(0, 0, 0, 0);
@@ -205,26 +205,27 @@ EnvironmentWidget::EnvironmentWidget(QWidget *parent, QWidget *additionalDetails
vbox->addWidget(d->m_detailsContainer); vbox->addWidget(d->m_detailsContainer);
connect(d->m_model, SIGNAL(dataChanged(QModelIndex,QModelIndex)), connect(d->m_model, &QAbstractItemModel::dataChanged,
this, SLOT(updateButtons())); this, &EnvironmentWidget::updateButtons);
connect(d->m_editButton, SIGNAL(clicked(bool)), connect(d->m_editButton, &QAbstractButton::clicked,
this, SLOT(editEnvironmentButtonClicked())); this, &EnvironmentWidget::editEnvironmentButtonClicked);
connect(d->m_addButton, SIGNAL(clicked(bool)), connect(d->m_addButton, &QAbstractButton::clicked,
this, SLOT(addEnvironmentButtonClicked())); this, &EnvironmentWidget::addEnvironmentButtonClicked);
connect(d->m_resetButton, SIGNAL(clicked(bool)), connect(d->m_resetButton, &QAbstractButton::clicked,
this, SLOT(removeEnvironmentButtonClicked())); this, &EnvironmentWidget::removeEnvironmentButtonClicked);
connect(d->m_unsetButton, SIGNAL(clicked(bool)), connect(d->m_unsetButton, &QAbstractButton::clicked,
this, SLOT(unsetEnvironmentButtonClicked())); this, &EnvironmentWidget::unsetEnvironmentButtonClicked);
connect(d->m_batchEditButton, SIGNAL(clicked(bool)), connect(d->m_batchEditButton, &QAbstractButton::clicked,
this, SLOT(batchEditEnvironmentButtonClicked())); this, &EnvironmentWidget::batchEditEnvironmentButtonClicked);
connect(d->m_environmentView->selectionModel(), SIGNAL(currentChanged(QModelIndex,QModelIndex)), connect(d->m_environmentView->selectionModel(), &QItemSelectionModel::currentChanged,
this, SLOT(environmentCurrentIndexChanged(QModelIndex))); this, &EnvironmentWidget::environmentCurrentIndexChanged);
connect(d->m_detailsContainer, SIGNAL(linkActivated(QString)), connect(d->m_detailsContainer, &Utils::DetailsWidget::linkActivated,
this, SLOT(linkActivated(QString))); this, &EnvironmentWidget::linkActivated);
connect(d->m_model, SIGNAL(userChangesChanged()), this, SLOT(updateSummaryText())); connect(d->m_model, &Utils::EnvironmentModel::userChangesChanged,
this, &EnvironmentWidget::updateSummaryText);
} }
EnvironmentWidget::~EnvironmentWidget() EnvironmentWidget::~EnvironmentWidget()

View File

@@ -70,7 +70,7 @@ signals:
void userChangesChanged(); void userChangesChanged();
void detailsVisibleChanged(bool visible); void detailsVisibleChanged(bool visible);
private slots: private:
void editEnvironmentButtonClicked(); void editEnvironmentButtonClicked();
void addEnvironmentButtonClicked(); void addEnvironmentButtonClicked();
void removeEnvironmentButtonClicked(); void removeEnvironmentButtonClicked();
@@ -83,7 +83,6 @@ private slots:
void updateButtons(); void updateButtons();
void linkActivated(const QString &link); void linkActivated(const QString &link);
private:
EnvironmentWidgetPrivate *d; EnvironmentWidgetPrivate *d;
}; };

View File

@@ -168,12 +168,14 @@ FolderNavigationWidget::FolderNavigationWidget(QWidget *parent)
setAutoSynchronization(true); setAutoSynchronization(true);
// connections // connections
connect(m_listView, SIGNAL(activated(QModelIndex)), connect(m_listView, &QAbstractItemView::activated,
this, SLOT(slotOpenItem(QModelIndex))); this, &FolderNavigationWidget::slotOpenItem);
connect(m_filterHiddenFilesAction, SIGNAL(toggled(bool)), this, SLOT(setHiddenFilesFilter(bool))); connect(m_filterHiddenFilesAction, &QAction::toggled,
connect(m_toggleSync, SIGNAL(clicked(bool)), this, SLOT(toggleAutoSynchronization())); this, &FolderNavigationWidget::setHiddenFilesFilter);
connect(m_filterModel, SIGNAL(layoutChanged()), connect(m_toggleSync, &QAbstractButton::clicked,
this, SLOT(ensureCurrentIndex())); this, &FolderNavigationWidget::toggleAutoSynchronization);
connect(m_filterModel, &QAbstractItemModel::layoutChanged,
this, &FolderNavigationWidget::ensureCurrentIndex);
} }
void FolderNavigationWidget::toggleAutoSynchronization() void FolderNavigationWidget::toggleAutoSynchronization()

View File

@@ -58,7 +58,7 @@ public slots:
void setAutoSynchronization(bool sync); void setAutoSynchronization(bool sync);
void toggleAutoSynchronization(); void toggleAutoSynchronization();
private slots: private:
void setCurrentFile(Core::IEditor *editor); void setCurrentFile(Core::IEditor *editor);
void slotOpenItem(const QModelIndex &viewIndex); void slotOpenItem(const QModelIndex &viewIndex);
void setHiddenFilesFilter(bool filter); void setHiddenFilesFilter(bool filter);

View File

@@ -882,10 +882,13 @@ GccToolChainConfigWidget::GccToolChainConfigWidget(GccToolChain *tc) :
setFromToolchain(); setFromToolchain();
connect(m_compilerCommand, SIGNAL(rawPathChanged(QString)), this, SLOT(handleCompilerCommandChange())); connect(m_compilerCommand, &PathChooser::rawPathChanged,
connect(m_platformCodeGenFlagsLineEdit, SIGNAL(editingFinished()), this, SLOT(handlePlatformCodeGenFlagsChange())); this, &GccToolChainConfigWidget::handleCompilerCommandChange);
connect(m_platformLinkerFlagsLineEdit, SIGNAL(editingFinished()), this, SLOT(handlePlatformLinkerFlagsChange())); connect(m_platformCodeGenFlagsLineEdit, &QLineEdit::editingFinished,
connect(m_abiWidget, SIGNAL(abiChanged()), this, SIGNAL(dirty())); this, &GccToolChainConfigWidget::handlePlatformCodeGenFlagsChange);
connect(m_platformLinkerFlagsLineEdit, &QLineEdit::editingFinished,
this, &GccToolChainConfigWidget::handlePlatformLinkerFlagsChange);
connect(m_abiWidget, &AbiWidget::abiChanged, this, &ToolChainConfigWidget::dirty);
} }
void GccToolChainConfigWidget::applyImpl() void GccToolChainConfigWidget::applyImpl()

View File

@@ -77,12 +77,12 @@ class GccToolChainConfigWidget : public ToolChainConfigWidget
public: public:
GccToolChainConfigWidget(GccToolChain *); GccToolChainConfigWidget(GccToolChain *);
static QStringList splitString(const QString &s); static QStringList splitString(const QString &s);
private slots:
private:
void handleCompilerCommandChange(); void handleCompilerCommandChange();
void handlePlatformCodeGenFlagsChange(); void handlePlatformCodeGenFlagsChange();
void handlePlatformLinkerFlagsChange(); void handlePlatformLinkerFlagsChange();
private:
void applyImpl(); void applyImpl();
void discardImpl() { setFromToolchain(); } void discardImpl() { setFromToolchain(); }
bool isDirtyImpl() const; bool isDirtyImpl() const;

View File

@@ -405,8 +405,8 @@ void ProjectExplorerPlugin::testGnuMakeParserParsing()
OutputParserTester testbench; OutputParserTester testbench;
GnuMakeParser *childParser = new GnuMakeParser; GnuMakeParser *childParser = new GnuMakeParser;
GnuMakeParserTester *tester = new GnuMakeParserTester(childParser); GnuMakeParserTester *tester = new GnuMakeParserTester(childParser);
connect(&testbench, SIGNAL(aboutToDeleteParser()), connect(&testbench, &OutputParserTester::aboutToDeleteParser,
tester, SLOT(parserIsAboutToBeDeleted())); tester, &GnuMakeParserTester::parserIsAboutToBeDeleted);
testbench.appendOutputParser(childParser); testbench.appendOutputParser(childParser);
QFETCH(QStringList, extraSearchDirs); QFETCH(QStringList, extraSearchDirs);

View File

@@ -49,7 +49,6 @@ public:
bool hasFatalErrors() const; bool hasFatalErrors() const;
public slots:
void taskAdded(const ProjectExplorer::Task &task, int linkedLines, int skippedLines); void taskAdded(const ProjectExplorer::Task &task, int linkedLines, int skippedLines);
private: private:
@@ -78,12 +77,10 @@ class GnuMakeParserTester : public QObject
public: public:
explicit GnuMakeParserTester(GnuMakeParser *parser, QObject *parent = 0); explicit GnuMakeParserTester(GnuMakeParser *parser, QObject *parent = 0);
void parserIsAboutToBeDeleted();
QStringList directories; QStringList directories;
GnuMakeParser *parser; GnuMakeParser *parser;
public slots:
void parserIsAboutToBeDeleted();
}; };
#endif #endif

View File

@@ -59,7 +59,7 @@ ImportWidget::ImportWidget(QWidget *parent) :
QPushButton *importButton = new QPushButton(tr("Import"), widget); QPushButton *importButton = new QPushButton(tr("Import"), widget);
layout->addWidget(importButton); layout->addWidget(importButton);
connect(importButton, SIGNAL(clicked()), this, SLOT(handleImportRequest())); connect(importButton, &QAbstractButton::clicked, this, &ImportWidget::handleImportRequest);
detailsWidget->setWidget(widget); detailsWidget->setWidget(widget);
} }

View File

@@ -49,10 +49,9 @@ public:
signals: signals:
void importFrom(const Utils::FileName &dir); void importFrom(const Utils::FileName &dir);
private slots: private:
void handleImportRequest(); void handleImportRequest();
private:
Utils::PathChooser *m_pathChooser; Utils::PathChooser *m_pathChooser;
}; };

View File

@@ -138,8 +138,10 @@ void IOutputParser::appendOutputParser(IOutputParser *parser)
} }
m_parser = parser; m_parser = parser;
connect(parser, &IOutputParser::addOutput, this, &IOutputParser::outputAdded, Qt::DirectConnection); connect(parser, &IOutputParser::addOutput,
connect(parser, &IOutputParser::addTask, this, &IOutputParser::taskAdded, Qt::DirectConnection); this, &IOutputParser::outputAdded, Qt::DirectConnection);
connect(parser, &IOutputParser::addTask,
this, &IOutputParser::taskAdded, Qt::DirectConnection);
} }
IOutputParser *IOutputParser::takeOutputParserChain() IOutputParser *IOutputParser::takeOutputParserChain()
@@ -161,8 +163,10 @@ void IOutputParser::setChildParser(IOutputParser *parser)
if (m_parser != parser) if (m_parser != parser)
delete m_parser; delete m_parser;
m_parser = parser; m_parser = parser;
connect(parser, &IOutputParser::addOutput, this, &IOutputParser::outputAdded, Qt::DirectConnection); connect(parser, &IOutputParser::addOutput,
connect(parser, &IOutputParser::addTask, this, &IOutputParser::taskAdded, Qt::DirectConnection); this, &IOutputParser::outputAdded, Qt::DirectConnection);
connect(parser, &IOutputParser::addTask,
this, &IOutputParser::taskAdded, Qt::DirectConnection);
} }
void IOutputParser::stdOutput(const QString &line) void IOutputParser::stdOutput(const QString &line)

View File

@@ -197,7 +197,8 @@ JournaldWatcher::JournaldWatcher()
if (!d->setup()) if (!d->setup())
d->teardown(); d->teardown();
else else
connect(d->m_notifier, &QSocketNotifier::activated, m_instance, &JournaldWatcher::handleEntry); connect(d->m_notifier, &QSocketNotifier::activated,
m_instance, &JournaldWatcher::handleEntry);
m_instance->handleEntry(); // advance to the end of file... m_instance->handleEntry(); // advance to the end of file...
} }

View File

@@ -62,10 +62,9 @@ public:
static QVector<ConditionalFeature> parseFeatures(const QVariant &data, static QVector<ConditionalFeature> parseFeatures(const QVariant &data,
QString *errorMessage = 0); QString *errorMessage = 0);
private slots: private:
void setupProjectFiles(const JsonWizard::GeneratorFiles &files); void setupProjectFiles(const JsonWizard::GeneratorFiles &files);
private:
QString m_unexpandedProjectPath; QString m_unexpandedProjectPath;
QVector<ConditionalFeature> m_requiredFeatures; QVector<ConditionalFeature> m_requiredFeatures;

View File

@@ -114,11 +114,10 @@ public slots:
void accept() override; void accept() override;
void reject() override; void reject() override;
private slots: private:
void handleNewPages(int pageId); void handleNewPages(int pageId);
void handleError(const QString &message); void handleError(const QString &message);
private:
QString stringify(const QVariant &v) const override; QString stringify(const QVariant &v) const override;
QString evaluate(const QVariant &v) const override ; QString evaluate(const QVariant &v) const override ;
void openFiles(const GeneratorFiles &files); void openFiles(const GeneratorFiles &files);

View File

@@ -57,10 +57,12 @@ KitChooser::KitChooser(QWidget *parent) :
layout->addWidget(m_manageButton); layout->addWidget(m_manageButton);
setFocusProxy(m_manageButton); setFocusProxy(m_manageButton);
connect(m_chooser, SIGNAL(currentIndexChanged(int)), SLOT(onCurrentIndexChanged(int))); connect(m_chooser, static_cast<void (QComboBox::*)(int)>(&QComboBox::currentIndexChanged),
connect(m_chooser, SIGNAL(activated(int)), SIGNAL(activated(int))); this, &KitChooser::onCurrentIndexChanged);
connect(m_manageButton, SIGNAL(clicked()), SLOT(onManageButtonClicked())); connect(m_chooser, static_cast<void (QComboBox::*)(int)>(&QComboBox::activated),
connect(KitManager::instance(), SIGNAL(kitsChanged()), SLOT(populate())); this, &KitChooser::activated);
connect(m_manageButton, &QAbstractButton::clicked, this, &KitChooser::onManageButtonClicked);
connect(KitManager::instance(), &KitManager::kitsChanged, this, &KitChooser::populate);
} }
void KitChooser::onManageButtonClicked() void KitChooser::onManageButtonClicked()

View File

@@ -66,17 +66,16 @@ signals:
public slots: public slots:
void populate(); void populate();
private slots:
void onCurrentIndexChanged(int index);
void onManageButtonClicked();
protected: protected:
virtual QString kitText(const Kit *k) const; virtual QString kitText(const Kit *k) const;
virtual QString kitToolTip(Kit *k) const; virtual QString kitToolTip(Kit *k) const;
private: private:
KitMatcher m_kitMatcher; void onCurrentIndexChanged(int index);
void onManageButtonClicked();
Kit *kitAt(int index) const; Kit *kitAt(int index) const;
KitMatcher m_kitMatcher;
QComboBox *m_chooser; QComboBox *m_chooser;
QPushButton *m_manageButton; QPushButton *m_manageButton;
}; };

View File

@@ -118,8 +118,8 @@ ToolChainKitInformation::ToolChainKitInformation()
setId(ToolChainKitInformation::id()); setId(ToolChainKitInformation::id());
setPriority(30000); setPriority(30000);
connect(KitManager::instance(), SIGNAL(kitsLoaded()), connect(KitManager::instance(), &KitManager::kitsLoaded,
this, SLOT(kitsWereLoaded())); this, &ToolChainKitInformation::kitsWereLoaded);
} }
QVariant ToolChainKitInformation::defaultValue(Kit *k) const QVariant ToolChainKitInformation::defaultValue(Kit *k) const
@@ -251,10 +251,10 @@ void ToolChainKitInformation::kitsWereLoaded()
foreach (Kit *k, KitManager::kits()) foreach (Kit *k, KitManager::kits())
fix(k); fix(k);
connect(ToolChainManager::instance(), SIGNAL(toolChainRemoved(ProjectExplorer::ToolChain*)), connect(ToolChainManager::instance(), &ToolChainManager::toolChainRemoved,
this, SLOT(toolChainRemoved(ProjectExplorer::ToolChain*))); this, &ToolChainKitInformation::toolChainRemoved);
connect(ToolChainManager::instance(), SIGNAL(toolChainUpdated(ProjectExplorer::ToolChain*)), connect(ToolChainManager::instance(), &ToolChainManager::toolChainUpdated,
this, SLOT(toolChainUpdated(ProjectExplorer::ToolChain*))); this, &ToolChainKitInformation::toolChainUpdated);
} }
void ToolChainKitInformation::toolChainUpdated(ToolChain *tc) void ToolChainKitInformation::toolChainUpdated(ToolChain *tc)
@@ -360,8 +360,8 @@ DeviceKitInformation::DeviceKitInformation()
setId(DeviceKitInformation::id()); setId(DeviceKitInformation::id());
setPriority(32000); setPriority(32000);
connect(KitManager::instance(), SIGNAL(kitsLoaded()), connect(KitManager::instance(), &KitManager::kitsLoaded,
this, SLOT(kitsWereLoaded())); this, &DeviceKitInformation::kitsWereLoaded);
} }
QVariant DeviceKitInformation::defaultValue(Kit *k) const QVariant DeviceKitInformation::defaultValue(Kit *k) const
@@ -488,15 +488,15 @@ void DeviceKitInformation::kitsWereLoaded()
fix(k); fix(k);
DeviceManager *dm = DeviceManager::instance(); DeviceManager *dm = DeviceManager::instance();
connect(dm, SIGNAL(deviceListReplaced()), this, SLOT(devicesChanged())); connect(dm, &DeviceManager::deviceListReplaced, this, &DeviceKitInformation::devicesChanged);
connect(dm, SIGNAL(deviceAdded(Core::Id)), this, SLOT(devicesChanged())); connect(dm, &DeviceManager::deviceAdded, this, &DeviceKitInformation::devicesChanged);
connect(dm, SIGNAL(deviceRemoved(Core::Id)), this, SLOT(devicesChanged())); connect(dm, &DeviceManager::deviceRemoved, this, &DeviceKitInformation::devicesChanged);
connect(dm, SIGNAL(deviceUpdated(Core::Id)), this, SLOT(deviceUpdated(Core::Id))); connect(dm, &DeviceManager::deviceUpdated, this, &DeviceKitInformation::deviceUpdated);
connect(KitManager::instance(), SIGNAL(kitUpdated(ProjectExplorer::Kit*)), connect(KitManager::instance(), &KitManager::kitUpdated,
this, SLOT(kitUpdated(ProjectExplorer::Kit*))); this, &DeviceKitInformation::kitUpdated);
connect(KitManager::instance(), SIGNAL(unmanagedKitUpdated(ProjectExplorer::Kit*)), connect(KitManager::instance(), &KitManager::unmanagedKitUpdated,
this, SLOT(kitUpdated(ProjectExplorer::Kit*))); this, &DeviceKitInformation::kitUpdated);
} }
void DeviceKitInformation::deviceUpdated(Core::Id id) void DeviceKitInformation::deviceUpdated(Core::Id id)

View File

@@ -97,7 +97,7 @@ public:
static QString msgNoToolChainInTarget(); static QString msgNoToolChainInTarget();
private slots: private:
void kitsWereLoaded(); void kitsWereLoaded();
void toolChainUpdated(ProjectExplorer::ToolChain *tc); void toolChainUpdated(ProjectExplorer::ToolChain *tc);
void toolChainRemoved(ProjectExplorer::ToolChain *tc); void toolChainRemoved(ProjectExplorer::ToolChain *tc);
@@ -163,7 +163,7 @@ public:
static void setDevice(Kit *k, IDevice::ConstPtr dev); static void setDevice(Kit *k, IDevice::ConstPtr dev);
static void setDeviceId(Kit *k, Core::Id dataId); static void setDeviceId(Kit *k, Core::Id dataId);
private slots: private:
void kitsWereLoaded(); void kitsWereLoaded();
void deviceUpdated(Core::Id dataId); void deviceUpdated(Core::Id dataId);
void devicesChanged(); void devicesChanged();

View File

@@ -151,8 +151,7 @@ public:
static QList<Kit *> sortKits(const QList<Kit *> kits); // Avoid sorting whenever possible! static QList<Kit *> sortKits(const QList<Kit *> kits); // Avoid sorting whenever possible!
public slots: static void saveKits();
void saveKits();
signals: signals:
void kitAdded(ProjectExplorer::Kit *); void kitAdded(ProjectExplorer::Kit *);

View File

@@ -83,7 +83,8 @@ KitManagerConfigWidget::KitManagerConfigWidget(Kit *k) :
Q_ASSERT(fileSystemFriendlyNameRegexp.isValid()); Q_ASSERT(fileSystemFriendlyNameRegexp.isValid());
m_fileSystemFriendlyNameLineEdit->setValidator(new QRegularExpressionValidator(fileSystemFriendlyNameRegexp, m_fileSystemFriendlyNameLineEdit)); m_fileSystemFriendlyNameLineEdit->setValidator(new QRegularExpressionValidator(fileSystemFriendlyNameRegexp, m_fileSystemFriendlyNameLineEdit));
m_layout->addWidget(m_fileSystemFriendlyNameLineEdit, 1, WidgetColumn); m_layout->addWidget(m_fileSystemFriendlyNameLineEdit, 1, WidgetColumn);
connect(m_fileSystemFriendlyNameLineEdit, &QLineEdit::textChanged, this, &KitManagerConfigWidget::setFileSystemFriendlyName); connect(m_fileSystemFriendlyNameLineEdit, &QLineEdit::textChanged,
this, &KitManagerConfigWidget::setFileSystemFriendlyName);
QWidget *inner = new QWidget; QWidget *inner = new QWidget;
inner->setLayout(m_layout); inner->setLayout(m_layout);

View File

@@ -74,14 +74,13 @@ signals:
void dirty(); void dirty();
void isAutoDetectedChanged(); void isAutoDetectedChanged();
private slots: private:
void setIcon(); void setIcon();
void setDisplayName(); void setDisplayName();
void setFileSystemFriendlyName(); void setFileSystemFriendlyName();
void workingCopyWasUpdated(ProjectExplorer::Kit *k); void workingCopyWasUpdated(ProjectExplorer::Kit *k);
void kitWasUpdated(ProjectExplorer::Kit *k); void kitWasUpdated(ProjectExplorer::Kit *k);
private:
enum LayoutColumns { enum LayoutColumns {
LabelColumn, LabelColumn,
WidgetColumn, WidgetColumn,

View File

@@ -43,7 +43,6 @@ public:
QString baseEnvironmentDisplayName(int base) const; QString baseEnvironmentDisplayName(int base) const;
Utils::Environment baseEnvironment() const; Utils::Environment baseEnvironment() const;
public slots:
void buildEnvironmentHasChanged(); void buildEnvironmentHasChanged();
private: private:

View File

@@ -230,17 +230,17 @@ int ListWidget::padding()
ProjectListWidget::ProjectListWidget(QWidget *parent) ProjectListWidget::ProjectListWidget(QWidget *parent)
: ListWidget(parent), m_ignoreIndexChange(false) : ListWidget(parent), m_ignoreIndexChange(false)
{ {
QObject *sessionManager = SessionManager::instance(); SessionManager *sessionManager = SessionManager::instance();
connect(sessionManager, SIGNAL(projectAdded(ProjectExplorer::Project*)), connect(sessionManager, &SessionManager::projectAdded,
this, SLOT(addProject(ProjectExplorer::Project*))); this, &ProjectListWidget::addProject);
connect(sessionManager, SIGNAL(aboutToRemoveProject(ProjectExplorer::Project*)), connect(sessionManager, &SessionManager::aboutToRemoveProject,
this, SLOT(removeProject(ProjectExplorer::Project*))); this, &ProjectListWidget::removeProject);
connect(sessionManager, SIGNAL(startupProjectChanged(ProjectExplorer::Project*)), connect(sessionManager, &SessionManager::startupProjectChanged,
this, SLOT(changeStartupProject(ProjectExplorer::Project*))); this, &ProjectListWidget::changeStartupProject);
connect(sessionManager, SIGNAL(projectDisplayNameChanged(ProjectExplorer::Project*)), connect(sessionManager, &SessionManager::projectDisplayNameChanged,
this, SLOT(projectDisplayNameChanged(ProjectExplorer::Project*))); this, &ProjectListWidget::projectDisplayNameChanged);
connect(this, SIGNAL(currentRowChanged(int)), connect(this, &QListWidget::currentRowChanged,
this, SLOT(setProject(int))); this, &ProjectListWidget::setProject);
} }
QListWidgetItem *ProjectListWidget::itemForProject(Project *project) QListWidgetItem *ProjectListWidget::itemForProject(Project *project)
@@ -397,8 +397,8 @@ void ProjectListWidget::changeStartupProject(Project *project)
GenericListWidget::GenericListWidget(QWidget *parent) GenericListWidget::GenericListWidget(QWidget *parent)
: ListWidget(parent), m_ignoreIndexChange(false) : ListWidget(parent), m_ignoreIndexChange(false)
{ {
connect(this, SIGNAL(currentRowChanged(int)), connect(this, &QListWidget::currentRowChanged,
this, SLOT(rowChanged(int))); this, &GenericListWidget::rowChanged);
} }
void GenericListWidget::setProjectConfigurations(const QList<ProjectConfiguration *> &list, ProjectConfiguration *active) void GenericListWidget::setProjectConfigurations(const QList<ProjectConfiguration *> &list, ProjectConfiguration *active)
@@ -407,8 +407,8 @@ void GenericListWidget::setProjectConfigurations(const QList<ProjectConfiguratio
clear(); clear();
for (int i = 0; i < count(); ++i) { for (int i = 0; i < count(); ++i) {
ProjectConfiguration *p = item(i)->data(Qt::UserRole).value<ProjectConfiguration *>(); ProjectConfiguration *p = item(i)->data(Qt::UserRole).value<ProjectConfiguration *>();
disconnect(p, SIGNAL(displayNameChanged()), disconnect(p, &ProjectConfiguration::displayNameChanged,
this, SLOT(displayNameChanged())); this, &GenericListWidget::displayNameChanged);
} }
QFontMetrics fn(font()); QFontMetrics fn(font());
@@ -447,8 +447,8 @@ void GenericListWidget::addProjectConfiguration(ProjectConfiguration *pc)
} }
insertItem(pos, lwi); insertItem(pos, lwi);
connect(pc, SIGNAL(displayNameChanged()), connect(pc, &ProjectConfiguration::displayNameChanged,
this, SLOT(displayNameChanged())); this, &GenericListWidget::displayNameChanged);
QFontMetrics fn(font()); QFontMetrics fn(font());
int width = fn.width(pc->displayName()) + padding(); int width = fn.width(pc->displayName()) + padding();
@@ -460,8 +460,8 @@ void GenericListWidget::addProjectConfiguration(ProjectConfiguration *pc)
void GenericListWidget::removeProjectConfiguration(ProjectConfiguration *pc) void GenericListWidget::removeProjectConfiguration(ProjectConfiguration *pc)
{ {
m_ignoreIndexChange = true; m_ignoreIndexChange = true;
disconnect(pc, SIGNAL(displayNameChanged()), disconnect(pc, &ProjectConfiguration::displayNameChanged,
this, SLOT(displayNameChanged())); this, &GenericListWidget::displayNameChanged);
delete itemForProjectConfiguration(pc); delete itemForProjectConfiguration(pc);
QFontMetrics fn(font()); QFontMetrics fn(font());
@@ -698,32 +698,32 @@ MiniProjectTargetSelector::MiniProjectTargetSelector(QAction *targetSelectorActi
if (startup) if (startup)
activeTargetChanged(startup->activeTarget()); activeTargetChanged(startup->activeTarget());
connect(m_summaryLabel, SIGNAL(linkActivated(QString)), connect(m_summaryLabel, &QLabel::linkActivated,
this, SLOT(switchToProjectsMode())); this, &MiniProjectTargetSelector::switchToProjectsMode);
QObject *sessionManager = SessionManager::instance(); SessionManager *sessionManager = SessionManager::instance();
connect(sessionManager, SIGNAL(startupProjectChanged(ProjectExplorer::Project*)), connect(sessionManager, &SessionManager::startupProjectChanged,
this, SLOT(changeStartupProject(ProjectExplorer::Project*))); this, &MiniProjectTargetSelector::changeStartupProject);
connect(sessionManager, SIGNAL(projectAdded(ProjectExplorer::Project*)), connect(sessionManager, &SessionManager::projectAdded,
this, SLOT(projectAdded(ProjectExplorer::Project*))); this, &MiniProjectTargetSelector::projectAdded);
connect(sessionManager, SIGNAL(projectRemoved(ProjectExplorer::Project*)), connect(sessionManager, &SessionManager::projectRemoved,
this, SLOT(projectRemoved(ProjectExplorer::Project*))); this, &MiniProjectTargetSelector::projectRemoved);
connect(sessionManager, SIGNAL(projectDisplayNameChanged(ProjectExplorer::Project*)), connect(sessionManager, &SessionManager::projectDisplayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
// for icon changes: // for icon changes:
connect(ProjectExplorer::KitManager::instance(), SIGNAL(kitUpdated(ProjectExplorer::Kit*)), connect(ProjectExplorer::KitManager::instance(), &KitManager::kitUpdated,
this, SLOT(kitChanged(ProjectExplorer::Kit*))); this, &MiniProjectTargetSelector::kitChanged);
connect(m_listWidgets[TARGET], SIGNAL(changeActiveProjectConfiguration(ProjectExplorer::ProjectConfiguration*)), connect(m_listWidgets[TARGET], &GenericListWidget::changeActiveProjectConfiguration,
this, SLOT(setActiveTarget(ProjectExplorer::ProjectConfiguration*))); this, &MiniProjectTargetSelector::setActiveTarget);
connect(m_listWidgets[BUILD], SIGNAL(changeActiveProjectConfiguration(ProjectExplorer::ProjectConfiguration*)), connect(m_listWidgets[BUILD], &GenericListWidget::changeActiveProjectConfiguration,
this, SLOT(setActiveBuildConfiguration(ProjectExplorer::ProjectConfiguration*))); this, &MiniProjectTargetSelector::setActiveBuildConfiguration);
connect(m_listWidgets[DEPLOY], SIGNAL(changeActiveProjectConfiguration(ProjectExplorer::ProjectConfiguration*)), connect(m_listWidgets[DEPLOY], &GenericListWidget::changeActiveProjectConfiguration,
this, SLOT(setActiveDeployConfiguration(ProjectExplorer::ProjectConfiguration*))); this, &MiniProjectTargetSelector::setActiveDeployConfiguration);
connect(m_listWidgets[RUN], SIGNAL(changeActiveProjectConfiguration(ProjectExplorer::ProjectConfiguration*)), connect(m_listWidgets[RUN], &GenericListWidget::changeActiveProjectConfiguration,
this, SLOT(setActiveRunConfiguration(ProjectExplorer::ProjectConfiguration*))); this, &MiniProjectTargetSelector::setActiveRunConfiguration);
} }
bool MiniProjectTargetSelector::event(QEvent *event) bool MiniProjectTargetSelector::event(QEvent *event)
@@ -983,11 +983,11 @@ void MiniProjectTargetSelector::setActiveRunConfiguration(ProjectConfiguration *
void MiniProjectTargetSelector::projectAdded(Project *project) void MiniProjectTargetSelector::projectAdded(Project *project)
{ {
connect(project, SIGNAL(addedTarget(ProjectExplorer::Target*)), connect(project, &Project::addedTarget,
this, SLOT(slotAddedTarget(ProjectExplorer::Target*))); this, &MiniProjectTargetSelector::slotAddedTarget);
connect(project, SIGNAL(removedTarget(ProjectExplorer::Target*)), connect(project, &Project::removedTarget,
this, SLOT(slotRemovedTarget(ProjectExplorer::Target*))); this, &MiniProjectTargetSelector::slotRemovedTarget);
foreach (Target *t, project->targets()) foreach (Target *t, project->targets())
addedTarget(t); addedTarget(t);
@@ -1001,11 +1001,11 @@ void MiniProjectTargetSelector::projectAdded(Project *project)
void MiniProjectTargetSelector::projectRemoved(Project *project) void MiniProjectTargetSelector::projectRemoved(Project *project)
{ {
disconnect(project, SIGNAL(addedTarget(ProjectExplorer::Target*)), disconnect(project, &Project::addedTarget,
this, SLOT(slotAddedTarget(ProjectExplorer::Target*))); this, &MiniProjectTargetSelector::slotAddedTarget);
disconnect(project, SIGNAL(removedTarget(ProjectExplorer::Target*)), disconnect(project, &Project::removedTarget,
this, SLOT(slotRemovedTarget(ProjectExplorer::Target*))); this, &MiniProjectTargetSelector::slotRemovedTarget);
foreach (Target *t, project->targets()) foreach (Target *t, project->targets())
removedTarget(t); removedTarget(t);
@@ -1019,20 +1019,20 @@ void MiniProjectTargetSelector::projectRemoved(Project *project)
void MiniProjectTargetSelector::addedTarget(Target *target) void MiniProjectTargetSelector::addedTarget(Target *target)
{ {
connect(target, SIGNAL(addedBuildConfiguration(ProjectExplorer::BuildConfiguration*)), connect(target, &Target::addedBuildConfiguration,
this, SLOT(slotAddedBuildConfiguration(ProjectExplorer::BuildConfiguration*))); this, &MiniProjectTargetSelector::slotAddedBuildConfiguration);
connect(target, SIGNAL(removedBuildConfiguration(ProjectExplorer::BuildConfiguration*)), connect(target, &Target::removedBuildConfiguration,
this, SLOT(slotRemovedBuildConfiguration(ProjectExplorer::BuildConfiguration*))); this, &MiniProjectTargetSelector::slotRemovedBuildConfiguration);
connect(target, SIGNAL(addedDeployConfiguration(ProjectExplorer::DeployConfiguration*)), connect(target, &Target::addedDeployConfiguration,
this, SLOT(slotAddedDeployConfiguration(ProjectExplorer::DeployConfiguration*))); this, &MiniProjectTargetSelector::slotAddedDeployConfiguration);
connect(target, SIGNAL(removedDeployConfiguration(ProjectExplorer::DeployConfiguration*)), connect(target, &Target::removedDeployConfiguration,
this, SLOT(slotRemovedDeployConfiguration(ProjectExplorer::DeployConfiguration*))); this, &MiniProjectTargetSelector::slotRemovedDeployConfiguration);
connect(target, SIGNAL(addedRunConfiguration(ProjectExplorer::RunConfiguration*)), connect(target, &Target::addedRunConfiguration,
this, SLOT(slotAddedRunConfiguration(ProjectExplorer::RunConfiguration*))); this, &MiniProjectTargetSelector::slotAddedRunConfiguration);
connect(target, SIGNAL(removedRunConfiguration(ProjectExplorer::RunConfiguration*)), connect(target, &Target::removedRunConfiguration,
this, SLOT(slotRemovedRunConfiguration(ProjectExplorer::RunConfiguration*))); this, &MiniProjectTargetSelector::slotRemovedRunConfiguration);
if (target->project() == m_project) if (target->project() == m_project)
m_listWidgets[TARGET]->addProjectConfiguration(target); m_listWidgets[TARGET]->addProjectConfiguration(target);
@@ -1056,20 +1056,20 @@ void MiniProjectTargetSelector::slotAddedTarget(Target *target)
void MiniProjectTargetSelector::removedTarget(Target *target) void MiniProjectTargetSelector::removedTarget(Target *target)
{ {
disconnect(target, SIGNAL(addedBuildConfiguration(ProjectExplorer::BuildConfiguration*)), disconnect(target, &Target::addedBuildConfiguration,
this, SLOT(slotAddedBuildConfiguration(ProjectExplorer::BuildConfiguration*))); this, &MiniProjectTargetSelector::slotAddedBuildConfiguration);
disconnect(target, SIGNAL(removedBuildConfiguration(ProjectExplorer::BuildConfiguration*)), disconnect(target, &Target::removedBuildConfiguration,
this, SLOT(slotRemovedBuildConfiguration(ProjectExplorer::BuildConfiguration*))); this, &MiniProjectTargetSelector::slotRemovedBuildConfiguration);
disconnect(target, SIGNAL(addedDeployConfiguration(ProjectExplorer::DeployConfiguration*)), disconnect(target, &Target::addedDeployConfiguration,
this, SLOT(slotAddedDeployConfiguration(ProjectExplorer::DeployConfiguration*))); this, &MiniProjectTargetSelector::slotAddedDeployConfiguration);
disconnect(target, SIGNAL(removedDeployConfiguration(ProjectExplorer::DeployConfiguration*)), disconnect(target, &Target::removedDeployConfiguration,
this, SLOT(slotRemovedDeployConfiguration(ProjectExplorer::DeployConfiguration*))); this, &MiniProjectTargetSelector::slotRemovedDeployConfiguration);
disconnect(target, SIGNAL(addedRunConfiguration(ProjectExplorer::RunConfiguration*)), disconnect(target, &Target::addedRunConfiguration,
this, SLOT(slotAddedRunConfiguration(ProjectExplorer::RunConfiguration*))); this, &MiniProjectTargetSelector::slotAddedRunConfiguration);
disconnect(target, SIGNAL(removedRunConfiguration(ProjectExplorer::RunConfiguration*)), disconnect(target, &Target::removedRunConfiguration,
this, SLOT(slotRemovedRunConfiguration(ProjectExplorer::RunConfiguration*))); this, &MiniProjectTargetSelector::slotRemovedRunConfiguration);
if (target->project() == m_project) if (target->project() == m_project)
m_listWidgets[TARGET]->removeProjectConfiguration(target); m_listWidgets[TARGET]->removeProjectConfiguration(target);
@@ -1241,13 +1241,13 @@ void MiniProjectTargetSelector::updateRunListVisible()
void MiniProjectTargetSelector::changeStartupProject(Project *project) void MiniProjectTargetSelector::changeStartupProject(Project *project)
{ {
if (m_project) { if (m_project) {
disconnect(m_project, SIGNAL(activeTargetChanged(ProjectExplorer::Target*)), disconnect(m_project, &Project::activeTargetChanged,
this, SLOT(activeTargetChanged(ProjectExplorer::Target*))); this, &MiniProjectTargetSelector::activeTargetChanged);
} }
m_project = project; m_project = project;
if (m_project) { if (m_project) {
connect(m_project, SIGNAL(activeTargetChanged(ProjectExplorer::Target*)), connect(m_project, &Project::activeTargetChanged,
this, SLOT(activeTargetChanged(ProjectExplorer::Target*))); this, &MiniProjectTargetSelector::activeTargetChanged);
activeTargetChanged(m_project->activeTarget()); activeTargetChanged(m_project->activeTarget());
} else { } else {
activeTargetChanged(0); activeTargetChanged(0);
@@ -1268,18 +1268,18 @@ void MiniProjectTargetSelector::changeStartupProject(Project *project)
void MiniProjectTargetSelector::activeTargetChanged(Target *target) void MiniProjectTargetSelector::activeTargetChanged(Target *target)
{ {
if (m_target) { if (m_target) {
disconnect(m_target, SIGNAL(displayNameChanged()), disconnect(m_target, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
disconnect(m_target, SIGNAL(toolTipChanged()), disconnect(m_target, &Target::toolTipChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
disconnect(m_target, SIGNAL(iconChanged()), disconnect(m_target, &Target::iconChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
disconnect(m_target, SIGNAL(activeBuildConfigurationChanged(ProjectExplorer::BuildConfiguration*)), disconnect(m_target, &Target::activeBuildConfigurationChanged,
this, SLOT(activeBuildConfigurationChanged(ProjectExplorer::BuildConfiguration*))); this, &MiniProjectTargetSelector::activeBuildConfigurationChanged);
disconnect(m_target, SIGNAL(activeDeployConfigurationChanged(ProjectExplorer::DeployConfiguration*)), disconnect(m_target, &Target::activeDeployConfigurationChanged,
this, SLOT(activeDeployConfigurationChanged(ProjectExplorer::DeployConfiguration*))); this, &MiniProjectTargetSelector::activeDeployConfigurationChanged);
disconnect(m_target, SIGNAL(activeRunConfigurationChanged(ProjectExplorer::RunConfiguration*)), disconnect(m_target, &Target::activeRunConfigurationChanged,
this, SLOT(activeRunConfigurationChanged(ProjectExplorer::RunConfiguration*))); this, &MiniProjectTargetSelector::activeRunConfigurationChanged);
} }
m_target = target; m_target = target;
@@ -1289,15 +1289,15 @@ void MiniProjectTargetSelector::activeTargetChanged(Target *target)
m_listWidgets[TARGET]->setActiveProjectConfiguration(m_target); m_listWidgets[TARGET]->setActiveProjectConfiguration(m_target);
if (m_buildConfiguration) if (m_buildConfiguration)
disconnect(m_buildConfiguration, SIGNAL(displayNameChanged()), disconnect(m_buildConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
if (m_deployConfiguration) if (m_deployConfiguration)
disconnect(m_deployConfiguration, SIGNAL(displayNameChanged()), disconnect(m_deployConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
if (m_runConfiguration) if (m_runConfiguration)
disconnect(m_runConfiguration, SIGNAL(displayNameChanged()), disconnect(m_runConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
if (m_target) { if (m_target) {
QList<ProjectConfiguration *> bl; QList<ProjectConfiguration *> bl;
@@ -1317,29 +1317,29 @@ void MiniProjectTargetSelector::activeTargetChanged(Target *target)
m_buildConfiguration = m_target->activeBuildConfiguration(); m_buildConfiguration = m_target->activeBuildConfiguration();
if (m_buildConfiguration) if (m_buildConfiguration)
connect(m_buildConfiguration, SIGNAL(displayNameChanged()), connect(m_buildConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
m_deployConfiguration = m_target->activeDeployConfiguration(); m_deployConfiguration = m_target->activeDeployConfiguration();
if (m_deployConfiguration) if (m_deployConfiguration)
connect(m_deployConfiguration, SIGNAL(displayNameChanged()), connect(m_deployConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
m_runConfiguration = m_target->activeRunConfiguration(); m_runConfiguration = m_target->activeRunConfiguration();
if (m_runConfiguration) if (m_runConfiguration)
connect(m_runConfiguration, SIGNAL(displayNameChanged()), connect(m_runConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
connect(m_target, SIGNAL(displayNameChanged()), connect(m_target, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
connect(m_target, SIGNAL(toolTipChanged()), connect(m_target, &Target::toolTipChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
connect(m_target, SIGNAL(iconChanged()), connect(m_target, &Target::iconChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
connect(m_target, SIGNAL(activeBuildConfigurationChanged(ProjectExplorer::BuildConfiguration*)), connect(m_target, &Target::activeBuildConfigurationChanged,
this, SLOT(activeBuildConfigurationChanged(ProjectExplorer::BuildConfiguration*))); this, &MiniProjectTargetSelector::activeBuildConfigurationChanged);
connect(m_target, SIGNAL(activeDeployConfigurationChanged(ProjectExplorer::DeployConfiguration*)), connect(m_target, &Target::activeDeployConfigurationChanged,
this, SLOT(activeDeployConfigurationChanged(ProjectExplorer::DeployConfiguration*))); this, &MiniProjectTargetSelector::activeDeployConfigurationChanged);
connect(m_target, SIGNAL(activeRunConfigurationChanged(ProjectExplorer::RunConfiguration*)), connect(m_target, &Target::activeRunConfigurationChanged,
this, SLOT(activeRunConfigurationChanged(ProjectExplorer::RunConfiguration*))); this, &MiniProjectTargetSelector::activeRunConfigurationChanged);
} else { } else {
m_listWidgets[BUILD]->setProjectConfigurations(QList<ProjectConfiguration *>(), 0); m_listWidgets[BUILD]->setProjectConfigurations(QList<ProjectConfiguration *>(), 0);
m_listWidgets[DEPLOY]->setProjectConfigurations(QList<ProjectConfiguration *>(), 0); m_listWidgets[DEPLOY]->setProjectConfigurations(QList<ProjectConfiguration *>(), 0);
@@ -1360,12 +1360,12 @@ void MiniProjectTargetSelector::kitChanged(Kit *k)
void MiniProjectTargetSelector::activeBuildConfigurationChanged(BuildConfiguration *bc) void MiniProjectTargetSelector::activeBuildConfigurationChanged(BuildConfiguration *bc)
{ {
if (m_buildConfiguration) if (m_buildConfiguration)
disconnect(m_buildConfiguration, SIGNAL(displayNameChanged()), disconnect(m_buildConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
m_buildConfiguration = bc; m_buildConfiguration = bc;
if (m_buildConfiguration) if (m_buildConfiguration)
connect(m_buildConfiguration, SIGNAL(displayNameChanged()), connect(m_buildConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
m_listWidgets[BUILD]->setActiveProjectConfiguration(bc); m_listWidgets[BUILD]->setActiveProjectConfiguration(bc);
updateActionAndSummary(); updateActionAndSummary();
} }
@@ -1373,12 +1373,12 @@ void MiniProjectTargetSelector::activeBuildConfigurationChanged(BuildConfigurati
void MiniProjectTargetSelector::activeDeployConfigurationChanged(DeployConfiguration *dc) void MiniProjectTargetSelector::activeDeployConfigurationChanged(DeployConfiguration *dc)
{ {
if (m_deployConfiguration) if (m_deployConfiguration)
disconnect(m_deployConfiguration, SIGNAL(displayNameChanged()), disconnect(m_deployConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
m_deployConfiguration = dc; m_deployConfiguration = dc;
if (m_deployConfiguration) if (m_deployConfiguration)
connect(m_deployConfiguration, SIGNAL(displayNameChanged()), connect(m_deployConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
m_listWidgets[DEPLOY]->setActiveProjectConfiguration(dc); m_listWidgets[DEPLOY]->setActiveProjectConfiguration(dc);
updateActionAndSummary(); updateActionAndSummary();
} }
@@ -1386,12 +1386,12 @@ void MiniProjectTargetSelector::activeDeployConfigurationChanged(DeployConfigura
void MiniProjectTargetSelector::activeRunConfigurationChanged(RunConfiguration *rc) void MiniProjectTargetSelector::activeRunConfigurationChanged(RunConfiguration *rc)
{ {
if (m_runConfiguration) if (m_runConfiguration)
disconnect(m_runConfiguration, SIGNAL(displayNameChanged()), disconnect(m_runConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
m_runConfiguration = rc; m_runConfiguration = rc;
if (m_runConfiguration) if (m_runConfiguration)
connect(m_runConfiguration, SIGNAL(displayNameChanged()), connect(m_runConfiguration, &ProjectConfiguration::displayNameChanged,
this, SLOT(updateActionAndSummary())); this, &MiniProjectTargetSelector::updateActionAndSummary);
m_listWidgets[RUN]->setActiveProjectConfiguration(rc); m_listWidgets[RUN]->setActiveProjectConfiguration(rc);
updateActionAndSummary(); updateActionAndSummary();
} }
@@ -1472,7 +1472,7 @@ void MiniProjectTargetSelector::delayedHide()
QDateTime current = QDateTime::currentDateTime(); QDateTime current = QDateTime::currentDateTime();
if (m_earliestHidetime > current) { if (m_earliestHidetime > current) {
// schedule for later // schedule for later
QTimer::singleShot(current.msecsTo(m_earliestHidetime) + 50, this, SLOT(delayedHide())); QTimer::singleShot(current.msecsTo(m_earliestHidetime) + 50, this, &MiniProjectTargetSelector::delayedHide);
} else { } else {
hide(); hide();
} }

View File

@@ -73,13 +73,12 @@ class ProjectListWidget : public ListWidget
Q_OBJECT Q_OBJECT
public: public:
explicit ProjectListWidget(QWidget *parent = 0); explicit ProjectListWidget(QWidget *parent = 0);
private slots: private:
void addProject(ProjectExplorer::Project *project); void addProject(ProjectExplorer::Project *project);
void removeProject(ProjectExplorer::Project *project); void removeProject(ProjectExplorer::Project *project);
void projectDisplayNameChanged(ProjectExplorer::Project *project); void projectDisplayNameChanged(ProjectExplorer::Project *project);
void changeStartupProject(ProjectExplorer::Project *project); void changeStartupProject(ProjectExplorer::Project *project);
void setProject(int index); void setProject(int index);
private:
QListWidgetItem *itemForProject(Project *project); QListWidgetItem *itemForProject(Project *project);
QString fullName(Project *project); QString fullName(Project *project);
bool m_ignoreIndexChange; bool m_ignoreIndexChange;
@@ -92,13 +91,11 @@ public:
explicit KitAreaWidget(QWidget *parent = 0); explicit KitAreaWidget(QWidget *parent = 0);
~KitAreaWidget(); ~KitAreaWidget();
public slots:
void setKit(ProjectExplorer::Kit *k); void setKit(ProjectExplorer::Kit *k);
private slots: private:
void updateKit(ProjectExplorer::Kit *k); void updateKit(ProjectExplorer::Kit *k);
private:
QGridLayout *m_layout; QGridLayout *m_layout;
Kit *m_kit; Kit *m_kit;
QList<KitConfigWidget *> m_widgets; QList<KitConfigWidget *> m_widgets;
@@ -117,10 +114,9 @@ public:
void setActiveProjectConfiguration(ProjectConfiguration *active); void setActiveProjectConfiguration(ProjectConfiguration *active);
void addProjectConfiguration(ProjectConfiguration *pc); void addProjectConfiguration(ProjectConfiguration *pc);
void removeProjectConfiguration(ProjectConfiguration *pc); void removeProjectConfiguration(ProjectConfiguration *pc);
private slots: private:
void rowChanged(int index); void rowChanged(int index);
void displayNameChanged(); void displayNameChanged();
private:
QListWidgetItem *itemForProjectConfiguration(ProjectConfiguration *pc); QListWidgetItem *itemForProjectConfiguration(ProjectConfiguration *pc);
bool m_ignoreIndexChange; bool m_ignoreIndexChange;
}; };
@@ -136,11 +132,11 @@ public:
void keyPressEvent(QKeyEvent *ke); void keyPressEvent(QKeyEvent *ke);
void keyReleaseEvent(QKeyEvent *ke); void keyReleaseEvent(QKeyEvent *ke);
bool event(QEvent *event); bool event(QEvent *event);
public slots:
void toggleVisible(); void toggleVisible();
void nextOrShow(); void nextOrShow();
private slots: private:
void projectAdded(ProjectExplorer::Project *project); void projectAdded(ProjectExplorer::Project *project);
void projectRemoved(ProjectExplorer::Project *project); void projectRemoved(ProjectExplorer::Project *project);
void slotAddedTarget(ProjectExplorer::Target *target); void slotAddedTarget(ProjectExplorer::Target *target);
@@ -167,7 +163,6 @@ private slots:
void delayedHide(); void delayedHide();
void updateActionAndSummary(); void updateActionAndSummary();
void switchToProjectsMode(); void switchToProjectsMode();
private:
void addedTarget(Target *target); void addedTarget(Target *target);
void removedTarget(Target *target); void removedTarget(Target *target);
void addedBuildConfiguration(BuildConfiguration* bc); void addedBuildConfiguration(BuildConfiguration* bc);

View File

@@ -68,11 +68,10 @@ public:
signals: signals:
void aboutToDeleteParser(); void aboutToDeleteParser();
private slots: private:
void outputAdded(const QString &string, ProjectExplorer::BuildStep::OutputFormat format); void outputAdded(const QString &string, ProjectExplorer::BuildStep::OutputFormat format);
void taskAdded(const ProjectExplorer::Task &task, int linkedLines, int skipLines); void taskAdded(const ProjectExplorer::Task &task, int linkedLines, int skipLines);
private:
void reset(); void reset();
bool m_debug; bool m_debug;

View File

@@ -237,13 +237,13 @@ ProcessStepConfigWidget::ProcessStepConfigWidget(ProcessStep *step)
updateDetails(); updateDetails();
connect(m_ui.command, SIGNAL(rawPathChanged(QString)), connect(m_ui.command, &Utils::PathChooser::rawPathChanged,
this, SLOT(commandLineEditTextEdited())); this, &ProcessStepConfigWidget::commandLineEditTextEdited);
connect(m_ui.workingDirectory, SIGNAL(rawPathChanged(QString)), connect(m_ui.workingDirectory, &Utils::PathChooser::rawPathChanged,
this, SLOT(workingDirectoryLineEditTextEdited())); this, &ProcessStepConfigWidget::workingDirectoryLineEditTextEdited);
connect(m_ui.commandArgumentsLineEdit, SIGNAL(textEdited(QString)), connect(m_ui.commandArgumentsLineEdit, &QLineEdit::textEdited,
this, SLOT(commandArgumentsLineEditTextEdited())); this, &ProcessStepConfigWidget::commandArgumentsLineEditTextEdited);
} }
void ProcessStepConfigWidget::updateDetails() void ProcessStepConfigWidget::updateDetails()

View File

@@ -93,11 +93,10 @@ public:
ProcessStepConfigWidget(ProcessStep *step); ProcessStepConfigWidget(ProcessStep *step);
virtual QString displayName() const; virtual QString displayName() const;
virtual QString summaryText() const; virtual QString summaryText() const;
private slots: private:
void commandLineEditTextEdited(); void commandLineEditTextEdited();
void workingDirectoryLineEditTextEdited(); void workingDirectoryLineEditTextEdited();
void commandArgumentsLineEditTextEdited(); void commandArgumentsLineEditTextEdited();
private:
void updateDetails(); void updateDetails();
ProcessStep *m_step; ProcessStep *m_step;
Ui::ProcessStepWidget m_ui; Ui::ProcessStepWidget m_ui;

View File

@@ -1087,13 +1087,15 @@ bool ProjectExplorerPlugin::initialize(const QStringList &arguments, QString *er
dd->m_projectSelectorAction->setEnabled(false); dd->m_projectSelectorAction->setEnabled(false);
QWidget *mainWindow = ICore::mainWindow(); QWidget *mainWindow = ICore::mainWindow();
dd->m_targetSelector = new MiniProjectTargetSelector(dd->m_projectSelectorAction, mainWindow); dd->m_targetSelector = new MiniProjectTargetSelector(dd->m_projectSelectorAction, mainWindow);
connect(dd->m_projectSelectorAction, &QAction::triggered, dd->m_targetSelector, &QWidget::show); connect(dd->m_projectSelectorAction, &QAction::triggered,
dd->m_targetSelector, &QWidget::show);
ModeManager::addProjectSelector(dd->m_projectSelectorAction); ModeManager::addProjectSelector(dd->m_projectSelectorAction);
dd->m_projectSelectorActionMenu = new QAction(this); dd->m_projectSelectorActionMenu = new QAction(this);
dd->m_projectSelectorActionMenu->setEnabled(false); dd->m_projectSelectorActionMenu->setEnabled(false);
dd->m_projectSelectorActionMenu->setText(tr("Open Build and Run Kit Selector...")); dd->m_projectSelectorActionMenu->setText(tr("Open Build and Run Kit Selector..."));
connect(dd->m_projectSelectorActionMenu, &QAction::triggered, dd->m_targetSelector, connect(dd->m_projectSelectorActionMenu, &QAction::triggered,
dd->m_targetSelector,
&MiniProjectTargetSelector::toggleVisible); &MiniProjectTargetSelector::toggleVisible);
cmd = ActionManager::registerAction(dd->m_projectSelectorActionMenu, Constants::SELECTTARGET); cmd = ActionManager::registerAction(dd->m_projectSelectorActionMenu, Constants::SELECTTARGET);
mbuild->addAction(cmd, Constants::G_BUILD_RUN); mbuild->addAction(cmd, Constants::G_BUILD_RUN);
@@ -1932,7 +1934,7 @@ void ProjectExplorerPluginPrivate::restoreSession()
connect(dd->m_welcomePage, &ProjectWelcomePage::requestProject, connect(dd->m_welcomePage, &ProjectWelcomePage::requestProject,
m_instance, &ProjectExplorerPlugin::openProjectWelcomePage); m_instance, &ProjectExplorerPlugin::openProjectWelcomePage);
dd->m_arguments = arguments; dd->m_arguments = arguments;
QTimer::singleShot(0, m_instance, SLOT(restoreSession2())); QTimer::singleShot(0, m_instance, &ProjectExplorerPlugin::restoreSession2);
updateActions(); updateActions();
} }
@@ -2949,7 +2951,8 @@ void ProjectExplorerPluginPrivate::updateRecentProjectMenu()
menu->addSeparator(); menu->addSeparator();
QAction *action = menu->addAction(QCoreApplication::translate( QAction *action = menu->addAction(QCoreApplication::translate(
"Core", Core::Constants::TR_CLEAR_MENU)); "Core", Core::Constants::TR_CLEAR_MENU));
connect(action, &QAction::triggered, this, &ProjectExplorerPluginPrivate::clearRecentProjects); connect(action, &QAction::triggered,
this, &ProjectExplorerPluginPrivate::clearRecentProjects);
} }
emit m_instance->recentProjectsChanged(); emit m_instance->recentProjectsChanged();
} }
@@ -2978,7 +2981,8 @@ void ProjectExplorerPluginPrivate::invalidateProject(Project *project)
if (debug) if (debug)
qDebug() << "ProjectExplorerPlugin::invalidateProject" << project->displayName(); qDebug() << "ProjectExplorerPlugin::invalidateProject" << project->displayName();
disconnect(project, &Project::fileListChanged, m_instance, &ProjectExplorerPlugin::fileListChanged); disconnect(project, &Project::fileListChanged,
m_instance, &ProjectExplorerPlugin::fileListChanged);
updateActions(); updateActions();
} }

View File

@@ -62,6 +62,8 @@ class PROJECTEXPLORER_EXPORT ProjectExplorerPlugin
Q_OBJECT Q_OBJECT
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "ProjectExplorer.json") Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QtCreatorPlugin" FILE "ProjectExplorer.json")
friend class ProjectExplorerPluginPrivate;
public: public:
ProjectExplorerPlugin(); ProjectExplorerPlugin();
~ProjectExplorerPlugin(); ~ProjectExplorerPlugin();
@@ -110,7 +112,7 @@ public:
static OpenProjectResult openProject(const QString &fileName); static OpenProjectResult openProject(const QString &fileName);
static OpenProjectResult openProjects(const QStringList &fileNames); static OpenProjectResult openProjects(const QStringList &fileNames);
static void showOpenProjectError(const OpenProjectResult &result); static void showOpenProjectError(const OpenProjectResult &result);
Q_SLOT void openProjectWelcomePage(const QString &fileName); static void openProjectWelcomePage(const QString &fileName);
static void unloadProject(Project *project); static void unloadProject(Project *project);
static bool saveModifiedFiles(); static bool saveModifiedFiles();
@@ -157,8 +159,7 @@ public:
static QThreadPool *sharedThreadPool(); static QThreadPool *sharedThreadPool();
private: static void openOpenProjectDialog();
static bool coreAboutToClose();
signals: signals:
void runControlStarted(ProjectExplorer::RunControl *rc); void runControlStarted(ProjectExplorer::RunControl *rc);
@@ -175,11 +176,9 @@ signals:
void updateRunActions(); void updateRunActions();
public slots: private:
static void openOpenProjectDialog(); static bool coreAboutToClose();
static void restoreSession2();
private slots:
void restoreSession2();
#ifdef WITH_TESTS #ifdef WITH_TESTS
void testAnsiFilterOutputParser_data(); void testAnsiFilterOutputParser_data();

View File

@@ -47,10 +47,12 @@ ProjectExplorerSettingsWidget::ProjectExplorerSettingsWidget(QWidget *parent) :
m_ui.directoryButtonGroup->setId(m_ui.currentDirectoryRadioButton, UseCurrentDirectory); m_ui.directoryButtonGroup->setId(m_ui.currentDirectoryRadioButton, UseCurrentDirectory);
m_ui.directoryButtonGroup->setId(m_ui.directoryRadioButton, UseProjectDirectory); m_ui.directoryButtonGroup->setId(m_ui.directoryRadioButton, UseProjectDirectory);
connect(m_ui.directoryButtonGroup, SIGNAL(buttonClicked(int)), connect(m_ui.directoryButtonGroup, static_cast<void (QButtonGroup::*)(int)>(&QButtonGroup::buttonClicked),
this, SLOT(slotDirectoryButtonGroupChanged())); this, &ProjectExplorerSettingsWidget::slotDirectoryButtonGroupChanged);
connect(m_ui.resetButton, SIGNAL(clicked()), this, SLOT(resetDefaultBuildDirectory())); connect(m_ui.resetButton, &QAbstractButton::clicked,
connect(m_ui.buildDirectoryEdit, SIGNAL(textChanged(QString)), this, SLOT(updateResetButton())); this, &ProjectExplorerSettingsWidget::resetDefaultBuildDirectory);
connect(m_ui.buildDirectoryEdit, &QLineEdit::textChanged,
this, &ProjectExplorerSettingsWidget::updateResetButton);
auto chooser = new Core::VariableChooser(this); auto chooser = new Core::VariableChooser(this);
chooser->addSupportedWidget(m_ui.buildDirectoryEdit); chooser->addSupportedWidget(m_ui.buildDirectoryEdit);

Some files were not shown because too many files have changed in this diff Show More