From 1608fa52657a03f85e688adb86cb4cab5d8f05a7 Mon Sep 17 00:00:00 2001 From: Miikka Heikkinen Date: Wed, 12 May 2021 12:23:12 +0300 Subject: [PATCH] QmlPuppet: Fix warning about extra argument to function call MouseArea3D::applyFreeRotation only takes four arguments, so remove the unused _targetPosOnScreen property. Change-Id: I10940f6954de89cb7a01bdbea6a0a55e69cb9c65 Reviewed-by: Mahmoud Badri --- share/qtcreator/qml/qmlpuppet/mockfiles/RotateGizmo.qml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/share/qtcreator/qml/qmlpuppet/mockfiles/RotateGizmo.qml b/share/qtcreator/qml/qmlpuppet/mockfiles/RotateGizmo.qml index 6fccfbcdc79..d691f3f0cf3 100644 --- a/share/qtcreator/qml/qmlpuppet/mockfiles/RotateGizmo.qml +++ b/share/qtcreator/qml/qmlpuppet/mockfiles/RotateGizmo.qml @@ -184,7 +184,6 @@ Node { property bool dragging: false property vector3d _pointerPosPressed - property vector3d _targetPosOnScreen property vector3d _startRotation function handlePressed(screenPos) @@ -195,8 +194,6 @@ Node { // Need to recreate vector as we need to adjust it and we can't do that on reference of // scenePosition, which is read-only property var scenePos = rotateGizmo.dragHelper.pivotScenePosition(rotateGizmo.targetNode); - _targetPosOnScreen = view3D.mapFrom3DScene(scenePos); - _targetPosOnScreen.z = 0; _pointerPosPressed = Qt.vector3d(screenPos.x, screenPos.y, 0); // Recreate vector so we don't follow the changes in targetNode.rotation @@ -213,7 +210,7 @@ Node { mouseAreaFree.applyFreeRotation( rotateGizmo.targetNode, _startRotation, _pointerPosPressed, - Qt.vector3d(screenPos.x, screenPos.y, 0), _targetPosOnScreen); + Qt.vector3d(screenPos.x, screenPos.y, 0)); rotateGizmo.rotateChange(); } @@ -225,7 +222,7 @@ Node { mouseAreaFree.applyFreeRotation( rotateGizmo.targetNode, _startRotation, _pointerPosPressed, - Qt.vector3d(screenPos.x, screenPos.y, 0), _targetPosOnScreen); + Qt.vector3d(screenPos.x, screenPos.y, 0)); rotateGizmo.rotateCommit(); dragging = false;