feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Change prev/next icons on toolbars to up/down arrows

Browse Source 
Because issues, search results and others on output pane are listed vertically,
up/down arrows are better than left/right arrows.

Change-Id: If73ec0270e6b448d2487173707ff839f52f35caf
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Tasuku Suzuki
2020-07-10 18:44:18 +09:00
committed by Tasuku Suzuki
parent d7ed48ac6f
commit 162c68cb79
3 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/utils/utilsicons.cpp
View File

@@ -139,8 +139,12 @@ const Icon RESET_TOOLBAR({
const Icon ARROW_UP({ const Icon ARROW_UP({
{":/utils/images/arrowup.png", Theme::IconsBaseColor}}); {":/utils/images/arrowup.png", Theme::IconsBaseColor}});
const Icon ARROW_UP_TOOLBAR({
{":/utils/images/arrowup.png", Theme::IconsNavigationArrowsColor}});
const Icon ARROW_DOWN({ const Icon ARROW_DOWN({
{":/utils/images/arrowdown.png", Theme::IconsBaseColor}}); {":/utils/images/arrowdown.png", Theme::IconsBaseColor}});
const Icon ARROW_DOWN_TOOLBAR({
{":/utils/images/arrowdown.png", Theme::IconsNavigationArrowsColor}});
const Icon MINUS({ const Icon MINUS({
{":/utils/images/minus.png", Theme::IconsBaseColor}}); {":/utils/images/minus.png", Theme::IconsBaseColor}});
const Icon PLUS_TOOLBAR({ const Icon PLUS_TOOLBAR({

2
src/libs/utils/utilsicons.h
View File

@@ -86,7 +86,9 @@ QTCREATOR_UTILS_EXPORT extern const Icon RESET;
QTCREATOR_UTILS_EXPORT extern const Icon RESET_TOOLBAR; QTCREATOR_UTILS_EXPORT extern const Icon RESET_TOOLBAR;
QTCREATOR_UTILS_EXPORT extern const Icon ARROW_UP; QTCREATOR_UTILS_EXPORT extern const Icon ARROW_UP;
QTCREATOR_UTILS_EXPORT extern const Icon ARROW_UP_TOOLBAR;
QTCREATOR_UTILS_EXPORT extern const Icon ARROW_DOWN; QTCREATOR_UTILS_EXPORT extern const Icon ARROW_DOWN;
QTCREATOR_UTILS_EXPORT extern const Icon ARROW_DOWN_TOOLBAR;
QTCREATOR_UTILS_EXPORT extern const Icon MINUS; QTCREATOR_UTILS_EXPORT extern const Icon MINUS;
QTCREATOR_UTILS_EXPORT extern const Icon PLUS_TOOLBAR; QTCREATOR_UTILS_EXPORT extern const Icon PLUS_TOOLBAR;
QTCREATOR_UTILS_EXPORT extern const Icon PLUS; QTCREATOR_UTILS_EXPORT extern const Icon PLUS;

8
src/plugins/coreplugin/outputpanemanager.cpp
View File

@@ -341,12 +341,12 @@ OutputPaneManager::OutputPaneManager(QWidget *parent) :
connect(m_clearAction, &QAction::triggered, this, &OutputPaneManager::clearPage); connect(m_clearAction, &QAction::triggered, this, &OutputPaneManager::clearPage);
m_nextAction = new QAction(this); m_nextAction = new QAction(this);
m_nextAction->setIcon(Utils::Icons::NEXT.icon()); m_nextAction->setIcon(Utils::Icons::ARROW_DOWN_TOOLBAR.icon());
m_nextAction->setText(tr("Next Item")); m_nextAction->setText(tr("Next Item"));
connect(m_nextAction, &QAction::triggered, this, &OutputPaneManager::slotNext); connect(m_nextAction, &QAction::triggered, this, &OutputPaneManager::slotNext);
m_prevAction = new QAction(this); m_prevAction = new QAction(this);
m_prevAction->setIcon(Utils::Icons::PREV.icon()); m_prevAction->setIcon(Utils::Icons::ARROW_UP_TOOLBAR.icon());
m_prevAction->setText(tr("Previous Item")); m_prevAction->setText(tr("Previous Item"));
connect(m_prevAction, &QAction::triggered, this, &OutputPaneManager::slotPrev); connect(m_prevAction, &QAction::triggered, this, &OutputPaneManager::slotPrev);
@@ -410,12 +410,12 @@ OutputPaneManager::OutputPaneManager(QWidget *parent) :
cmd = ActionManager::registerAction(m_prevAction, "Coreplugin.OutputPane.previtem"); cmd = ActionManager::registerAction(m_prevAction, "Coreplugin.OutputPane.previtem");
cmd->setDefaultKeySequence(QKeySequence(tr("Shift+F6"))); cmd->setDefaultKeySequence(QKeySequence(tr("Shift+F6")));
m_prevToolButton->setDefaultAction( m_prevToolButton->setDefaultAction(
ProxyAction::proxyActionWithIcon(m_prevAction, Utils::Icons::PREV_TOOLBAR.icon())); ProxyAction::proxyActionWithIcon(m_prevAction, Utils::Icons::ARROW_UP_TOOLBAR.icon()));
mpanes->addAction(cmd, "Coreplugin.OutputPane.ActionsGroup"); mpanes->addAction(cmd, "Coreplugin.OutputPane.ActionsGroup");
cmd = ActionManager::registerAction(m_nextAction, "Coreplugin.OutputPane.nextitem"); cmd = ActionManager::registerAction(m_nextAction, "Coreplugin.OutputPane.nextitem");
m_nextToolButton->setDefaultAction( m_nextToolButton->setDefaultAction(
ProxyAction::proxyActionWithIcon(m_nextAction, Utils::Icons::NEXT_TOOLBAR.icon())); ProxyAction::proxyActionWithIcon(m_nextAction, Utils::Icons::ARROW_DOWN_TOOLBAR.icon()));
cmd->setDefaultKeySequence(QKeySequence(tr("F6"))); cmd->setDefaultKeySequence(QKeySequence(tr("F6")));
mpanes->addAction(cmd, "Coreplugin.OutputPane.ActionsGroup"); mpanes->addAction(cmd, "Coreplugin.OutputPane.ActionsGroup");