From 168c5c67a28f113f49fc7e275cf24491215599e7 Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Thu, 1 Dec 2016 14:15:52 +0100 Subject: [PATCH] CMake: No need to update the reader when it already is up to date The reader notifies us about the configuration being changed, so there is no need to tell it about those changes again. Change-Id: I458947babf1cd9c50a66ea7863f37d1e43d6c5f2 Reviewed-by: Tim Jenssen --- src/plugins/cmakeprojectmanager/builddirmanager.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/plugins/cmakeprojectmanager/builddirmanager.cpp b/src/plugins/cmakeprojectmanager/builddirmanager.cpp index 1d7e6853a29..65ddce01ead 100644 --- a/src/plugins/cmakeprojectmanager/builddirmanager.cpp +++ b/src/plugins/cmakeprojectmanager/builddirmanager.cpp @@ -466,10 +466,8 @@ void BuildDirManager::checkConfiguration() box->setDefaultButton(defaultButton); int ret = box->exec(); - if (ret == QMessageBox::Apply) { + if (ret == QMessageBox::Apply) m_buildConfiguration->setCMakeConfiguration(newConfig); - updateReaderData(); // Apply changes to reader - } } }