From 16b5d20ab8b91e493995ce31bad2b0713251d07d Mon Sep 17 00:00:00 2001 From: hjk Date: Fri, 17 Dec 2010 12:02:23 +0100 Subject: [PATCH] debugger: reality check, adjust FIXME comment re. use of gdb 6.8 --- src/plugins/debugger/gdb/gdbengine.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/plugins/debugger/gdb/gdbengine.cpp b/src/plugins/debugger/gdb/gdbengine.cpp index c45a2d13557..d53b9969557 100644 --- a/src/plugins/debugger/gdb/gdbengine.cpp +++ b/src/plugins/debugger/gdb/gdbengine.cpp @@ -1207,16 +1207,18 @@ void GdbEngine::handleStopResponse(const GdbMi &data) } // FIXME: Replace the #ifdef by the "target" architecture. - // FIXME: Is this needed at all anymore? #ifdef Q_OS_LINUX if (!m_entryPoint.isEmpty()) { + // This is needed as long as we support stock gdb 6.8. if (frame.findChild("addr").data() == m_entryPoint) { // There are two expected reasons for getting here: - // 1) For some reason, attaching to a stopped process causes *two* SIGSTOPs + // 1) For some reason, attaching to a stopped process causes *two* + // SIGSTOPs // when trying to continue (kernel i386 2.6.24-23-ubuntu, gdb 6.8). // Interestingly enough, on MacOSX no signal is delivered at all. // 2) The explicit tbreak at the entry point we set to query the PID. - // Gdb <= 6.8 reports a frame but no reason, 6.8.50+ reports everything. + // Gdb <= 6.8 reports a frame but no reason, 6.8.50+ reports + // everything. // The case of the user really setting a breakpoint at _start is simply // unsupported. if (!inferiorPid()) // For programs without -pthread under gdb <= 6.8.