From 1726998244ea62b78fd86a1a93e902a6e58ba510 Mon Sep 17 00:00:00 2001
From: Christian Stenger <christian.stenger@qt.io>
Date: Wed, 7 Aug 2024 12:43:37 +0200
Subject: [PATCH] Axivion: Redo toggling inline issues

Toggling annotations and enabling highlighting on the
scrollbar are different things.
Kind of reverts 2a4c8af193aa8c1eb866501ec06d171735017fc6.

Change-Id: I2d33bbc51c355653b8b9ab9feaf6044be681669e
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
---
 src/plugins/axivion/axivionoutputpane.cpp | 14 ++++++++------
 src/plugins/axivion/axivionplugin.cpp     |  6 ------
 2 files changed, 8 insertions(+), 12 deletions(-)

diff --git a/src/plugins/axivion/axivionoutputpane.cpp b/src/plugins/axivion/axivionoutputpane.cpp
index 4c8ca4eaa9a..9b0a773ae9f 100644
--- a/src/plugins/axivion/axivionoutputpane.cpp
+++ b/src/plugins/axivion/axivionoutputpane.cpp
@@ -18,6 +18,8 @@
 
 #include <solutions/tasking/tasktreerunner.h>
 
+#include <texteditor/textdocument.h>
+
 #include <utils/algorithm.h>
 #include <utils/guard.h>
 #include <utils/layoutbuilder.h>
@@ -852,14 +854,14 @@ public:
 
         m_toggleIssues = new QToolButton(m_outputWidget);
         m_toggleIssues->setIcon(Utils::Icons::WARNING_TOOLBAR.icon());
-        m_toggleIssues->setToolTip(Tr::tr("Show issue markers inline"));
+        m_toggleIssues->setToolTip(Tr::tr("Show issue annotations inline"));
         m_toggleIssues->setCheckable(true);
-        m_toggleIssues->setChecked(settings().highlightMarks());
+        m_toggleIssues->setChecked(true);
         connect(m_toggleIssues, &QToolButton::toggled, this, [](bool checked) {
-            settings().highlightMarks.setValue(checked);
-        });
-        connect(&settings().highlightMarks, &BaseAspect::changed, this, [this] {
-            m_toggleIssues->setChecked(settings().highlightMarks());
+            if (checked)
+                TextEditor::TextDocument::showMarksAnnotation("AxivionTextMark");
+            else
+                TextEditor::TextDocument::temporaryHideMarksAnnotation("AxivionTextMark");
         });
     }
 
diff --git a/src/plugins/axivion/axivionplugin.cpp b/src/plugins/axivion/axivionplugin.cpp
index 475cca04dbb..7fc8a15cf3d 100644
--- a/src/plugins/axivion/axivionplugin.cpp
+++ b/src/plugins/axivion/axivionplugin.cpp
@@ -313,12 +313,6 @@ AxivionPluginPrivate::AxivionPluginPrivate()
     connect(&m_networkAccessManager, &QNetworkAccessManager::sslErrors,
             this, &AxivionPluginPrivate::handleSslErrors);
 #endif // ssl
-    connect(&settings().highlightMarks, &BoolAspect::changed, this, [this] {
-        if (settings().highlightMarks())
-            handleOpenedDocs();
-        else
-            clearAllMarks();
-    });
 }
 
 void AxivionPluginPrivate::handleSslErrors(QNetworkReply *reply, const QList<QSslError> &errors)