feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Utils: Use string view instead of a string

Browse Source 
This is preventing unneeded mallocs.

Change-Id: Ia1f9b1be90635e7aa8b4b6f6e6705e5671f946c5
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Marco Bubke
2017-07-31 16:07:10 +02:00
parent daa3aad651
commit 1727e64349
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libs/utils/smallstring.h
View File

@@ -532,16 +532,16 @@ public:
} }
static static
BasicSmallString join(std::initializer_list<BasicSmallString> list) BasicSmallString join(std::initializer_list<SmallStringView> list)
{ {
size_type totalSize = 0; size_type totalSize = 0;
for (const BasicSmallString &string : list) for (SmallStringView string : list)
totalSize += string.size(); totalSize += string.size();
BasicSmallString joinedString; BasicSmallString joinedString;
joinedString.reserve(totalSize); joinedString.reserve(totalSize);
for (const BasicSmallString &string : list) for (SmallStringView string : list)
joinedString.append(string); joinedString.append(string);
return joinedString; return joinedString;