forked from qt-creator/qt-creator
New QTC_CHECK warning replacing QTC_ASSERT(x, /**/)
Warn if the condition fails, but otherwise don't change the execution flow. Change-Id: Id7b14c745109b66960add967b2a4ef8d31e1a546 Reviewed-on: http://codereview.qt.nokia.com/2389 Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
This commit is contained in:
@@ -565,7 +565,7 @@ MimeTypeData::MimeTypeData()
|
||||
// "*.log[1-9]"
|
||||
: suffixPattern(QLatin1String("^\\*\\.[\\w+]+$"))
|
||||
{
|
||||
QTC_ASSERT(suffixPattern.isValid(), /**/);
|
||||
QTC_CHECK(suffixPattern.isValid());
|
||||
}
|
||||
|
||||
void MimeTypeData::clear()
|
||||
|
||||
@@ -165,7 +165,7 @@ static QScriptValue fileBox(QScriptContext *context, QScriptEngine *engine)
|
||||
if (fileDialog.exec() == QDialog::Rejected)
|
||||
return QScriptValue(engine, QScriptValue::NullValue);
|
||||
const QStringList rc = fileDialog.selectedFiles();
|
||||
QTC_ASSERT(!rc.empty(), /**/);
|
||||
QTC_CHECK(!rc.empty());
|
||||
return TFileMode == QFileDialog::ExistingFiles ?
|
||||
engine->toScriptValue(rc) : engine->toScriptValue(rc.front());
|
||||
}
|
||||
|
||||
@@ -102,7 +102,7 @@ VersionDialog::VersionDialog(QWidget *parent)
|
||||
|
||||
QDialogButtonBox *buttonBox = new QDialogButtonBox(QDialogButtonBox::Close);
|
||||
QPushButton *closeButton = buttonBox->button(QDialogButtonBox::Close);
|
||||
QTC_ASSERT(closeButton, /**/);
|
||||
QTC_CHECK(closeButton);
|
||||
buttonBox->addButton(closeButton, QDialogButtonBox::ButtonRole(QDialogButtonBox::RejectRole | QDialogButtonBox::AcceptRole));
|
||||
connect(buttonBox , SIGNAL(rejected()), this, SLOT(reject()));
|
||||
|
||||
|
||||
Reference in New Issue
Block a user