feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CoreUnpacker: Get rid of no-op call to QtcProcess::terminate()

Browse Source 
Calling QtcProcess::terminate() after disconecting from
process signals is a task for implicit ProcessReaper.
Delete the process instead.

Change-Id: I59b0aa1d9df602077d006084635a5321beae0010
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2022-03-25 18:37:08 +01:00
parent a3c531c2a3
commit 176ec31817
1 changed files with 0 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/debugger/debuggerruncontrol.cpp
View File

@@ -116,9 +116,6 @@ public:
private: private:
~CoreUnpacker() final ~CoreUnpacker() final
{ {
m_coreUnpackProcess.blockSignals(true);
m_coreUnpackProcess.terminate();
m_coreUnpackProcess.deleteLater();
if (m_tempCoreFile.isOpen()) if (m_tempCoreFile.isOpen())
m_tempCoreFile.close(); m_tempCoreFile.close();