From 184703437179b0f49a64428aed58ef90bbbf98d2 Mon Sep 17 00:00:00 2001 From: Nikolai Kosjar Date: Mon, 4 Sep 2017 10:33:07 +0200 Subject: [PATCH] ClangStaticAnalyzer: Update comment about -dumpversion Change-Id: I268e23dd6f73efcde0e6efcb04e3c0ffb946a11b Reviewed-by: Ivan Donchevskii Reviewed-by: Marco Bubke --- src/plugins/clangstaticanalyzer/clangstaticanalyzerutils.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/plugins/clangstaticanalyzer/clangstaticanalyzerutils.cpp b/src/plugins/clangstaticanalyzer/clangstaticanalyzerutils.cpp index a1a1bee67a4..073adac6798 100644 --- a/src/plugins/clangstaticanalyzer/clangstaticanalyzerutils.cpp +++ b/src/plugins/clangstaticanalyzer/clangstaticanalyzerutils.cpp @@ -126,7 +126,9 @@ ClangExecutableVersion clangExecutableVersion(const QString &executable) Utils::SynchronousProcess runner; runner.setEnvironment(environment.toStringList()); runner.setTimeoutS(10); - // We would prefer "-dumpversion", but that one returns some old version number. + // We would prefer "-dumpversion", but that one is only there for GCC compatibility + // and returns some static/old version. + // See also https://bugs.llvm.org/show_bug.cgi?id=28597 const QStringList arguments(QLatin1String(("--version"))); const Utils::SynchronousProcessResponse response = runner.runBlocking(executable, arguments); if (response.result != Utils::SynchronousProcessResponse::Finished)