feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TaskTree: Warn about recursive execution of handlers

Browse Source 
Tries to address somehow the 19th point from the task below.
This is not a full solution, yet, but a first step detecting
some of broken states.

Please note that all autotests are still fine.

Having this assert may help detecting some misusages ATM.

Task-number: QTCREATORBUG-28741
Change-Id: I7329e5acf8f2d4e058f79327878bba5bcdd71334
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2024-10-31 12:35:37 +01:00
parent d5d4e2da8e
commit 189f0d1694
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/libs/solutions/tasking/tasktree.cpp
View File

@@ -1878,6 +1878,16 @@ public:
typename ReturnType = std::invoke_result_t<Handler, Args...>> typename ReturnType = std::invoke_result_t<Handler, Args...>>
ReturnType invokeHandler(Container *container, Handler &&handler, Args &&...args) ReturnType invokeHandler(Container *container, Handler &&handler, Args &&...args)
{ {
QT_ASSERT(!m_guard.isLocked(), qWarning("Nested execution of handlers detected."
"This may happen when one task's handler has entered a nested event loop,"
"and other task finished during nested event loop's processing, "
"causing stopping (canceling) the task executing the nested event loop. "
"This includes the case when QCoreApplication::processEvents() was called from "
"the handler. It may also happen when the Barrier task is advanced directly "
"from some other task handler. This will lead to a crash. "
"Avoid event processing during handlers' execution. "
"If it can't be avoided, make sure no other tasks are run in parallel when "
"processing events from the handler."));
ExecutionContextActivator activator(container); ExecutionContextActivator activator(container);
GuardLocker locker(m_guard); GuardLocker locker(m_guard);
return std::invoke(std::forward<Handler>(handler), std::forward<Args>(args)...); return std::invoke(std::forward<Handler>(handler), std::forward<Args>(args)...);